[PATCH iproute2-next] mptcp: add implicit flag to the 'ip mptcp' inline help

[PATCH iproute2-next] mptcp: add implicit flag to the 'ip mptcp' inline help

[Andrea Claudi]

ip mptcp supports the implicit flag since commit 3a2535a41854 ("mptcp:
add support for implicit flag"), however this flag is not listed in the
command inline help.

Add the implicit flag to the inline help.

Signed-off-by: Andrea Claudi <aclaudi@redhat.com>
---
 ip/ipmptcp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ip/ipmptcp.c b/ip/ipmptcp.c
index 2415cac8..6bfdc7bb 100644
--- a/ip/ipmptcp.c
+++ b/ip/ipmptcp.c
@@ -32,7 +32,7 @@ static void usage(void)
 		"	ip mptcp limits show\n"
 		"	ip mptcp monitor\n"
 		"FLAG-LIST := [ FLAG-LIST ] FLAG\n"
-		"FLAG  := [ signal | subflow | backup | fullmesh ]\n"
+		"FLAG  := [ signal | subflow | backup | fullmesh | implicit ]\n"
 		"CHANGE-OPT := [ backup | nobackup | fullmesh | nofullmesh ]\n");
 
 	exit(-1);
-- 
2.51.0

Re: [PATCH iproute2-next] mptcp: add implicit flag to the 'ip mptcp' inline help

[Stephen Hemminger]

On Tue, 21 Oct 2025 21:26:56 +0200
Andrea Claudi <aclaudi@redhat.com> wrote:

> ip mptcp supports the implicit flag since commit 3a2535a41854 ("mptcp:
> add support for implicit flag"), however this flag is not listed in the
> command inline help.
> 
> Add the implicit flag to the inline help.
> 
> Signed-off-by: Andrea Claudi <aclaudi@redhat.com>

This is more of a fix, don't need to wait for -next

Re: [PATCH iproute2-next] mptcp: add implicit flag to the 'ip mptcp' inline help

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to iproute2/iproute2.git (main)
by Stephen Hemminger <stephen@networkplumber.org>:

On Tue, 21 Oct 2025 21:26:56 +0200 you wrote:
> ip mptcp supports the implicit flag since commit 3a2535a41854 ("mptcp:
> add support for implicit flag"), however this flag is not listed in the
> command inline help.
> 
> Add the implicit flag to the inline help.
> 
> Signed-off-by: Andrea Claudi <aclaudi@redhat.com>
> 
> [...]

Here is the summary with links:
  - [iproute2-next] mptcp: add implicit flag to the 'ip mptcp' inline help
    https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=14749b22dd8f

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Re: [PATCH iproute2-next] mptcp: add implicit flag to the 'ip mptcp' inline help

[Matthieu Baerts]

Hi Andrea,

Sorry, I'm reacting a bit too late here (but Stephen applied the patch
very quickly :) ).

On 21/10/2025 21:26, Andrea Claudi wrote:
> ip mptcp supports the implicit flag since commit 3a2535a41854 ("mptcp:
> add support for implicit flag"), however this flag is not listed in the
> command inline help.
> 
> Add the implicit flag to the inline help.

I would rather not: as written in the man page (by you in the mentioned
commit :) ) "Implicit endpoints cannot be created from user-space". Such
endpoints can be created by the MPTCP in-kernel path-manager in some
circumstances, but if the user-space cannot set the flag, then probably
better not to add it in the command inline help, no?

If someone tries to create an "implicit" endpoint, the kernel will
reject this request, see:

https://elixir.bootlin.com/linux/v6.17/source/net/mptcp/pm_kernel.c#L813

I can send a revert. I have other small changes to send.

@Stephen: while at it, would it be OK if I also add an entry for files
linked related to MPTCP in the MAINTAINERS file?

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.

Re: [PATCH iproute2-next] mptcp: add implicit flag to the 'ip mptcp' inline help

[David Ahern]

On 10/22/25 8:49 AM, Matthieu Baerts wrote:
> @Stephen: while at it, would it be OK if I also add an entry for files
> linked related to MPTCP in the MAINTAINERS file?

please do

Re: [PATCH iproute2-next] mptcp: add implicit flag to the 'ip mptcp' inline help

[Stephen Hemminger]

On Wed, 22 Oct 2025 16:49:41 +0200
Matthieu Baerts <matttbe@kernel.org> wrote:

> Hi Andrea,
> 
> Sorry, I'm reacting a bit too late here (but Stephen applied the patch
> very quickly :) ).
> 
> On 21/10/2025 21:26, Andrea Claudi wrote:
> > ip mptcp supports the implicit flag since commit 3a2535a41854 ("mptcp:
> > add support for implicit flag"), however this flag is not listed in the
> > command inline help.
> > 
> > Add the implicit flag to the inline help.  
> 
> I would rather not: as written in the man page (by you in the mentioned
> commit :) ) "Implicit endpoints cannot be created from user-space". Such
> endpoints can be created by the MPTCP in-kernel path-manager in some
> circumstances, but if the user-space cannot set the flag, then probably
> better not to add it in the command inline help, no?
> 
> If someone tries to create an "implicit" endpoint, the kernel will
> reject this request, see:
> 
> https://elixir.bootlin.com/linux/v6.17/source/net/mptcp/pm_kernel.c#L813
> 
> I can send a revert. I have other small changes to send.

Thanks I reverted it