From: Kees Cook <kees@kernel.org>
To: David Laight <david.laight.linux@gmail.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
John Fastabend <john.fastabend@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Kuniyuki Iwashima <kuniyu@google.com>,
Willem de Bruijn <willemb@google.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
bpf@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH v3 1/9] net: Add struct sockaddr_unspec for sockaddr of unknown length
Date: Thu, 23 Oct 2025 09:33:20 -0700 [thread overview]
Message-ID: <202510230932.25CE49FC8@keescook> (raw)
In-Reply-To: <20251022102624.18d2c6f7@pumpkin>
On Wed, Oct 22, 2025 at 10:26:24AM +0100, David Laight wrote:
> If you do add a #define, it can generate the size from that of the
> supplied address structure (and error things that are stupidly short).
I have more patches coming that consolidate all the open-coded casting
and size checking into a macro. So far, only a couple places weren't
doing the full checking.
--
Kees Cook
next prev parent reply other threads:[~2025-10-23 16:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-20 21:26 [PATCH v3 0/9] net: Introduce struct sockaddr_unspec Kees Cook
2025-10-20 21:26 ` [PATCH v3 1/9] net: Add struct sockaddr_unspec for sockaddr of unknown length Kees Cook
2025-10-21 9:26 ` David Laight
2025-10-21 19:42 ` Kees Cook
2025-10-22 9:26 ` David Laight
2025-10-23 16:33 ` Kees Cook [this message]
2025-10-23 10:43 ` Paolo Abeni
2025-10-23 11:40 ` David Laight
2025-10-23 16:31 ` Kees Cook
2025-10-23 10:59 ` Paolo Abeni
2025-10-23 16:20 ` Kees Cook
2025-10-20 21:26 ` [PATCH v3 2/9] net/l2tp: Add missing sa_family validation in pppol2tp_sockaddr_get_info Kees Cook
2025-10-23 10:47 ` Paolo Abeni
2025-10-23 16:01 ` Kees Cook
2025-10-20 21:26 ` [PATCH v3 3/9] net: Convert proto_ops bind() callbacks to use sockaddr_unspec Kees Cook
2025-10-20 21:26 ` [PATCH v3 4/9] net: Convert proto_ops connect() " Kees Cook
2025-10-20 21:26 ` [PATCH v3 5/9] net: Remove struct sockaddr from net.h Kees Cook
2025-10-20 21:26 ` [PATCH v3 6/9] net: Convert proto callbacks from sockaddr to sockaddr_unspec Kees Cook
2025-10-20 21:26 ` [PATCH v3 7/9] bpf: Convert cgroup sockaddr filters to use sockaddr_unspec consistently Kees Cook
2025-10-20 21:26 ` [PATCH v3 8/9] bpf: Convert bpf_sock_addr_kern "uaddr" to sockaddr_unspec Kees Cook
2025-10-20 21:26 ` [PATCH v3 9/9] net: Convert struct sockaddr to fixed-size "sa_data[14]" Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202510230932.25CE49FC8@keescook \
--to=kees@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=david.laight.linux@gmail.com \
--cc=edumazet@google.com \
--cc=gustavo@embeddedor.com \
--cc=horms@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).