netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Alexander Duyck <alexander.duyck@gmail.com>
Cc: netdev@vger.kernel.org, kernel-team@meta.com,
	andrew+netdev@lunn.ch, hkallweit1@gmail.com,
	linux@armlinux.org.uk, pabeni@redhat.com, davem@davemloft.net
Subject: Re: [net-next PATCH 7/8] fbnic: Add SW shim for MII interface to PMA/PMD
Date: Mon, 27 Oct 2025 17:43:47 -0700	[thread overview]
Message-ID: <20251027174347.16e28741@kernel.org> (raw)
In-Reply-To: <176133848134.2245037.8819965842869649833.stgit@ahduyck-xeon-server.home.arpa>

On Fri, 24 Oct 2025 13:41:21 -0700 Alexander Duyck wrote:
> +	u8 aui;
> +
> +	if (fbd->netdev) {
> +		fbn = netdev_priv(fbd->netdev);
> +		aui = fbn->aui;
> +	}
> +
> +	switch (aui) {

Compiler says:

drivers/net/ethernet/meta/fbnic/fbnic_swmii.c:17:6: warning: variable 'aui' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
   15 |         u8 aui;
      |               ^
      |                = '\0'
-- 
pw-bot: cr

  reply	other threads:[~2025-10-28  0:43 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-24 20:40 [net-next PATCH 0/8] net: phy: Add support for fbnic PHY w/ 25G, 50G, and 100G support Alexander Duyck
2025-10-24 20:40 ` [net-next PATCH 1/8] net: phy: Add support for 25, 50 and 100Gbps PMA to genphy_c45_read_pma Alexander Duyck
2025-10-28  3:12   ` Andrew Lunn
2025-10-28 15:47     ` Alexander Duyck
2025-10-24 20:40 ` [net-next PATCH 2/8] net: phy: Avoid reusing val in genphy_c45_pma_read_ext_abilities Alexander Duyck
2025-10-24 20:40 ` [net-next PATCH 3/8] net: phy: Add 25G-CR, 50G-CR, 100G-CR2 support to C45 genphy Alexander Duyck
2025-10-28  7:32   ` Maxime Chevallier
2025-10-28 22:40     ` Andrew Lunn
2025-10-28 22:49       ` Alexander Duyck
2025-10-28 12:53   ` Andrew Lunn
2025-10-28 12:57   ` Andrew Lunn
2025-10-28 15:25     ` Alexander Duyck
2025-10-24 20:41 ` [net-next PATCH 4/8] fbnic: Rename PCS IRQ to MAC IRQ as it is actually a MAC interrupt Alexander Duyck
2025-10-24 20:41 ` [net-next PATCH 5/8] fbnic: Add logic to track PMD state via MAC/PCS signals Alexander Duyck
2025-10-24 20:41 ` [net-next PATCH 6/8] fbnic: Cleanup handling for link down event statistics Alexander Duyck
2025-10-24 20:41 ` [net-next PATCH 7/8] fbnic: Add SW shim for MII interface to PMA/PMD Alexander Duyck
2025-10-28  0:43   ` Jakub Kicinski [this message]
2025-10-28 20:51   ` Andrew Lunn
2025-10-28 22:26     ` Alexander Duyck
2025-10-28 20:52   ` kernel test robot
2025-10-24 20:41 ` [net-next PATCH 8/8] fbnic: Add phydev representing PMD to phylink setup Alexander Duyck
2025-10-28 21:02   ` Andrew Lunn
2025-10-28 22:32     ` Alexander Duyck
2025-10-28 22:56       ` Andrew Lunn
2025-10-28 23:07         ` Alexander Duyck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251027174347.16e28741@kernel.org \
    --to=kuba@kernel.org \
    --cc=alexander.duyck@gmail.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=hkallweit1@gmail.com \
    --cc=kernel-team@meta.com \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).