From: Jakub Kicinski <kuba@kernel.org>
To: Abdun Nihaal <nihaal@cse.iitm.ac.in>
Cc: horms@kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com, tglx@linutronix.de,
louis.peens@corigine.com, mingo@kernel.org, mheib@redhat.com,
easwar.hariharan@linux.microsoft.com, sdf@fomichev.me,
kees@kernel.org, niklas.soderlund@corigine.com,
oss-drivers@corigine.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] nfp: xsk: fix memory leak in nfp_net_alloc()
Date: Mon, 27 Oct 2025 18:18:44 -0700 [thread overview]
Message-ID: <20251027181844.790a2a20@kernel.org> (raw)
In-Reply-To: <20251024152528.275533-1-nihaal@cse.iitm.ac.in>
On Fri, 24 Oct 2025 20:55:22 +0530 Abdun Nihaal wrote:
> err_free_nn:
> + kfree(nn->dp.xsk_pools);
> if (nn->dp.netdev)
> free_netdev(nn->dp.netdev);
Please add dedicated jump label for places which need to free xsk_pools
--
pw-bot: cr
prev parent reply other threads:[~2025-10-28 1:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-24 15:25 [PATCH net] nfp: xsk: fix memory leak in nfp_net_alloc() Abdun Nihaal
2025-10-28 1:18 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251027181844.790a2a20@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=easwar.hariharan@linux.microsoft.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=louis.peens@corigine.com \
--cc=mheib@redhat.com \
--cc=mingo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nihaal@cse.iitm.ac.in \
--cc=niklas.soderlund@corigine.com \
--cc=oss-drivers@corigine.com \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).