From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71F8734D4ED; Tue, 28 Oct 2025 17:30:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761672606; cv=none; b=W72gTCuAflE0AqCPFIDNBvSx5y2UByVwPdLU03uxthcSbUiFhr8z1bkEgSJLlbI+aPgcAtfclUeB9y7L+Q1uGyvD2+p7YkpoT07ZvF2xzf6Utc395V8lGUyknHfBB0F3XZIt4tBlezY5ng1ZKuSTYAEu/9o9X8YlVi72QRFz1SM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761672606; c=relaxed/simple; bh=MyipjujNs1EeYdDhDdXYXgWCyMVvZAP8Yv0PCmnJf2E=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=asPiYIq4E59h1HccxoojaiP7cjm8Pl8TbfBXK+NY+eQh4xVqbRcS41glk0G5JD15a3z/SpD8YCUq7xnFObfg1ALZYYB/cSLjdkC+Xv+I35dYPgVbPKahmFR8EezuIyf8YjITnzUyW29eXe0S6RBE4dEFPNvd6Z0U9FZcGDraCP8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=sEZPV+QX; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="sEZPV+QX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 40665C4CEE7; Tue, 28 Oct 2025 17:30:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1761672604; bh=MyipjujNs1EeYdDhDdXYXgWCyMVvZAP8Yv0PCmnJf2E=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=sEZPV+QXYcBvYdpymZErgqWe9wLkt0QaMns3WrHVFPTO8TQzk53x1hMuuT2PCdlXg xCh00MvKTDvxYFMiWAJ7urINcumdLpA6ji78nDOsa/AYNBpsMQItfwSpTnT10uD58D AGK/DJaMNR1zEF7iG0uv41mx/m74m7LYtUewm5rm6Kg5ksfBJnPPm7cXExNi7IzI4U c6CECLmNDqhtzxppeDPaztgNtXBVpTT6AavCfazQTd1ube8XIuMoyGIqqUD6dlvvTm aEdSKDQTOf9pPq1cimG9TD3wdUeuOZhaRvxhMDgM71Z/sIUMYtdJTRvT2u6SDRRg8q P0m4WSlOG4FDQ== Date: Tue, 28 Oct 2025 10:30:01 -0700 From: Jakub Kicinski To: Paolo Abeni Cc: Daniel Zahka , "David S . Miller" , Eric Dumazet , Simon Horman , Donald Hunter , Andrew Lunn , Shuah Khan , Boris Pismenny , Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Mark Bloch , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH net-next v2 3/5] psp: add stats from psp spec to driver facing api Message-ID: <20251028103001.7cafeb03@kernel.org> In-Reply-To: References: <20251028000018.3869664-1-daniel.zahka@gmail.com> <20251028000018.3869664-4-daniel.zahka@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 28 Oct 2025 10:02:16 +0100 Paolo Abeni wrote: > This makes static checker unhappy: > > /home/cocci/testing/include/net/psp/types.h:167:6-18: WARNING use > flexible-array member instead > (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) > > I think/guess the warning could be avoided using something alike the > following (completely untested!!!): It's not a VLA, it's an end marker for calculating offsets. The patch is fine, we should have added in the commit msg that the false positive from cocci is expected.