From: Jakub Kicinski <kuba@kernel.org>
To: YonglongLi <liyonglong@chinatelecom.cn>
Cc: netdev@vger.kernel.org, edumazet@google.com, horms@kernel.org
Subject: Re: [PATCH net v2 1/2] net: ip: add drop reasons when handling ip fragments
Date: Tue, 28 Oct 2025 17:05:54 -0700 [thread overview]
Message-ID: <20251028170554.3588ee28@kernel.org> (raw)
In-Reply-To: <44342ead-92c9-4467-b5e6-86076684e2ee@chinatelecom.cn>
On Tue, 28 Oct 2025 15:34:48 +0800 YonglongLi wrote:
> Hi Jakub,
>
> Thank you for your response. I'm sorry for the late reply.
> My email system seems to have some issues, and I loss your reply msg.
> I get your response information from web page: https://lore.kernel.org/netdev.
So you resent the patches again? Please learn to use the ML correctly.
Also, again the subject tag should be [PATCH net-next] here not net
> > FRAG_OUTPUT_FAILED means something failed in output so it'd be more
> > meaningful to figure out what failed there, instead of adding
> > a bunch of ${CALLER}_OUTPUT_FAILED
>
> The skb send failed in output() is frag skb, The skb droped outside of output() is the
> origin skb. I think if we want to get detail drop reason we can use kfree_skb_reason
> in output() (maybe anther patch set in future).
> In my opinion, drop reason of the origin skb outside of output() can be not so meaningfull.
Do you have practical examples of output() failing? Are they in any way
related to the skb being fragmented? My intuition is that they would
not be, hence the fragmentation is not very relevant.
If the output() failed because there's something _special_ about
fragmented datagrams -- I'd agree with you. So let's see some
examples..
--
pw-bot: cr
next prev parent reply other threads:[~2025-10-29 0:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 2:32 [PATCH net v2 0/2] add drop reason when do fragment Yonglong Li
2025-10-27 2:32 ` [PATCH net v2 1/2] net: ip: add drop reasons when handling ip fragments Yonglong Li
2025-10-28 7:34 ` YonglongLi
2025-10-29 0:05 ` Jakub Kicinski [this message]
2025-10-27 2:32 ` [PATCH net v2 2/2] net: ipv6: use drop reasons in ip6_fragment Yonglong Li
-- strict thread matches above, loose matches on Subject: below --
2025-10-24 10:20 [PATCH net v2 0/2] add drop reason when do fragment Yonglong Li
2025-10-24 10:20 ` [PATCH net v2 1/2] net: ip: add drop reasons when handling ip fragments Yonglong Li
2025-10-25 0:24 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251028170554.3588ee28@kernel.org \
--to=kuba@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=liyonglong@chinatelecom.cn \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).