* [PATCH net] selftests: netdevsim: Fix ethtool-coalesce.sh fail by installing ethtool-common.sh
@ 2025-10-27 4:30 Wang Liang
2025-10-28 17:14 ` Simon Horman
0 siblings, 1 reply; 5+ messages in thread
From: Wang Liang @ 2025-10-27 4:30 UTC (permalink / raw)
To: kuba, andrew+netdev, davem, edumazet, pabeni, shuah, acardace
Cc: netdev, linux-kselftest, linux-kernel, yuehaibing,
zhangchangzhong, wangliang74
The script "ethtool-common.sh" is not installed in INSTALL_PATH, and
triggers some errors when I try to run the test
'drivers/net/netdevsim/ethtool-coalesce.sh':
TAP version 13
1..1
# timeout set to 600
# selftests: drivers/net/netdevsim: ethtool-coalesce.sh
# ./ethtool-coalesce.sh: line 4: ethtool-common.sh: No such file or directory
# ./ethtool-coalesce.sh: line 25: make_netdev: command not found
# ethtool: bad command line argument(s)
# ./ethtool-coalesce.sh: line 124: check: command not found
# ./ethtool-coalesce.sh: line 126: [: -eq: unary operator expected
# FAILED /0 checks
not ok 1 selftests: drivers/net/netdevsim: ethtool-coalesce.sh # exit=1
Install this file to avoid this error. After this patch:
TAP version 13
1..1
# timeout set to 600
# selftests: drivers/net/netdevsim: ethtool-coalesce.sh
# PASSED all 22 checks
ok 1 selftests: drivers/net/netdevsim: ethtool-coalesce.sh
Fixes: fbb8531e58bd ("selftests: extract common functions in ethtool-common.sh")
Signed-off-by: Wang Liang <wangliang74@huawei.com>
---
tools/testing/selftests/drivers/net/netdevsim/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/testing/selftests/drivers/net/netdevsim/Makefile b/tools/testing/selftests/drivers/net/netdevsim/Makefile
index daf51113c827..653141a654a0 100644
--- a/tools/testing/selftests/drivers/net/netdevsim/Makefile
+++ b/tools/testing/selftests/drivers/net/netdevsim/Makefile
@@ -20,4 +20,6 @@ TEST_PROGS := \
udp_tunnel_nic.sh \
# end of TEST_PROGS
+TEST_FILES := ethtool-common.sh
+
include ../../../lib.mk
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH net] selftests: netdevsim: Fix ethtool-coalesce.sh fail by installing ethtool-common.sh
2025-10-27 4:30 [PATCH net] selftests: netdevsim: Fix ethtool-coalesce.sh fail by installing ethtool-common.sh Wang Liang
@ 2025-10-28 17:14 ` Simon Horman
2025-10-29 0:08 ` Jakub Kicinski
2025-10-29 7:56 ` Wang Liang
0 siblings, 2 replies; 5+ messages in thread
From: Simon Horman @ 2025-10-28 17:14 UTC (permalink / raw)
To: Wang Liang
Cc: kuba, andrew+netdev, davem, edumazet, pabeni, shuah, acardace,
netdev, linux-kselftest, linux-kernel, yuehaibing,
zhangchangzhong
On Mon, Oct 27, 2025 at 12:30:07PM +0800, Wang Liang wrote:
> The script "ethtool-common.sh" is not installed in INSTALL_PATH, and
> triggers some errors when I try to run the test
> 'drivers/net/netdevsim/ethtool-coalesce.sh':
>
> TAP version 13
> 1..1
> # timeout set to 600
> # selftests: drivers/net/netdevsim: ethtool-coalesce.sh
> # ./ethtool-coalesce.sh: line 4: ethtool-common.sh: No such file or directory
> # ./ethtool-coalesce.sh: line 25: make_netdev: command not found
> # ethtool: bad command line argument(s)
> # ./ethtool-coalesce.sh: line 124: check: command not found
> # ./ethtool-coalesce.sh: line 126: [: -eq: unary operator expected
> # FAILED /0 checks
> not ok 1 selftests: drivers/net/netdevsim: ethtool-coalesce.sh # exit=1
>
> Install this file to avoid this error. After this patch:
>
> TAP version 13
> 1..1
> # timeout set to 600
> # selftests: drivers/net/netdevsim: ethtool-coalesce.sh
> # PASSED all 22 checks
> ok 1 selftests: drivers/net/netdevsim: ethtool-coalesce.sh
>
> Fixes: fbb8531e58bd ("selftests: extract common functions in ethtool-common.sh")
> Signed-off-by: Wang Liang <wangliang74@huawei.com>
> ---
> tools/testing/selftests/drivers/net/netdevsim/Makefile | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/testing/selftests/drivers/net/netdevsim/Makefile b/tools/testing/selftests/drivers/net/netdevsim/Makefile
> index daf51113c827..653141a654a0 100644
> --- a/tools/testing/selftests/drivers/net/netdevsim/Makefile
> +++ b/tools/testing/selftests/drivers/net/netdevsim/Makefile
> @@ -20,4 +20,6 @@ TEST_PROGS := \
> udp_tunnel_nic.sh \
> # end of TEST_PROGS
>
> +TEST_FILES := ethtool-common.sh
> +
> include ../../../lib.mk
Hi Wang Liang,
As per commit f07f91a36090 ("selftests: net: unify the Makefile formats")
I think the desired format is as follows (completely untested!):
TEST_FILES := \
ethtool-common.sh \
# end of TEST_PROGS
--
pw-bot: changes-requested
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH net] selftests: netdevsim: Fix ethtool-coalesce.sh fail by installing ethtool-common.sh
2025-10-28 17:14 ` Simon Horman
@ 2025-10-29 0:08 ` Jakub Kicinski
2025-10-29 17:37 ` Simon Horman
2025-10-29 7:56 ` Wang Liang
1 sibling, 1 reply; 5+ messages in thread
From: Jakub Kicinski @ 2025-10-29 0:08 UTC (permalink / raw)
To: Simon Horman
Cc: Wang Liang, andrew+netdev, davem, edumazet, pabeni, shuah,
acardace, netdev, linux-kselftest, linux-kernel, yuehaibing,
zhangchangzhong
On Tue, 28 Oct 2025 17:14:03 +0000 Simon Horman wrote:
> > +TEST_FILES := ethtool-common.sh
> > +
> > include ../../../lib.mk
>
> Hi Wang Liang,
>
> As per commit f07f91a36090 ("selftests: net: unify the Makefile formats")
> I think the desired format is as follows (completely untested!):
>
> TEST_FILES := \
> ethtool-common.sh \
> # end of TEST_PROGS
I believe we (intentionally) allow simple single entry assignment like
in this patch. But there have been bugs in this check which I only fixed
last weekend so please LMK if I'm missing something..
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH net] selftests: netdevsim: Fix ethtool-coalesce.sh fail by installing ethtool-common.sh
2025-10-29 0:08 ` Jakub Kicinski
@ 2025-10-29 17:37 ` Simon Horman
0 siblings, 0 replies; 5+ messages in thread
From: Simon Horman @ 2025-10-29 17:37 UTC (permalink / raw)
To: Jakub Kicinski
Cc: Wang Liang, andrew+netdev, davem, edumazet, pabeni, shuah,
acardace, netdev, linux-kselftest, linux-kernel, yuehaibing,
zhangchangzhong
On Tue, Oct 28, 2025 at 05:08:42PM -0700, Jakub Kicinski wrote:
> On Tue, 28 Oct 2025 17:14:03 +0000 Simon Horman wrote:
> > > +TEST_FILES := ethtool-common.sh
> > > +
> > > include ../../../lib.mk
> >
> > Hi Wang Liang,
> >
> > As per commit f07f91a36090 ("selftests: net: unify the Makefile formats")
> > I think the desired format is as follows (completely untested!):
> >
> > TEST_FILES := \
> > ethtool-common.sh \
> > # end of TEST_PROGS
>
> I believe we (intentionally) allow simple single entry assignment like
> in this patch. But there have been bugs in this check which I only fixed
> last weekend so please LMK if I'm missing something..
Sorry, I was just going by manual inspection. If the patch meets
your expectations as-is, then there are no further objections from me.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net] selftests: netdevsim: Fix ethtool-coalesce.sh fail by installing ethtool-common.sh
2025-10-28 17:14 ` Simon Horman
2025-10-29 0:08 ` Jakub Kicinski
@ 2025-10-29 7:56 ` Wang Liang
1 sibling, 0 replies; 5+ messages in thread
From: Wang Liang @ 2025-10-29 7:56 UTC (permalink / raw)
To: Simon Horman
Cc: kuba, andrew+netdev, davem, edumazet, pabeni, shuah, acardace,
netdev, linux-kselftest, linux-kernel, yuehaibing,
zhangchangzhong
在 2025/10/29 1:14, Simon Horman 写道:
> On Mon, Oct 27, 2025 at 12:30:07PM +0800, Wang Liang wrote:
>> The script "ethtool-common.sh" is not installed in INSTALL_PATH, and
>> triggers some errors when I try to run the test
>> 'drivers/net/netdevsim/ethtool-coalesce.sh':
>>
>> TAP version 13
>> 1..1
>> # timeout set to 600
>> # selftests: drivers/net/netdevsim: ethtool-coalesce.sh
>> # ./ethtool-coalesce.sh: line 4: ethtool-common.sh: No such file or directory
>> # ./ethtool-coalesce.sh: line 25: make_netdev: command not found
>> # ethtool: bad command line argument(s)
>> # ./ethtool-coalesce.sh: line 124: check: command not found
>> # ./ethtool-coalesce.sh: line 126: [: -eq: unary operator expected
>> # FAILED /0 checks
>> not ok 1 selftests: drivers/net/netdevsim: ethtool-coalesce.sh # exit=1
>>
>> Install this file to avoid this error. After this patch:
>>
>> TAP version 13
>> 1..1
>> # timeout set to 600
>> # selftests: drivers/net/netdevsim: ethtool-coalesce.sh
>> # PASSED all 22 checks
>> ok 1 selftests: drivers/net/netdevsim: ethtool-coalesce.sh
>>
>> Fixes: fbb8531e58bd ("selftests: extract common functions in ethtool-common.sh")
>> Signed-off-by: Wang Liang <wangliang74@huawei.com>
>> ---
>> tools/testing/selftests/drivers/net/netdevsim/Makefile | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/tools/testing/selftests/drivers/net/netdevsim/Makefile b/tools/testing/selftests/drivers/net/netdevsim/Makefile
>> index daf51113c827..653141a654a0 100644
>> --- a/tools/testing/selftests/drivers/net/netdevsim/Makefile
>> +++ b/tools/testing/selftests/drivers/net/netdevsim/Makefile
>> @@ -20,4 +20,6 @@ TEST_PROGS := \
>> udp_tunnel_nic.sh \
>> # end of TEST_PROGS
>>
>> +TEST_FILES := ethtool-common.sh
>> +
>> include ../../../lib.mk
> Hi Wang Liang,
>
> As per commit f07f91a36090 ("selftests: net: unify the Makefile formats")
> I think the desired format is as follows (completely untested!):
>
> TEST_FILES := \
> ethtool-common.sh \
> # end of TEST_PROGS
Thanks for the reminder!
I will correct it, and send v2 later.
------
Best regards
Wang Liang
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-10-29 17:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-27 4:30 [PATCH net] selftests: netdevsim: Fix ethtool-coalesce.sh fail by installing ethtool-common.sh Wang Liang
2025-10-28 17:14 ` Simon Horman
2025-10-29 0:08 ` Jakub Kicinski
2025-10-29 17:37 ` Simon Horman
2025-10-29 7:56 ` Wang Liang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).