From: Jakub Kicinski <kuba@kernel.org>
To: Ido Schimmel <idosch@nvidia.com>
Cc: <netdev@vger.kernel.org>, <davem@davemloft.net>,
<pabeni@redhat.com>, <edumazet@google.com>, <horms@kernel.org>,
<dsahern@kernel.org>, <petrm@nvidia.com>, <willemb@google.com>,
<daniel@iogearbox.net>, <fw@strlen.de>, <ishaangandhi@gmail.com>,
<rbonica@juniper.net>, <tom@herbertland.com>,
Justin Iurman <justin.iurman@uliege.be>
Subject: Re: [PATCH net-next v2 0/3] icmp: Add RFC 5837 support
Date: Tue, 28 Oct 2025 18:04:32 -0700 [thread overview]
Message-ID: <20251028180432.7f73ef56@kernel.org> (raw)
In-Reply-To: <20251027082232.232571-1-idosch@nvidia.com>
On Mon, 27 Oct 2025 10:22:29 +0200 Ido Schimmel wrote:
> This patchset extends certain ICMP error messages (e.g., "Time
> Exceeded") with incoming interface information in accordance with RFC
> 5837 [1]. This is required for more meaningful traceroute results in
> unnumbered networks. Like other ICMP settings, the feature is controlled
> via a per-{netns, address family} sysctl. The interface and the
> implementation are designed to support more ICMP extensions.
Is there supposed to be any relation between the ICMP message attrs
and what's provided via IOAM? For interface ID in IOAM we have
the ioam6_id attr instead of ifindex.
Would it make sense to add some info about relation to IOAM to the
commit msg (or even docs?). Or is it obvious to folks more familiar
with IP RFCs than I am?
cc: Justin
next prev parent reply other threads:[~2025-10-29 1:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 8:22 [PATCH net-next v2 0/3] icmp: Add RFC 5837 support Ido Schimmel
2025-10-27 8:22 ` [PATCH net-next v2 1/3] ipv4: " Ido Schimmel
2025-10-27 8:35 ` Eric Dumazet
2025-11-07 17:33 ` David 'equinox' Lamparter
2025-11-08 16:01 ` Ido Schimmel
2025-10-27 8:22 ` [PATCH net-next v2 2/3] ipv6: " Ido Schimmel
2025-10-27 8:39 ` Eric Dumazet
2025-10-27 8:22 ` [PATCH net-next v2 3/3] selftests: traceroute: Add ICMP extensions tests Ido Schimmel
2025-10-29 1:04 ` Jakub Kicinski [this message]
2025-10-29 9:54 ` [PATCH net-next v2 0/3] icmp: Add RFC 5837 support Ido Schimmel
2025-10-30 1:31 ` Jakub Kicinski
2025-11-07 17:20 ` David 'equinox' Lamparter
2025-11-08 15:39 ` Ido Schimmel
2025-10-30 1:38 ` Justin Iurman
2025-10-30 1:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251028180432.7f73ef56@kernel.org \
--to=kuba@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=ishaangandhi@gmail.com \
--cc=justin.iurman@uliege.be \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=rbonica@juniper.net \
--cc=tom@herbertland.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).