From: Jakub Kicinski <kuba@kernel.org>
To: Buday Csaba <buday.csaba@prolan.hu>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Philipp Zabel <p.zabel@pengutronix.de>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v4 4/4] net: mdio: reset PHY before attempting to access registers in fwnode_mdiobus_register_phy
Date: Tue, 28 Oct 2025 18:26:05 -0700 [thread overview]
Message-ID: <20251028182605.06840664@kernel.org> (raw)
In-Reply-To: <bebbaef2c6801f6973ea00500a594ed934e40e47.1761124022.git.buday.csaba@prolan.hu>
On Wed, 22 Oct 2025 11:08:53 +0200 Buday Csaba wrote:
> +/* Hard-reset a PHY before registration */
> +static int fwnode_reset_phy(struct mii_bus *bus, u32 addr,
> + struct fwnode_handle *phy_node)
> +{
> + struct mdio_device *tmpdev;
> + int err;
> +
> + tmpdev = mdio_device_create(bus, addr);
> + if (IS_ERR(tmpdev))
> + return PTR_ERR(tmpdev);
> +
> + fwnode_handle_get(phy_node);
> + device_set_node(&tmpdev->dev, phy_node);
> + err = mdio_device_register_reset(tmpdev);
> + if (err) {
> + mdio_device_free(tmpdev);
> + return err;
Should we worry about -EPROBE_DEFER on any of the error paths here?
If not maybe consider making this function void? We can add errors
back if the caller starts to care.
> + }
> +
> + if (mdio_device_has_reset(tmpdev)) {
> + dev_info(&bus->dev,
> + "PHY device at address %d not detected, resetting PHY.",
> + addr);
IDK if this is still strictly necessary but I guess \n at the end of
the info msg would be idiomatic
next prev parent reply other threads:[~2025-10-29 1:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-22 9:08 [PATCH net-next v4 0/4] net: mdio: implement optional PHY reset before MDIO access Buday Csaba
2025-10-22 9:08 ` [PATCH net-next v4 1/4] net: mdio: common handling of phy reset properties Buday Csaba
2025-10-29 1:22 ` Jakub Kicinski
2025-10-22 9:08 ` [PATCH net-next v4 2/4] net: mdio: change property read from fwnode_property_read_u32() to device_property_read_u32() Buday Csaba
2025-10-22 9:08 ` [PATCH net-next v4 3/4] net: mdio: introduce mdio_device_has_reset() Buday Csaba
2025-10-22 9:08 ` [PATCH net-next v4 4/4] net: mdio: reset PHY before attempting to access registers in fwnode_mdiobus_register_phy Buday Csaba
2025-10-29 1:26 ` Jakub Kicinski [this message]
2025-10-29 7:24 ` Buday Csaba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251028182605.06840664@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=buday.csaba@prolan.hu \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).