From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 659A513B58C; Wed, 29 Oct 2025 02:08:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761703682; cv=none; b=K+5sb5O7UvqDB+gKc8B2odzgGlFABmFS6lb/L4W5tIYf7Br/S02adFZnbZKscTy/GfFy5WSH9vOFa6hikJwgJVQ0vDtDeLuQU8H3GzHaSXhWfQu72+o0roHwTVCMip67btvoo0OXq0Kecq/Jpj93l0kiu2xik8bQlGCZmOLfl1U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761703682; c=relaxed/simple; bh=x7M+GHSAVsoCL8DBq5oS9mhQFrezimpsQJKSbDMb0Gc=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=e1EcpsI2+R2V9VMnMElE+x6PnqKVkBDEHfOFfZXY1AWJ7e8U7+pm/CtDD1th0THnnc4QBsHyFw7CgwLO3NZvCNSAnDbpLsEdfnLVwwusOs+wrf75Jf235eOTQNASGXqlIXe9DBMvH01G6/AkSlYw5oSWoz4xvkTs/NH2FEAJi1g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=u1IVfK03; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="u1IVfK03" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 60D74C4CEE7; Wed, 29 Oct 2025 02:08:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1761703681; bh=x7M+GHSAVsoCL8DBq5oS9mhQFrezimpsQJKSbDMb0Gc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=u1IVfK03hZKQI7NsIO5yORbLzwnlFsm2l7P6fV5SopDDEbyxQztF/FsGChkl1PmOR O18obhqBxxgcmW/fpLgUMEEiZ1nSKnRxADKho0M+Hrr07HhkBQE0I//ZieGQIbyCDg bc9sUqSYK858+pr5heIbd1prRgnz+8+z6/5OcQpGuwmsujZGfUgvkj4zMIR455uHcf krfFAO8pkMUO6LA1jN4xBqLJAdibw6voIbfRJCfrfWLvV4Hy11R4B6o7kXp4nwsdZm iIYELGunUmwsEV09GTyr1048zD93zBD4efqvrGKDwKwpUd3EJOfHfFJ7ypM7NOewRA InGNm5L81k9CA== Date: Tue, 28 Oct 2025 19:08:00 -0700 From: Jakub Kicinski To: Roger Quadros Cc: Siddharth Vadapalli , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Russell King , danishanwar@ti.com, srk@ti.com, linux-omap@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v5 8/9] net: ethernet: ti: am65-cpsw: add network flow classification support Message-ID: <20251028190800.2ee4f80e@kernel.org> In-Reply-To: <20251024-am65-cpsw-rx-class-v5-8-c7c2950a2d25@kernel.org> References: <20251024-am65-cpsw-rx-class-v5-0-c7c2950a2d25@kernel.org> <20251024-am65-cpsw-rx-class-v5-8-c7c2950a2d25@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 24 Oct 2025 23:46:07 +0300 Roger Quadros wrote: > +/* rxnfc_lock must be held */ > +static void am65_cpsw_del_rule(struct am65_cpsw_port *port, > + struct am65_cpsw_rxnfc_rule *rule) > +{ > + int loc; > + > + /* reverse location as higher locations have higher priority > + * but ethtool expects lower locations to have higher priority > + */ > + loc = port->rxnfc_max - rule->location - 1; > + > + cpsw_ale_policer_clr_entry(port->common->ale, loc, > + &rule->cfg); > + list_del(&rule->list); > + port->rxnfc_count--; > + port->policer_in_use_bitmask &= ~BIT(rule->location); __clear_bit() Please use bitmap helpers everywhere, especially for scanning the bitmap to find unused bits > + struct am65_cpsw_common *common = am65_ndev_to_common(ndev); > + struct am65_cpsw_port *port = am65_ndev_to_port(ndev); > + > + switch (rxnfc->cmd) { > + case ETHTOOL_GRXRINGS: please implement ::get_rx_ring_count instead -- pw-bot: cr