From: Jakub Kicinski <kuba@kernel.org>
To: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Cc: Michal Kubecek <mkubecek@suse.cz>,
netdev@vger.kernel.org, Kory Maincent <kory.maincent@bootlin.com>
Subject: Re: [PATCH ethtool-next] netlink: tsconfig: add HW time stamping configuration
Date: Wed, 29 Oct 2025 15:38:12 -0700 [thread overview]
Message-ID: <20251029153812.10bd6397@kernel.org> (raw)
In-Reply-To: <8693b213-2d22-4e47-99bb-5d8ca4f48dd5@linux.dev>
On Wed, 29 Oct 2025 18:53:20 +0000 Vadim Fedorenko wrote:
> >> Well, yes, it's only 1 bit is supposed to be set. Unfortunately, netlink
> >> interface was added this way almost a year ago, we cannot change it
> >> anymore without breaking user-space API.
> >
> > The netlink interface only mirrors what we already had in struct
> > ethtool_ts_info (i.e. the ioctl interface). Therefore my question was
> > not really about this part of kernel API (which is fixed already) but
> > rather about the ethtool command line syntax.
> >
> > In other words, what I really want to ask is: Can we be absolutely sure
> > that it can never possibly happen in the future that we might need to
> > set more than one bit in a set message?
> >
> > If the answer is positive, I'm OK with the patch but perhaps we should
> > document it explicitly in the TSCONFIG_SET description in kernel file
> > Documentation/networking/ethtool-netlink.rst
>
> Well, I cannot say about long-long future, but for the last decade we
> haven't had a need for multiple bits to be set up. I would assume that
> the reality will be around the same.
>
> Jakub/Kory do you have thoughts?
hard to prove a negative, is the question leading to a different
argument format which will let us set multiple bits? Looks like
we could potentially allow specifying tx / rx-filter multiple
times? Or invent new keywords for the extra bits which presumably
would be somehow orthogonal to filtering?
tl;dr I'm unclear on the exact concern..
next prev parent reply other threads:[~2025-10-29 22:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-04 20:27 [PATCH ethtool-next] netlink: tsconfig: add HW time stamping configuration Vadim Fedorenko
2025-10-06 12:45 ` Kory Maincent
2025-10-06 12:55 ` Vadim Fedorenko
2025-10-06 17:55 ` Jakub Kicinski
2025-10-26 16:57 ` Michal Kubecek
2025-10-28 9:40 ` Kory Maincent
2025-10-28 21:48 ` Vadim Fedorenko
2025-10-29 16:26 ` Michal Kubecek
2025-10-29 18:53 ` Vadim Fedorenko
2025-10-29 22:38 ` Jakub Kicinski [this message]
2025-10-30 14:37 ` Kory Maincent
2025-10-30 15:14 ` Jakub Kicinski
2025-10-30 16:43 ` Kory Maincent
2025-10-30 18:23 ` Michal Kubecek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251029153812.10bd6397@kernel.org \
--to=kuba@kernel.org \
--cc=kory.maincent@bootlin.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).