From: Jakub Kicinski <kuba@kernel.org>
To: Matthew W Carlis <mattc@purestorage.com>
Cc: gal@nvidia.com, adailey@purestorage.com, ashishk@purestorage.com,
mbloch@nvidia.com, msaggi@purestorage.com,
netdev@vger.kernel.org, saeedm@nvidia.com, tariqt@nvidia.com
Subject: Re: [PATCH 1/1] net/mlx5: query_mcia_reg fail logging at debug severity
Date: Wed, 29 Oct 2025 16:33:11 -0700 [thread overview]
Message-ID: <20251029163311.3ad31ac8@kernel.org> (raw)
In-Reply-To: <20251029164924.25404-1-mattc@purestorage.com>
On Wed, 29 Oct 2025 10:49:24 -0600 Matthew W Carlis wrote:
> On Wed, 29 Oct 2025, Gal Pressman wrote:
> > Allow me to split the discussion to two questions:
> > 1. Is this an error?
> > 2. Should it be logged?
> >
> > Do we agree that the answer to #1 is yes?
> >
> > For #2, I think it should, but we can probably improve the situation
> > with extack instead of a print.
>
> I think its an 'expected error' if the module is not present. I agree.
>
> For 2 I think if the user runs "ethtool -m" on a port with no module,
> they received an error message stating something along the lines of
> "module not present" and the kernel didn't have any log messages about
> it that would be near to 'the best' solution.
I assume you mean error message specifically from the CLI or whatever
API the user is exercising? If so I agree.
The system logs are for fatal / unexpected conditions. AFAIU returning
-EIO is the _expected_ way to find out that module is not plugged in.
If there's a better API I suppose we can make ethtool call it first
to avoid the error.
next prev parent reply other threads:[~2025-10-29 23:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-28 19:40 [PATCH 0/1] net/mlx5: query_mcia_reg fail logging at debug severity Matthew W Carlis
2025-10-28 19:40 ` [PATCH 1/1] " Matthew W Carlis
2025-10-28 20:28 ` Gal Pressman
2025-10-28 21:48 ` Matthew W Carlis
2025-10-29 7:22 ` Gal Pressman
2025-10-28 22:43 ` Jakub Kicinski
2025-10-29 7:33 ` Gal Pressman
2025-10-29 16:49 ` Matthew W Carlis
2025-10-29 23:33 ` Jakub Kicinski [this message]
2025-10-30 14:48 ` Gal Pressman
2025-10-30 20:09 ` Matthew W Carlis
2025-11-02 13:09 ` Gal Pressman
2025-10-28 20:27 ` [PATCH 0/1] " Gal Pressman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251029163311.3ad31ac8@kernel.org \
--to=kuba@kernel.org \
--cc=adailey@purestorage.com \
--cc=ashishk@purestorage.com \
--cc=gal@nvidia.com \
--cc=mattc@purestorage.com \
--cc=mbloch@nvidia.com \
--cc=msaggi@purestorage.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).