From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 387801F8AC8; Thu, 30 Oct 2025 00:49:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=140.211.166.183 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761785395; cv=none; b=Nkd1Ieze79ihCIRwojbTVzfloTF/k9t9EXKFx4OZrXQsIT5WcRLjSEyrLA5KVerdJaNCJJnNFlaI/n/Yn4ShM9ZyL1alzoGHH2royKq/5/436pouWP3WIENO1irlwroohrjpOYly/kLflxEYipUQ71Z8VplDhH650ni72H4bC6s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761785395; c=relaxed/simple; bh=bA1YUbRZSVH/lXcqqI/HHC8sRAMJf8nN90puIGjmHak=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QWigBaXYau1OWH4SdqXj0kSwJV3CUKeX0mEyzwC8vc1BwjNT3tIrgHekHr1WMCoz2yx+0uyMHepdqcYu/e7wbcC0gcfAxeubxJqH+Xpc5tioVBGjJQgMf7XdH5RDigSaaMxOEWxpBYYmooPCKM1ylEF2xny75d48qlRLsbo6bVI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gentoo.org; spf=pass smtp.mailfrom=gentoo.org; arc=none smtp.client-ip=140.211.166.183 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gentoo.org Received: from localhost (unknown [116.232.147.23]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange secp256r1 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dlan) by smtp.gentoo.org (Postfix) with ESMTPSA id 802E5340F15; Thu, 30 Oct 2025 00:49:52 +0000 (UTC) Date: Thu, 30 Oct 2025 08:49:48 +0800 From: Yixun Lan To: Inochi Amaoto Cc: Han Gao , Icenowy Zheng , Vivian Wang , Yao Zi , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen Wang , Maxime Coquelin , Alexandre Torgue , Heiner Kallweit , Russell King , "Russell King (Oracle)" , netdev@vger.kernel.org, devicetree@vger.kernel.org, sophgo@lists.linux.dev, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Longbin Li Subject: Re: [PATCH v4 3/3] net: stmmac: dwmac-sophgo: Add phy interface filter Message-ID: <20251030004948-GYB1549833@gentoo.org> References: <20251028003858.267040-1-inochiama@gmail.com> <20251028003858.267040-4-inochiama@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251028003858.267040-4-inochiama@gmail.com> Hi Inochi, On 08:38 Tue 28 Oct , Inochi Amaoto wrote: > As the SG2042 has an internal rx delay, the delay should be removed > when initializing the mac, otherwise the phy will be misconfigurated. > > Fixes: 543009e2d4cd ("net: stmmac: dwmac-sophgo: Add support for Sophgo SG2042 SoC") > Signed-off-by: Inochi Amaoto > Tested-by: Han Gao > --- ... > +static struct sophgo_dwmac_data sg2042_dwmac_data = { > + .has_internal_rx_delay = true, > +}; > + you forget to address in this version? see https://lore.kernel.org/all/ljyivijlhvrendlslvpo4b7rycclt5pheipegx3fwz3fksn4cn@fgpzyhr2j4gi/ -- Yixun Lan (dlan)