From: Jakub Kicinski <kuba@kernel.org>
To: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Cc: <bpf@vger.kernel.org>, <ast@kernel.org>, <daniel@iogearbox.net>,
<hawk@kernel.org>, <netdev@vger.kernel.org>,
<magnus.karlsson@intel.com>, <aleksander.lobakin@intel.com>,
<ilias.apalodimas@linaro.org>, <toke@redhat.com>,
<lorenzo@kernel.org>,
<syzbot+ff145014d6b0ce64a173@syzkaller.appspotmail.com>,
Ihor Solodrai <ihor.solodrai@linux.dev>,
Octavian Purdila <tavip@google.com>
Subject: Re: [PATCH v5 bpf 1/2] xdp: introduce xdp_convert_skb_to_buff()
Date: Thu, 30 Oct 2025 08:25:19 -0700 [thread overview]
Message-ID: <20251030082519.5db297f3@kernel.org> (raw)
In-Reply-To: <aQNWlB5UL+rK8ZE5@boxer>
On Thu, 30 Oct 2025 13:14:16 +0100 Maciej Fijalkowski wrote:
> On Wed, Oct 29, 2025 at 04:50:20PM -0700, Jakub Kicinski wrote:
> > On Wed, 29 Oct 2025 23:13:14 +0100 Maciej Fijalkowski wrote:
> > > + xdp->rxq->mem.type = skb->pp_recycle ? MEM_TYPE_PAGE_POOL :
> > > + MEM_TYPE_PAGE_SHARED;
> >
> > You really need to stop sending patches before I had a chance
> > to reply :/ And this is wrong.
>
> Why do you say so?
>
> netif_receive_generic_xdp()
> netif_skb_check_for_xdp()
> skb_cow_data_for_xdp() failed
> go through skb linearize path
> returned skb data is backed by kmalloc, not page_pool,
> means mem type for this particular xdp_buff has to be
> MEM_TYPE_PAGE_SHARED
>
> Are we on the same page now?
No, I think I already covered this, maybe you disagreed and I missed it.
The mem_type set here is expected to be used only for freeing pages.
XDP can only free fagments (when pkt is trimmed), it cannot free the
head from under the skb. So only fragments matter here, we can ignore
the head.
next prev parent reply other threads:[~2025-10-30 15:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 22:13 [PATCH v5 bpf 0/2] xdp: fix page_pool leaks Maciej Fijalkowski
2025-10-29 22:13 ` [PATCH v5 bpf 1/2] xdp: introduce xdp_convert_skb_to_buff() Maciej Fijalkowski
2025-10-29 23:50 ` Jakub Kicinski
2025-10-30 12:14 ` Maciej Fijalkowski
2025-10-30 15:25 ` Jakub Kicinski [this message]
2025-10-30 20:22 ` Maciej Fijalkowski
2025-10-31 2:05 ` Jakub Kicinski
2025-10-31 11:37 ` Maciej Fijalkowski
2025-10-31 18:49 ` Jakub Kicinski
2025-11-03 12:16 ` Maciej Fijalkowski
2025-11-05 18:39 ` Jesper Dangaard Brouer
2025-10-29 22:13 ` [PATCH v5 bpf 2/2] veth: update mem type in xdp_buff Maciej Fijalkowski
2025-10-29 22:59 ` bot+bpf-ci
2025-10-31 12:46 ` Maciej Fijalkowski
2025-10-31 13:45 ` Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251030082519.5db297f3@kernel.org \
--to=kuba@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=hawk@kernel.org \
--cc=ihor.solodrai@linux.dev \
--cc=ilias.apalodimas@linaro.org \
--cc=lorenzo@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=syzbot+ff145014d6b0ce64a173@syzkaller.appspotmail.com \
--cc=tavip@google.com \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).