From: Jakub Kicinski <kuba@kernel.org>
To: Alexander Lobakin <aleksander.lobakin@intel.com>
Cc: Paolo Abeni <pabeni@redhat.com>,
Jason Xing <kerneljasonxing@gmail.com>, <davem@davemloft.net>,
<edumazet@google.com>, <bjorn@kernel.org>,
<magnus.karlsson@intel.com>, <maciej.fijalkowski@intel.com>,
<jonathan.lemon@gmail.com>, <sdf@fomichev.me>, <ast@kernel.org>,
<daniel@iogearbox.net>, <hawk@kernel.org>,
<john.fastabend@gmail.com>, <joe@dama.to>,
<willemdebruijn.kernel@gmail.com>, <bpf@vger.kernel.org>,
<netdev@vger.kernel.org>, Jason Xing <kernelxing@tencent.com>
Subject: Re: [PATCH net-next v2] xsk: add indirect call for xsk_destruct_skb
Date: Thu, 30 Oct 2025 08:55:35 -0700 [thread overview]
Message-ID: <20251030085535.4f658dd8@kernel.org> (raw)
In-Reply-To: <e290a675-fc1e-4edf-833c-aa82af073d30@intel.com>
On Thu, 30 Oct 2025 11:59:58 +0100 Alexander Lobakin wrote:
> >> managed to see a huge improvement[1], the same situation can also be
> >> applied in xsk scenario.
> >>
> >> This patch adds an indirect call for xsk and helps current copy mode
> >> improve the performance by around 1% stably which was observed with
> >> IXGBE at 10Gb/sec loaded.
> >
> > If I follow the conversation correctly, Jakub's concern is mostly about
> > this change affecting only the copy mode.
> >
> > Out of sheer ignorance on my side is not clear how frequent that
> > scenario is. AFAICS, applications could always do zero-copy with proper
> > setup, am I correct?!?
>
> It is correct only when the target driver implements zero-copy
> driver-side XSk. While it's true for modern Ethernet drivers for real
> NICs, "virtual" drivers like virtio-net, veth etc. usually don't have it.
> It's not as common usecase as using XSk on real NICs, but still valid
> and widely used.
To be clear my main concern is that the XDP<>skb conversions are
an endless source of bugs and complexity. We have one fix for XDP->skb
on the list from Maciej and another for AF_XDP from Fernando which
tried to create an XDP skb_ext. We are digging a deeper and deeper
hole with all this fallback stuff, and it will affect performance
of both normal skb and XDP paths. Optimizing AF_XDP fallback is
shortsighted.
next prev parent reply other threads:[~2025-10-30 15:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-26 14:58 [PATCH net-next v2] xsk: add indirect call for xsk_destruct_skb Jason Xing
2025-10-27 15:21 ` Alexander Lobakin
2025-10-29 0:30 ` Jakub Kicinski
2025-10-29 1:15 ` Jason Xing
2025-10-30 10:15 ` Paolo Abeni
2025-10-30 10:28 ` Jason Xing
2025-10-30 10:59 ` Alexander Lobakin
2025-10-30 11:17 ` Jason Xing
2025-10-30 15:55 ` Jakub Kicinski [this message]
2025-10-30 16:43 ` Jason Xing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251030085535.4f658dd8@kernel.org \
--to=kuba@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=ast@kernel.org \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=joe@dama.to \
--cc=john.fastabend@gmail.com \
--cc=jonathan.lemon@gmail.com \
--cc=kerneljasonxing@gmail.com \
--cc=kernelxing@tencent.com \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).