Re: [PATCH] dt-bindings: ethernet: eswin: fix yaml schema issues

[Krzysztof Kozlowski <krzk@kernel.org>]

On Thu, Oct 30, 2025 at 04:50:01PM +0800, weishangjuan@eswincomputing.com wrote:
> From: Shangjuan Wei <weishangjuan@eswincomputing.com>
> 
> Due to the detection of errors in the eswin mmc module
> regarding the eswin,hsp-sp-csr attributes in the
> eswin,eic7700-eth.yaml file, the link is as follows:
> https://lore.kernel.org/all/176096011380.22917.1988679321096076522.robh@kernel.org/

Drop, reported already says that.

Just say that this is one phandle with multiple arguments, so the syntax
should be in the form of:

> Therefore, the eswin,hsp-sp-csr attributes of the eic7700-eth.yaml file
> regarding eswin and hsp-sp-csr will be changed to the form of:

> items:
>   - items:
>       - description: ...
>       - description: ...
>       - description: ...
>       - description: ...
> 
> The MMC,Ethernet,and USB modules of eswin vendor have defined
> eswin,hsp-sp-csr attribute in YAML. In order to be consistent
> with the property description of MMC,USB, I have modified the
> description content of eswin,hsp-sp-csr attribute in Ethernet YAML.

That's redundant paragraph. Write concise messages describing the
problem, not some background or unrelated bindings. See also submitting
patches about preferred English form.

> 
> Fixes: 888bd0eca93c("dt-bindings: ethernet: eswin: Document for EIC7700 SoC")

Missing space, missing checkpatch.

Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.

With first paragraph and fixes tag corrected:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof