From: Ranganath V N <vnranganath.20@gmail.com>
To: Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
skhan@linuxfoundation.org, david.hunter.linux@gmail.com,
khalid@kernel.org, Ranganath V N <vnranganath.20@gmail.com>
Subject: [PATCH v2 2/2] net: sched: act_connmark: zero initialize the struct to avoid KMSAN
Date: Sat, 01 Nov 2025 18:04:48 +0530 [thread overview]
Message-ID: <20251101-infoleak-v2-2-01a501d41c09@gmail.com> (raw)
In-Reply-To: <20251101-infoleak-v2-0-01a501d41c09@gmail.com>
zero initialize the struct to avoid the infoleak to the userspace.
Signed-off-by: Ranganath V N <vnranganath.20@gmail.com>
---
net/sched/act_connmark.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/net/sched/act_connmark.c b/net/sched/act_connmark.c
index 3e89927d7116..cf3cdfaaa34b 100644
--- a/net/sched/act_connmark.c
+++ b/net/sched/act_connmark.c
@@ -195,13 +195,15 @@ static inline int tcf_connmark_dump(struct sk_buff *skb, struct tc_action *a,
const struct tcf_connmark_info *ci = to_connmark(a);
unsigned char *b = skb_tail_pointer(skb);
const struct tcf_connmark_parms *parms;
- struct tc_connmark opt = {
- .index = ci->tcf_index,
- .refcnt = refcount_read(&ci->tcf_refcnt) - ref,
- .bindcnt = atomic_read(&ci->tcf_bindcnt) - bind,
- };
+ struct tc_connmark opt;
struct tcf_t t;
+ memset(&opt, 0, sizeof(opt));
+
+ opt.index = ci->tcf_index,
+ opt.refcnt = refcount_read(&ci->tcf_refcnt) - ref,
+ opt.bindcnt = atomic_read(&ci->tcf_bindcnt) - bind,
+
rcu_read_lock();
parms = rcu_dereference(ci->parms);
--
2.43.0
next prev parent reply other threads:[~2025-11-01 12:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-01 12:34 [PATCH v2 0/2] net: sched: act_ife: initialize struct tc_ife to fix KMSAN kernel-infoleak Ranganath V N
2025-11-01 12:34 ` [PATCH v2 1/2] " Ranganath V N
2025-11-04 14:10 ` Simon Horman
2025-11-01 12:34 ` Ranganath V N [this message]
2025-11-04 14:08 ` [PATCH v2 0/2] " Simon Horman
2025-11-05 10:03 ` Ranganath V N
2025-11-05 12:59 ` Simon Horman
2025-11-05 15:09 ` Jamal Hadi Salim
2025-11-05 19:13 ` Simon Horman
2025-11-06 13:31 ` Ranganath V N
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251101-infoleak-v2-2-01a501d41c09@gmail.com \
--to=vnranganath.20@gmail.com \
--cc=davem@davemloft.net \
--cc=david.hunter.linux@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=khalid@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=skhan@linuxfoundation.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).