* [PATCH] sfc: Fix double word in comments
@ 2025-10-29 7:21 Bo Liu
2025-11-04 0:24 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Bo Liu @ 2025-10-29 7:21 UTC (permalink / raw)
To: ecree.xilinx, andrew+netdev, davem, edumazet, kuba, pabeni
Cc: netdev, linux-net-drivers, linux-kernel, Bo Liu
Remove the repeated word "the" in comments.
Signed-off-by: Bo Liu <liubo03@inspur.com>
---
drivers/net/ethernet/sfc/mcdi_pcol.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/sfc/mcdi_pcol.h b/drivers/net/ethernet/sfc/mcdi_pcol.h
index b9866e389e6d..e0415d08d862 100644
--- a/drivers/net/ethernet/sfc/mcdi_pcol.h
+++ b/drivers/net/ethernet/sfc/mcdi_pcol.h
@@ -9560,7 +9560,7 @@
* DMA synchronizaion. Always the last entry in the DMA buffer and set to the
* same value as GENERATION_START. The host driver must compare the
* GENERATION_START and GENERATION_END values to verify that the DMA buffer is
- * consistent upon copying the the DMA buffer. If they do not match, it means
+ * consistent upon copying the DMA buffer. If they do not match, it means
* that new DMA transfer has started while the host driver was copying the DMA
* buffer. In this case, the host driver must repeat the copy operation.
*/
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] sfc: Fix double word in comments
2025-10-29 7:21 [PATCH] sfc: Fix double word in comments Bo Liu
@ 2025-11-04 0:24 ` Jakub Kicinski
2025-11-04 17:40 ` Edward Cree
0 siblings, 1 reply; 3+ messages in thread
From: Jakub Kicinski @ 2025-11-04 0:24 UTC (permalink / raw)
To: Bo Liu
Cc: ecree.xilinx, andrew+netdev, davem, edumazet, pabeni, netdev,
linux-net-drivers, linux-kernel
On Wed, 29 Oct 2025 15:21:31 +0800 Bo Liu wrote:
> Remove the repeated word "the" in comments.
>
> Signed-off-by: Bo Liu <liubo03@inspur.com>
If you're doing typo-style fixes please fix all of the problems in
the file.
--
pw-bot: cr
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sfc: Fix double word in comments
2025-11-04 0:24 ` Jakub Kicinski
@ 2025-11-04 17:40 ` Edward Cree
0 siblings, 0 replies; 3+ messages in thread
From: Edward Cree @ 2025-11-04 17:40 UTC (permalink / raw)
To: Jakub Kicinski, Bo Liu
Cc: andrew+netdev, davem, edumazet, pabeni, netdev, linux-net-drivers,
linux-kernel
On 04/11/2025 00:24, Jakub Kicinski wrote:
> On Wed, 29 Oct 2025 15:21:31 +0800 Bo Liu wrote:
>> Remove the repeated word "the" in comments.
>>
>> Signed-off-by: Bo Liu <liubo03@inspur.com>
>
> If you're doing typo-style fixes please fix all of the problems in
> the file.
FWIW this file is automatically generated from definitions managed
by the sfc firmware team, so typo fixes need to go to that upstream
source or they will just be overwritten next time the file is
regenerated. (We have tweaked the script to add a comment at the
top of the file explaining this, but we haven't pushed out a header
regeneration patch since then so it's not there yet.)
If Liu does produce a comprehensive typo-fix patch, I will do the
work to upstream the changes. But it doesn't seem worth it for a
single fix like this.
-ed
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-11-04 17:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-29 7:21 [PATCH] sfc: Fix double word in comments Bo Liu
2025-11-04 0:24 ` Jakub Kicinski
2025-11-04 17:40 ` Edward Cree
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).