From: Jakub Kicinski <kuba@kernel.org>
To: Jiaming Zhang <r772577952@gmail.com>
Cc: kory.maincent@bootlin.com, davem@davemloft.net,
edumazet@google.com, horms@kernel.org, kuniyu@google.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
pabeni@redhat.com, sdf@fomichev.me, syzkaller@googlegroups.com,
vladimir.oltean@nxp.com
Subject: Re: [PATCH v3 1/1] net: core: prevent NULL deref in generic_hwtstamp_ioctl_lower()
Date: Mon, 3 Nov 2025 17:15:57 -0800 [thread overview]
Message-ID: <20251103171557.3c5123cc@kernel.org> (raw)
In-Reply-To: <20251030124947.34575-2-r772577952@gmail.com>
On Thu, 30 Oct 2025 12:49:47 +0000 Jiaming Zhang wrote:
> + /* Netlink path with unconverted lower driver */
> + if (!kernel_cfg->ifr)
> + return -EOPNOTSUPP;
> +
> /* Legacy path: unconverted lower driver */
> return generic_hwtstamp_ioctl_lower(dev, SIOCGHWTSTAMP, kernel_cfg);
> }
> @@ -498,6 +502,10 @@ int generic_hwtstamp_set_lower(struct net_device *dev,
> return err;
> }
>
> + /* Netlink path with unconverted lower driver */
> + if (!kernel_cfg->ifr)
> + return -EOPNOTSUPP;
> +
> /* Legacy path: unconverted lower driver */
> return generic_hwtstamp_ioctl_lower(dev, SIOCSHWTSTAMP, kernel_cfg);
Sorry but nit:
instead of adding this to both callers you can add the check in
generic_hwtstamp_ioctl_lower().
--
pw-bot: cr
next prev parent reply other threads:[~2025-11-04 1:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 8:45 [Linux Kernel Bug] KASAN: null-ptr-deref Read in generic_hwtstamp_ioctl_lower Jiaming Zhang
2025-10-29 10:06 ` Kory Maincent
2025-10-29 12:22 ` Jiaming Zhang
2025-10-29 16:19 ` Vladimir Oltean
2025-10-29 16:47 ` Kory Maincent
2025-10-29 19:28 ` Vadim Fedorenko
2025-10-30 9:36 ` [PATCH] net: core: prevent NULL deref in generic_hwtstamp_ioctl_lower() Jiaming Zhang
2025-10-30 10:14 ` Kory Maincent
2025-10-30 10:49 ` [PATCH v2] " Jiaming Zhang
2025-10-30 12:49 ` [PATCH v3 0/1] " Jiaming Zhang
2025-10-30 12:49 ` [PATCH v3 1/1] " Jiaming Zhang
2025-11-04 1:15 ` Jakub Kicinski [this message]
2025-11-11 17:36 ` [PATCH v4 0/1] " Jiaming Zhang
2025-11-11 17:36 ` [PATCH v4 1/1] " Jiaming Zhang
2025-11-12 8:45 ` Kory Maincent
2025-11-14 1:40 ` [PATCH v4 0/1] " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251103171557.3c5123cc@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kory.maincent@bootlin.com \
--cc=kuniyu@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=r772577952@gmail.com \
--cc=sdf@fomichev.me \
--cc=syzkaller@googlegroups.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).