From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E79D6A33B; Wed, 5 Nov 2025 02:20:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762309237; cv=none; b=E2NUhTJq82LKmEJa7BsHts2LVlqKTbkfXot7uVD8VixtNELX1bmgPmV6fPrd5eUZ7W5sk37iDCRy7103i9FByt5/5twLT9pNNIxyU0UXhA2VB0snJJIcZeFTiFFYwCI7/7JbLSZdl2rnE7/sHs/IIXiH2tctL7+yvrvFe5br+7k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762309237; c=relaxed/simple; bh=siu99kukBiiervgH6j7Qp18m5/cq8S+7+ud47iygqU8=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=gesHafLydYpXpbMX4Tr+t5UgGywEa948i8J6jg16lviySWtqGh9e2LbdV6eqd1W/P8iCyrMrsTYCzo3ABHjzotrdeBnasaL0S5FRK/7bPycHsHPdcSJvUZ+ElyEzjwcSG2ocK6xEUe1qRcSxxzNRYIqwEwEtz/CtMicCAX2uuM0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=axORwLR/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="axORwLR/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 103CDC4CEF7; Wed, 5 Nov 2025 02:20:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1762309236; bh=siu99kukBiiervgH6j7Qp18m5/cq8S+7+ud47iygqU8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=axORwLR/ybOg6tEvjNILFMj8JaFmkVxdMqarGN4x8bHNWc+pApG6JWZ0GE3SMDN3q s+oSvzV9mUXKrVjxmSzyu+4DyAiFF1mt5qhQ4Gv5MtxLe3cMtA6+NoQ1OTV7O7G5iS oSEq+ozqc1JRAei+X6UYaGD4rgs3AjxNyPHbeX1JeaoZe7mapwk8bS0r4316B5pDPj wzPANsrAFmKb+7BKP6NlqGEreMXHB9fpE+TL/Ij4RBOYzZOP568TE/TOYqXFK5u8Li QvErucOaGSzvoQKU+clJbONyFn/TlCEYiU710qj0FgHvfZTYXbS9R3WjUvNP8VjK3f f397froJTDmkQ== Date: Tue, 4 Nov 2025 18:20:35 -0800 From: Jakub Kicinski To: Maxime Chevallier Cc: Andrew Lunn , davem@davemloft.net, Eric Dumazet , Paolo Abeni , Russell King , Simon Horman , Boon Khai Ng , Alexis =?UTF-8?B?TG90aG9yw6k=?= , Thomas Petazzoni , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Andrew Lunn Subject: Re: [PATCH net-next v2 1/4] net: altera-tse: Set platform drvdata before registering netdev Message-ID: <20251104182035.29082775@kernel.org> In-Reply-To: <20251103104928.58461-2-maxime.chevallier@bootlin.com> References: <20251103104928.58461-1-maxime.chevallier@bootlin.com> <20251103104928.58461-2-maxime.chevallier@bootlin.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Mon, 3 Nov 2025 11:49:24 +0100 Maxime Chevallier wrote: > We don't have to wait until netdev is registered before setting it as the > pdev's drvdata. Move it at netdev alloc time. FWIW sometimes the late setting of drvdata is done to make sure drvdata is NULL if we error out but forget to set ret (so probe returns 0 even tho it failed). But the error paths looks fine here so =F0=9F=A4=B7=EF=B8=8F