netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Bayer <gbayer@linux.ibm.com>
To: Saeed Mahameed <saeedm@nvidia.com>,
	Leon Romanovsky <leon@kernel.org>,
	Tariq Toukan <tariqt@nvidia.com>, Mark Bloch <mbloch@nvidia.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Jason Gunthorpe <jgg@ziepe.ca>,
	Bjorn Helgaas <bhelgaas@google.com>
Cc: Jay Cornwall <Jay.Cornwall@amd.com>,
	Felix Kuehling <Felix.Kuehling@amd.com>,
	Niklas Schnelle <schnelle@linux.ibm.com>,
	Alexander Schmidt <alexs@linux.ibm.com>,
	netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
	linux-kernel@vger.kernel.org, Gerd Bayer <gbayer@linux.ibm.com>
Subject: [PATCH RFC 0/2] mlx5/pci: Fix enablement of PCIe AtomicOp Requests
Date: Wed, 05 Nov 2025 18:55:12 +0100	[thread overview]
Message-ID: <20251105-mlxatomics-v1-0-10c71649e08d@linux.ibm.com> (raw)

As I promised in
https://lore.kernel.org/linux-pci/9c7c4217171fb56c505dc90b8c73b2ce079207a9.camel@linux.ibm.com/#t
here's an RFC patch proposing to correct the usage of
pci_enable_atomic_ops_to_root() in the Ethernet and InfiniBand drivers
for Mellanox/NVidia devices.

With this fix, AtomicOp Requests would only be enabled if a root-port
correctly announced its capability to support all AtomicOps including
the optional 128bit CAS - as the drivers intend to.

That said, on the only x86 system that I can test this on, it appears
that UEFI is already enabling AtomicOp Requests for the ConnectX-6 Dx
card in that system.

Overall, both the enablement of PCIe AtomicOps by core PCI code, and
their usage by (very few) device drivers, appear to be in need of some
attention?

Thanks,
Gerd

Signed-off-by: Gerd Bayer <gbayer@linux.ibm.com>
---
Gerd Bayer (2):
      net/mlx5: Request PCIe AtomicOps enabled for all 3 sizes
      ib/mlx5: Request PCIe AtomicOps enabled for all 3 sizes

 drivers/infiniband/hw/mlx5/data_direct.c       | 6 +++---
 drivers/net/ethernet/mellanox/mlx5/core/main.c | 6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)
---
base-commit: 6146a0f1dfae5d37442a9ddcba012add260bceb0
change-id: 20251024-mlxatomics-5729e8af60b9

Best regards,
-- 
Gerd Bayer <gbayer@linux.ibm.com>


             reply	other threads:[~2025-11-05 17:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-05 17:55 Gerd Bayer [this message]
2025-11-05 17:55 ` [PATCH RFC 1/2] net/mlx5: Request PCIe AtomicOps enabled for all 3 sizes Gerd Bayer
2025-11-05 17:55 ` [PATCH RFC 2/2] ib/mlx5: " Gerd Bayer
2025-11-06 10:19   ` Leon Romanovsky
2025-11-06 12:16     ` Gerd Bayer
2025-11-06 13:14       ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251105-mlxatomics-v1-0-10c71649e08d@linux.ibm.com \
    --to=gbayer@linux.ibm.com \
    --cc=Felix.Kuehling@amd.com \
    --cc=Jay.Cornwall@amd.com \
    --cc=alexs@linux.ibm.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=bhelgaas@google.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=jgg@ziepe.ca \
    --cc=kuba@kernel.org \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=mbloch@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=saeedm@nvidia.com \
    --cc=schnelle@linux.ibm.com \
    --cc=tariqt@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).