From: Christian Brauner <brauner@kernel.org>
To: Jeff Layton <jlayton@kernel.org>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Jan Kara <jack@suse.cz>, Chuck Lever <chuck.lever@oracle.com>,
Alexander Aring <alex.aring@gmail.com>,
Trond Myklebust <trondmy@kernel.org>,
Anna Schumaker <anna@kernel.org>,
Steve French <sfrench@samba.org>,
Paulo Alcantara <pc@manguebit.org>,
Ronnie Sahlberg <ronniesahlberg@gmail.com>,
Shyam Prasad N <sprasad@microsoft.com>,
Tom Talpey <tom@talpey.com>,
Bharath SM <bharathsm@microsoft.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>,
David Howells <dhowells@redhat.com>,
Tyler Hicks <code@tyhicks.com>, NeilBrown <neil@brown.name>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <Dai.Ngo@oracle.com>,
Amir Goldstein <amir73il@gmail.com>,
Namjae Jeon <linkinjeon@kernel.org>,
Steve French <smfrench@gmail.com>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Carlos Maiolino <cem@kernel.org>,
Kuniyuki Iwashima <kuniyu@google.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org,
samba-technical@lists.samba.org, netfs@lists.linux.dev,
ecryptfs@vger.kernel.org, linux-unionfs@vger.kernel.org,
linux-xfs@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v4 03/17] filelock: add struct delegated_inode
Date: Wed, 5 Nov 2025 13:19:43 +0100 [thread overview]
Message-ID: <20251105-vorwurf-rotwein-c3b6c398b50d@brauner> (raw)
In-Reply-To: <20251103-dir-deleg-ro-v4-3-961b67adee89@kernel.org>
On Mon, Nov 03, 2025 at 07:52:31AM -0500, Jeff Layton wrote:
> The current API requires a pointer to an inode pointer. It's easy for
> callers to get this wrong. Add a new delegated_inode structure and use
> that to pass back any inode that needs to be waited on.
>
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> ---
Yeah, I like this. I think this is a pretty obvious win.
next prev parent reply other threads:[~2025-11-05 12:19 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-03 12:52 [PATCH v4 00/17] vfs: recall-only directory delegations for knfsd Jeff Layton
2025-11-03 12:52 ` [PATCH v4 01/17] filelock: make lease_alloc() take a flags argument Jeff Layton
2025-11-03 12:52 ` [PATCH v4 02/17] filelock: rework the __break_lease API to use flags Jeff Layton
2025-11-03 12:52 ` [PATCH v4 03/17] filelock: add struct delegated_inode Jeff Layton
2025-11-05 12:19 ` Christian Brauner [this message]
2025-11-03 12:52 ` [PATCH v4 04/17] filelock: push the S_ISREG check down to ->setlease handlers Jeff Layton
2025-11-03 12:52 ` [PATCH v4 05/17] vfs: add try_break_deleg calls for parents to vfs_{link,rename,unlink} Jeff Layton
2025-11-03 12:52 ` [PATCH v4 06/17] vfs: allow mkdir to wait for delegation break on parent Jeff Layton
2025-11-03 12:52 ` [PATCH v4 07/17] vfs: allow rmdir " Jeff Layton
2025-11-03 12:52 ` [PATCH v4 08/17] vfs: break parent dir delegations in open(..., O_CREAT) codepath Jeff Layton
2025-11-03 12:52 ` [PATCH v4 09/17] vfs: add struct createdata for passing arguments to vfs_create() Jeff Layton
2025-11-04 0:06 ` NeilBrown
2025-11-04 0:34 ` NeilBrown
2025-11-03 12:52 ` [PATCH v4 10/17] vfs: make vfs_create break delegations on parent directory Jeff Layton
2025-11-04 0:14 ` NeilBrown
2025-11-04 0:30 ` Jeff Layton
2025-11-05 12:15 ` Christian Brauner
2025-11-04 17:38 ` Simon Horman
2025-11-04 18:10 ` Jeff Layton
2025-11-03 12:52 ` [PATCH v4 11/17] vfs: make vfs_mknod " Jeff Layton
2025-11-03 12:52 ` [PATCH v4 12/17] vfs: make vfs_symlink break delegations on parent dir Jeff Layton
2025-11-03 12:52 ` [PATCH v4 13/17] filelock: lift the ban on directory leases in generic_setlease Jeff Layton
2025-11-03 12:52 ` [PATCH v4 14/17] nfsd: allow filecache to hold S_IFDIR files Jeff Layton
2025-11-03 12:52 ` [PATCH v4 15/17] nfsd: allow DELEGRETURN on directories Jeff Layton
2025-11-03 12:52 ` [PATCH v4 16/17] nfsd: wire up GET_DIR_DELEGATION handling Jeff Layton
2025-11-03 12:52 ` [PATCH v4 17/17] vfs: expose delegation support to userland Jeff Layton
2025-11-03 13:13 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251105-vorwurf-rotwein-c3b6c398b50d@brauner \
--to=brauner@kernel.org \
--cc=Dai.Ngo@oracle.com \
--cc=alex.aring@gmail.com \
--cc=amir73il@gmail.com \
--cc=anna@kernel.org \
--cc=bharathsm@microsoft.com \
--cc=cem@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=code@tyhicks.com \
--cc=dakr@kernel.org \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=ecryptfs@vger.kernel.org \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=horms@kernel.org \
--cc=jack@suse.cz \
--cc=jlayton@kernel.org \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=neil@brown.name \
--cc=netdev@vger.kernel.org \
--cc=netfs@lists.linux.dev \
--cc=okorniev@redhat.com \
--cc=pabeni@redhat.com \
--cc=pc@manguebit.org \
--cc=rafael@kernel.org \
--cc=ronniesahlberg@gmail.com \
--cc=samba-technical@lists.samba.org \
--cc=senozhatsky@chromium.org \
--cc=sfrench@samba.org \
--cc=smfrench@gmail.com \
--cc=sprasad@microsoft.com \
--cc=tom@talpey.com \
--cc=trondmy@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox