netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: joshwash@google.com
Cc: netdev@vger.kernel.org,
	Harshitha Ramamurthy <hramamurthy@google.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>,
	Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Jesper Dangaard Brouer <hawk@kernel.org>,
	John Fastabend <john.fastabend@gmail.com>,
	Stanislav Fomichev <sdf@fomichev.me>,
	Willem de Bruijn <willemb@google.com>,
	Praveen Kaligineedi <pkaligineedi@google.com>,
	Ziwei Xiao <ziweixiao@google.com>,
	John Fraker <jfraker@google.com>,
	"Dr. David Alan Gilbert" <linux@treblig.org>,
	Ankit Garg <nktgrg@google.com>,
	linux-kernel@vger.kernel.org, Jordan Rhee <jordanrhee@google.com>
Subject: Re: [PATCH net-next v2 3/4] gve: Allow ethtool to configure rx_buf_len
Date: Wed, 5 Nov 2025 14:45:19 -0800	[thread overview]
Message-ID: <20251105144519.2729e38b@kernel.org> (raw)
In-Reply-To: <20251105182603.1223474-4-joshwash@google.com>

On Wed,  5 Nov 2025 10:26:02 -0800 joshwash@google.com wrote:
> +	if (priv->rx_cfg.packet_buffer_size != SZ_2K) {
> +		NL_SET_ERR_MSG_FMT_MOD(extack,
> +				       "XDP is not supported for Rx buf len %d, only %d supported.\n",

No \n in extack messages, please.
-- 
pw-bot: cr

  reply	other threads:[~2025-11-05 22:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-05 18:25 [PATCH net-next v2 0/4] gve: Improve RX buffer length management joshwash
2025-11-05 18:26 ` [PATCH net-next v2 1/4] gve: Decouple header split from RX buffer length joshwash
2025-11-05 18:26 ` [PATCH net-next v2 2/4] gve: Use extack to log xdp config verification errors joshwash
2025-11-05 18:26 ` [PATCH net-next v2 3/4] gve: Allow ethtool to configure rx_buf_len joshwash
2025-11-05 22:45   ` Jakub Kicinski [this message]
2025-11-06  4:36     ` Ankit Garg
2025-11-05 18:26 ` [PATCH net-next v2 4/4] gve: Default to max_rx_buffer_size for DQO if device supported joshwash

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251105144519.2729e38b@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=ast@kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hawk@kernel.org \
    --cc=hramamurthy@google.com \
    --cc=jfraker@google.com \
    --cc=john.fastabend@gmail.com \
    --cc=jordanrhee@google.com \
    --cc=joshwash@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@treblig.org \
    --cc=netdev@vger.kernel.org \
    --cc=nktgrg@google.com \
    --cc=pabeni@redhat.com \
    --cc=pkaligineedi@google.com \
    --cc=sdf@fomichev.me \
    --cc=willemb@google.com \
    --cc=ziweixiao@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).