From: Jakub Kicinski <kuba@kernel.org>
To: Michael Chan <michael.chan@broadcom.com>
Cc: Breno Leitao <leitao@debian.org>,
Pavan Chebbi <pavan.chebbi@broadcom.com>,
Michael Chan <mchan@broadcom.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@meta.com
Subject: Re: [PATCH net-next] tg3: extract GRXRINGS from .get_rxnfc
Date: Wed, 5 Nov 2025 17:01:45 -0800 [thread overview]
Message-ID: <20251105170145.461c8f11@kernel.org> (raw)
In-Reply-To: <CACKFLim7ruspmqvjr6bNRq5Z_XXVk3vVaLZOons7kMCzsEG23A@mail.gmail.com>
On Wed, 5 Nov 2025 11:05:34 -0800 Michael Chan wrote:
> The existing code to use num_online_cpus() is actually not correct.
> This is more correct:
>
> return min(netif_get_num_default_rss_queues(), tp->rxq_max);
>
> I think when netif_get_num_default_rss_queues() was used to replace
> num_online_cpus(), tg3_get_rxnfc() was not properly converted.
All true, but perhaps we want to do that change as a follow up?
Someone may show up later insisting that fewer queues cases
a regression for their workload..
The sensitivity to default queue count was why we didn't change most
of the drivers when netif_get_num_default_rss_queues() got reworked
to a more sane default than 8.
next prev parent reply other threads:[~2025-11-06 1:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-05 18:01 [PATCH net-next] tg3: extract GRXRINGS from .get_rxnfc Breno Leitao
2025-11-05 19:05 ` Michael Chan
2025-11-06 1:01 ` Jakub Kicinski [this message]
2025-11-06 6:00 ` Michael Chan
2025-11-06 17:06 ` Breno Leitao
2025-11-06 18:45 ` Michael Chan
2025-11-07 11:04 ` Simon Horman
2025-11-07 13:59 ` Breno Leitao
2025-11-06 22:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251105170145.461c8f11@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel-team@meta.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).