From: Jakub Kicinski <kuba@kernel.org>
To: Gal Pressman <gal@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>, <netdev@vger.kernel.org>,
Simon Horman <horms@kernel.org>,
Donald Hunter <donald.hunter@gmail.com>,
Carolina Jubran <cjubran@nvidia.com>
Subject: Re: [PATCH net-next] netlink: specs: netdev: Add missing qstats counters to reply
Date: Wed, 5 Nov 2025 17:13:59 -0800 [thread overview]
Message-ID: <20251105171359.4f14b199@kernel.org> (raw)
In-Reply-To: <20251105194010.688798-1-gal@nvidia.com>
On Wed, 5 Nov 2025 21:40:10 +0200 Gal Pressman wrote:
> Add all qstats counter attributes (HW-GRO, HW-GSO, checksum, drops,
> etc.) to the qstats-get reply specification. The kernel already sends
> these, but they were missing from the spec.
>
> Fixes: 92f8b1f5ca0f ("netdev: add queue stat for alloc failures")
> Fixes: 0cfe71f45f42 ("netdev: add queue stats")
> Fixes: 13c7c941e729 ("netdev: add qstat for csum complete")
> Fixes: b56035101e1c ("netdev: Add queue stats for TX stop and wake")
> Reviewed-by: Carolina Jubran <cjubran@nvidia.com>
> Signed-off-by: Gal Pressman <gal@nvidia.com>
Spooky how something is broken for over a year and then multiple people
send a fix within 24h! Please TAL at:
https://lore.kernel.org/all/20251104232348.1954349-2-kuba@kernel.org/
--
pw-bot: nap
next prev parent reply other threads:[~2025-11-06 1:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-05 19:40 [PATCH net-next] netlink: specs: netdev: Add missing qstats counters to reply Gal Pressman
2025-11-06 1:13 ` Jakub Kicinski [this message]
2025-11-09 12:16 ` Gal Pressman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251105171359.4f14b199@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=cjubran@nvidia.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).