[PATCH net-next] netlink: specs: netdev: Add missing qstats counters to reply

[PATCH net-next] netlink: specs: netdev: Add missing qstats counters to reply

[Gal Pressman]

Add all qstats counter attributes (HW-GRO, HW-GSO, checksum, drops,
etc.) to the qstats-get reply specification. The kernel already sends
these, but they were missing from the spec.

Fixes: 92f8b1f5ca0f ("netdev: add queue stat for alloc failures")
Fixes: 0cfe71f45f42 ("netdev: add queue stats")
Fixes: 13c7c941e729 ("netdev: add qstat for csum complete")
Fixes: b56035101e1c ("netdev: Add queue stats for TX stop and wake")
Reviewed-by: Carolina Jubran <cjubran@nvidia.com>
Signed-off-by: Gal Pressman <gal@nvidia.com>
---
 Documentation/netlink/specs/netdev.yaml | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/Documentation/netlink/specs/netdev.yaml b/Documentation/netlink/specs/netdev.yaml
index e00d3fa1c152..29b8290ebab5 100644
--- a/Documentation/netlink/specs/netdev.yaml
+++ b/Documentation/netlink/specs/netdev.yaml
@@ -732,6 +732,29 @@ operations:
             - rx-bytes
             - tx-packets
             - tx-bytes
+            - rx-alloc-fail
+            - rx-hw-drops
+            - rx-hw-drop-overruns
+            - rx-csum-complete
+            - rx-csum-unnecessary
+            - rx-csum-none
+            - rx-csum-bad
+            - rx-hw-gro-packets
+            - rx-hw-gro-bytes
+            - rx-hw-gro-wire-packets
+            - rx-hw-gro-wire-bytes
+            - rx-hw-drop-ratelimits
+            - tx-hw-drops
+            - tx-hw-drop-errors
+            - tx-csum-none
+            - tx-needs-csum
+            - tx-hw-gso-packets
+            - tx-hw-gso-bytes
+            - tx-hw-gso-wire-packets
+            - tx-hw-gso-wire-bytes
+            - tx-hw-drop-ratelimits
+            - tx-stop
+            - tx-wake
     -
       name: bind-rx
       doc: Bind dmabuf to netdev
-- 
2.40.1

Re: [PATCH net-next] netlink: specs: netdev: Add missing qstats counters to reply

[Jakub Kicinski]

On Wed, 5 Nov 2025 21:40:10 +0200 Gal Pressman wrote:
> Add all qstats counter attributes (HW-GRO, HW-GSO, checksum, drops,
> etc.) to the qstats-get reply specification. The kernel already sends
> these, but they were missing from the spec.
> 
> Fixes: 92f8b1f5ca0f ("netdev: add queue stat for alloc failures")
> Fixes: 0cfe71f45f42 ("netdev: add queue stats")
> Fixes: 13c7c941e729 ("netdev: add qstat for csum complete")
> Fixes: b56035101e1c ("netdev: Add queue stats for TX stop and wake")
> Reviewed-by: Carolina Jubran <cjubran@nvidia.com>
> Signed-off-by: Gal Pressman <gal@nvidia.com>

Spooky how something is broken for over a year and then multiple people
send a fix within 24h! Please TAL at:
https://lore.kernel.org/all/20251104232348.1954349-2-kuba@kernel.org/
-- 
pw-bot: nap

Re: [PATCH net-next] netlink: specs: netdev: Add missing qstats counters to reply

[Gal Pressman]

On 06/11/2025 3:13, Jakub Kicinski wrote:
> On Wed, 5 Nov 2025 21:40:10 +0200 Gal Pressman wrote:
>> Add all qstats counter attributes (HW-GRO, HW-GSO, checksum, drops,
>> etc.) to the qstats-get reply specification. The kernel already sends
>> these, but they were missing from the spec.
>>
>> Fixes: 92f8b1f5ca0f ("netdev: add queue stat for alloc failures")
>> Fixes: 0cfe71f45f42 ("netdev: add queue stats")
>> Fixes: 13c7c941e729 ("netdev: add qstat for csum complete")
>> Fixes: b56035101e1c ("netdev: Add queue stats for TX stop and wake")
>> Reviewed-by: Carolina Jubran <cjubran@nvidia.com>
>> Signed-off-by: Gal Pressman <gal@nvidia.com>
> 
> Spooky how something is broken for over a year and then multiple people
> send a fix within 24h! Please TAL at:
> https://lore.kernel.org/all/20251104232348.1954349-2-kuba@kernel.org/

Sorry, didn't notice your submission, thanks for the link!