From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0100214813 for ; Thu, 6 Nov 2025 01:21:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762392085; cv=none; b=Yzlw1FCOk3/xczgOLNGhR8z7dqsf4adr1agWb8RtU8jwdNq+i5IFFl4EDsP81fgbDt/Ni1Z23P2FD/A5wOsLuZeClGvT/9zuRnz7sRq5cMMA/URovhUgRt2PVwC35FlLjnZojK6NXNhDX7WMzVKhaaP4l5HX0UqhCZ00usn5HJs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762392085; c=relaxed/simple; bh=Zb4qG+DH2+6VaVA10nYzqnAn+yyysR0Y5SrxNNAe3hQ=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=SEFk90JV1Cju/gGUp79QQwTPbcV+dqNU5/27Eagw+AnC4S0MZyoDNYDp6RiMtLeq9bUxvtyhfLd9T1+5ZinvGiV/tCdLe9R5QeehevnvJHzFGWLq/YpVTLDRu1s15iNz/Ux6wWOWkUyaXtzRnp30ab+CUtgqz2jm78U+qnYCz5g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VV/zUKgb; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VV/zUKgb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 11D95C4CEF5; Thu, 6 Nov 2025 01:21:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1762392084; bh=Zb4qG+DH2+6VaVA10nYzqnAn+yyysR0Y5SrxNNAe3hQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=VV/zUKgb1HcsKOAk2et5rGcze2Bgn7Ckrqwz72nWvaxTvaM4udRy2d89cWqxeljLO GgY0OPRNarGl3+nx4EPnv/tt7TpRX2Bf9UdUE6UwdYMKlbFgP0UAuKHLqt43abmtBj dXi7j1jrxDzjRQDbpMDGWOEESoYukHUIa+a8MHRymekO7OBt2pmLrm0HR2qKaUN+AK Vov1ipun5NnqhpIIy+4qEyRS8NvLVl6LRkoYCafBS1tU32xs9SABPRFgQFMfzB1KKl nLeEWAHcrmxzfqm5J57E+6UOXVYEV3hsBrzHtcnFrdefKkMRoz/SG3LKpTtlmRaMgz UA1FXnjEl7S5Q== Date: Wed, 5 Nov 2025 17:21:23 -0800 From: Jakub Kicinski To: Vadim Fedorenko Cc: Manish Chopra , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Richard Cochran , Simon Horman , Jacob Keller , Kory Maincent , netdev@vger.kernel.org Subject: Re: [PATCH net-next 2/2] qede: convert to use ndo_hwtstamp callbacks Message-ID: <20251105172123.60cfe775@kernel.org> In-Reply-To: <20251105185133.3542054-3-vadim.fedorenko@linux.dev> References: <20251105185133.3542054-1-vadim.fedorenko@linux.dev> <20251105185133.3542054-3-vadim.fedorenko@linux.dev> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 5 Nov 2025 18:51:33 +0000 Vadim Fedorenko wrote: > The driver implemented SIOCSHWTSTAMP ioctl cmd only, but it stores > configuration in private structure, so it can be reported back to users. > Implement both ndo_hwtstamp_set and ndo_hwtstamp_set callbacks. > ndo_hwtstamp_set implements a check of unsupported 1-step timestamping > and qede_ptp_cfg_filters() becomes void as it cannot fail anymore. drivers/net/ethernet/qlogic/qede/qede_ptp.c:289:6: warning: unused variable 'rc' [-Wunused-variable] 289 | int rc; | ^~ Please consider: https://github.com/linux-netdev/nipa?tab=readme-ov-file#running-locally -- pw-bot: cr