From: Jakub Kicinski <kuba@kernel.org>
To: Wei Fang <wei.fang@nxp.com>
Cc: shenwei.wang@nxp.com, xiaoning.wang@nxp.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, eric@nelint.com, imx@lists.linux.dev,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: fec: correct rx_bytes statistic for the case SHIFT16 is set
Date: Fri, 7 Nov 2025 18:59:37 -0800 [thread overview]
Message-ID: <20251107185937.0cbaf200@kernel.org> (raw)
In-Reply-To: <20251106021421.2096585-1-wei.fang@nxp.com>
On Thu, 6 Nov 2025 10:14:21 +0800 Wei Fang wrote:
> ndev->stats.rx_bytes += pkt_len;
> + if (fep->quirks & FEC_QUIRK_HAS_RACC)
> + ndev->stats.rx_bytes -= 2;
Orthogonal to this patch, but why not:
ndev->stats.rx_bytes += pkt_len - sub_len;
? Is this driver intentionally counting FCS as bytes?
next prev parent reply other threads:[~2025-11-08 2:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-06 2:14 [PATCH net] net: fec: correct rx_bytes statistic for the case SHIFT16 is set Wei Fang
2025-11-06 16:19 ` Frank Li
2025-11-08 2:59 ` Jakub Kicinski [this message]
2025-11-10 6:51 ` Wei Fang
2025-11-08 3:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251107185937.0cbaf200@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric@nelint.com \
--cc=imx@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shenwei.wang@nxp.com \
--cc=wei.fang@nxp.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).