From: Jakub Kicinski <kuba@kernel.org>
To: Yao Zi <ziyao@disroot.org>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Yanteng Si <si.yanteng@linux.dev>,
Huacai Chen <chenhuacai@kernel.org>,
"Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
Philipp Stanner <phasta@kernel.org>,
Tiezhu Yang <yangtiezhu@loongson.cn>,
Qunqin Zhao <zhaoqunqin@loongson.cn>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Furong Xu <0x1207@gmail.com>,
Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
Jacob Keller <jacob.e.keller@intel.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v4 1/3] net: stmmac: Add generic suspend/resume helper for PCI-based controllers
Date: Wed, 12 Nov 2025 06:57:20 -0800 [thread overview]
Message-ID: <20251112065720.017c4d07@kernel.org> (raw)
In-Reply-To: <20251111100727.15560-3-ziyao@disroot.org>
On Tue, 11 Nov 2025 10:07:26 +0000 Yao Zi wrote:
> +config STMMAC_LIBPCI
> + tristate "STMMAC PCI helper library"
> + depends on PCI
> + default y
> + help
> + This selects the PCI bus helpers for the stmmac driver. If you
> + have a controller with PCI interface, say Y or M here.
I didn't pay enough attention to the discussion on v2, sorry.
I understand that there's precedent for a library symbol hiding
real symbols in this driver but it really makes for a poor user
experience.
The symbol should be hidden, and select'ed by what needs it.
With the PCI dependency on the real symbol, not here.
The "default y" may draw the attention of the Superior Penguin.
He may have quite a lot to criticize in this area, so let's
not risk it..
next prev parent reply other threads:[~2025-11-12 14:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-11 10:07 [PATCH net-next v4 0/3] Unify platform suspend/resume routines for PCI DWMAC glue Yao Zi
2025-11-11 10:07 ` [PATCH net-next v4 1/3] net: stmmac: Add generic suspend/resume helper for PCI-based controllers Yao Zi
2025-11-12 1:22 ` Yanteng Si
2025-11-12 14:57 ` Jakub Kicinski [this message]
2025-11-12 15:15 ` Russell King (Oracle)
2025-11-15 9:37 ` Yao Zi
2025-11-11 10:07 ` [PATCH net-next v4 2/3] net: stmmac: loongson: Use generic PCI suspend/resume routines Yao Zi
2025-11-11 10:23 ` Russell King (Oracle)
2025-11-12 1:23 ` Yanteng Si
2025-11-11 10:11 ` [PATCH net-next v4 3/3] net: stmmac: pci: " Yao Zi
2025-11-11 10:24 ` Russell King (Oracle)
2025-11-12 1:24 ` Yanteng Si
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251112065720.017c4d07@kernel.org \
--to=kuba@kernel.org \
--cc=0x1207@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=chenhuacai@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hayashi.kunihiko@socionext.com \
--cc=jacob.e.keller@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=phasta@kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=si.yanteng@linux.dev \
--cc=vladimir.oltean@nxp.com \
--cc=yangtiezhu@loongson.cn \
--cc=zhaoqunqin@loongson.cn \
--cc=ziyao@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).