From: Jakub Kicinski <kuba@kernel.org>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
linux-can@vger.kernel.org, kernel@pengutronix.de,
Gregor Herburger <gregor.herburger@ew.tq-group.com>,
Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com>,
Manivannan Sadhasivam <mani@kernel.org>
Subject: Re: [PATCH net-next 07/11] can: mcp251xfd: add workaround for errata 5
Date: Wed, 12 Nov 2025 09:28:00 -0800 [thread overview]
Message-ID: <20251112092800.290282eb@kernel.org> (raw)
In-Reply-To: <20251112091734.74315-8-mkl@pengutronix.de>
On Wed, 12 Nov 2025 10:13:47 +0100 Marc Kleine-Budde wrote:
> +static int
> +mcp251xfd_regmap_nocrc_gather_write(void *context,
> + const void *reg_p, size_t reg_len,
> + const void *val, size_t val_len)
> +{
> + const u16 byte_exclude = MCP251XFD_REG_IOCON +
> + mcp251xfd_first_byte_set(MCP251XFD_REG_IOCON_GPIO_MASK);
Looks like this is added by the next patch :(
drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c:48:59: error: ‘MCP251XFD_REG_IOCON_GPIO_MASK’ undeclared (first use in this function); did you mean ‘MCP251XFD_REG_IOCON_GPIO0’?
48 | mcp251xfd_first_byte_set(MCP251XFD_REG_IOCON_GPIO_MASK);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| MCP251XFD_REG_IOCON_GPIO0
Do you do rebases or do we have to take it as is?
next prev parent reply other threads:[~2025-11-12 17:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-12 9:13 [PATCH net-next 0/11] pull-request: can-next 2025-11-12 Marc Kleine-Budde
2025-11-12 9:13 ` [PATCH net-next 01/11] can: convert generic HW timestamp ioctl to ndo_hwtstamp callbacks Marc Kleine-Budde
2025-11-12 9:13 ` [PATCH net-next 02/11] can: peak_canfd: convert to use " Marc Kleine-Budde
2025-11-12 9:13 ` [PATCH net-next 03/11] can: peak_usb: " Marc Kleine-Budde
2025-11-12 9:13 ` [PATCH net-next 04/11] can: mcp251x: mcp251x_can_probe(): use dev_err_probe() Marc Kleine-Budde
2025-11-12 9:13 ` [PATCH net-next 05/11] can: mcp251xfd: move chip sleep mode into runtime pm Marc Kleine-Budde
2025-11-12 9:13 ` [PATCH net-next 06/11] can: mcp251xfd: utilize gather_write function for all non-CRC writes Marc Kleine-Budde
2025-11-12 9:13 ` [PATCH net-next 07/11] can: mcp251xfd: add workaround for errata 5 Marc Kleine-Budde
2025-11-12 17:28 ` Jakub Kicinski [this message]
2025-11-12 18:17 ` Marc Kleine-Budde
2025-11-12 18:45 ` Marc Kleine-Budde
2025-11-12 9:13 ` [PATCH net-next 08/11] can: mcp251xfd: only configure PIN1 when rx_int is set Marc Kleine-Budde
2025-11-12 9:13 ` [PATCH net-next 09/11] can: mcp251xfd: add gpio functionality Marc Kleine-Budde
2025-11-12 9:13 ` [PATCH net-next 10/11] dt-bindings: can: mcp251xfd: add gpio-controller property Marc Kleine-Budde
2025-11-12 9:13 ` [PATCH net-next 11/11] can: bxcan: Fix a typo error for assign Marc Kleine-Budde
2025-11-12 9:36 ` [PATCH net-next 0/11] pull-request: can-next 2025-11-12 Marc Kleine-Budde
-- strict thread matches above, loose matches on Subject: below --
2025-11-12 18:40 Marc Kleine-Budde
2025-11-12 18:40 ` [PATCH net-next 07/11] can: mcp251xfd: add workaround for errata 5 Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251112092800.290282eb@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=gregor.herburger@ew.tq-group.com \
--cc=kernel@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=viken.dadhaniya@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).