From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Felix Maurer <fmaurer@redhat.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
liuhangbin@gmail.com, m-karicheri2@ti.com, arvid.brodin@alten.se
Subject: Re: [PATCH net 2/2] hsr: Follow standard for HSRv0 supervision frames
Date: Wed, 12 Nov 2025 11:24:05 +0100 [thread overview]
Message-ID: <20251112102405.8xxcDBuT@linutronix.de> (raw)
In-Reply-To: <ea0d5133cd593856b2fa673d6e2067bf1d4d1794.1762876095.git.fmaurer@redhat.com>
On 2025-11-11 17:29:33 [+0100], Felix Maurer wrote:
> For HSRv0, the path_id has the following meaning:
> - 0000: PRP supervision frame
> - 0001-1001: HSR ring identifier
> - 1010-1011: Frames from PRP network (A/B, with RedBoxes)
> - 1111: HSR supervision frame
Where do you have this from?
I have here IEC 62439-3:2021 (Edition 4.0 2021-12).
From the 4 bits of path_id, the three most significant bits are NetId
with 0 for HSR and 1 to 6 for the PTP network and 7 reserved.
The list significant bit for PRP indicates Redbox A/B while for HSR it
indicates port A/B.
You say HSRv0 while I don't see this mentioned at all. And you limit the
change to prot_version == 0. So maybe this was once and removed from the
standard.
Since this is limited to v0:
Reviewed-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Sebastian
next prev parent reply other threads:[~2025-11-12 10:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-11 16:29 [PATCH net 0/2] hsr: Send correct HSRv0 supervision frames Felix Maurer
2025-11-11 16:29 ` [PATCH net 1/2] hsr: Fix supervision frame sending on HSRv0 Felix Maurer
2025-11-12 10:03 ` Sebastian Andrzej Siewior
2025-11-11 16:29 ` [PATCH net 2/2] hsr: Follow standard for HSRv0 supervision frames Felix Maurer
2025-11-12 10:24 ` Sebastian Andrzej Siewior [this message]
2025-11-12 11:01 ` Felix Maurer
2025-11-12 11:59 ` Sebastian Andrzej Siewior
2025-11-12 9:41 ` [PATCH net 0/2] hsr: Send correct " Hangbin Liu
2025-11-12 10:03 ` Sebastian Andrzej Siewior
2025-11-12 10:38 ` Felix Maurer
2025-11-13 15:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251112102405.8xxcDBuT@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=arvid.brodin@alten.se \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fmaurer@redhat.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=liuhangbin@gmail.com \
--cc=m-karicheri2@ti.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).