From: Stephen Hemminger <stephen@networkplumber.org>
To: Eric Biggers <ebiggers@kernel.org>
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org,
linux-crypto@vger.kernel.org, Ard Biesheuvel <ardb@kernel.org>
Subject: Re: [PATCH iproute2-next v2] lib/bpf_legacy: Use userspace SHA-1 code instead of AF_ALG
Date: Wed, 12 Nov 2025 12:12:12 -0800 [thread overview]
Message-ID: <20251112121212.66e15a2d@phoenix> (raw)
In-Reply-To: <20250929194648.145585-1-ebiggers@kernel.org>
On Mon, 29 Sep 2025 12:46:48 -0700
Eric Biggers <ebiggers@kernel.org> wrote:
> diff --git a/lib/sha1.c b/lib/sha1.c
> new file mode 100644
> index 00000000..1aa8fd83
> --- /dev/null
> +++ b/lib/sha1.c
> @@ -0,0 +1,108 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +/*
> + * SHA-1 message digest algorithm
> + *
> + * Copyright 2025 Google LLC
> + */
Not a big fan of having actual crypto in iproute2.
It creates even more technical debt.
Is there another crypto library that could be used?
Better yet, is there a reason legacy BPF code needs to still exist
in current iproute2? When was the cut over.
next prev parent reply other threads:[~2025-11-12 20:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-29 19:46 [PATCH iproute2-next v2] lib/bpf_legacy: Use userspace SHA-1 code instead of AF_ALG Eric Biggers
2025-10-01 22:59 ` Alexei Starovoitov
2025-10-01 23:33 ` Eric Biggers
2025-10-02 17:12 ` Alexei Starovoitov
2025-10-02 17:36 ` Eric Biggers
2025-10-02 17:53 ` Alexei Starovoitov
2025-11-12 4:07 ` Eric Biggers
2025-11-16 17:45 ` David Ahern
2025-12-17 23:44 ` Eric Biggers
2025-12-18 19:58 ` David Ahern
2025-11-12 20:12 ` Stephen Hemminger [this message]
2025-11-12 20:22 ` Eric Biggers
2025-11-13 7:25 ` Ard Biesheuvel
2025-11-13 8:51 ` Simon Richter
2025-11-13 15:35 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251112121212.66e15a2d@phoenix \
--to=stephen@networkplumber.org \
--cc=ardb@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=ebiggers@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).