From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA8403396F7; Wed, 12 Nov 2025 15:41:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762962071; cv=none; b=seIblmDXQ7LVGGpqRk/IXxsdnf7ARexgpQKG2A9ULqtWMKU1zb8L+YgPJ4G1AegCterbPXb5Msc4gnAO2s3uWrC63c8m2NNDZpMPJpO2DgtLgDqXvMVcGZrfMR8uO3V9+LoBevRfC6jooMarDhdaw+cNS8PaudBqtNjCmOdVB0k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762962071; c=relaxed/simple; bh=a1msumuHpfaPwJz2Du4EaY8Xpj6OMjRhwm1QloADBpQ=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=VMJQnsYHWIudhliTxJfu7HnlmhjHUDm1AQS1Ba/ark0SkC7Vws0BhRUPTFd2mnSTf7LS1pVFmT0r2I4ygpeQQeS2z/NjNsfLRlkBnrJZYIL7CzdNZ1gGYZrj61RSndP/LQHlC0wxsQ7fBBkVDQiPohMu8uZbdlhnj4MRBSLdK2U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTPS id 4d67014lYTzJ46Cf; Wed, 12 Nov 2025 23:40:33 +0800 (CST) Received: from dubpeml100005.china.huawei.com (unknown [7.214.146.113]) by mail.maildlp.com (Postfix) with ESMTPS id 58EE2140370; Wed, 12 Nov 2025 23:41:06 +0800 (CST) Received: from localhost (10.203.177.15) by dubpeml100005.china.huawei.com (7.214.146.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.36; Wed, 12 Nov 2025 15:41:05 +0000 Date: Wed, 12 Nov 2025 15:41:03 +0000 From: Jonathan Cameron To: CC: , , , , , , , , , Alejandro Lucero , Ben Cheatham , Fan Ni , Alison Schofield Subject: Re: [PATCH v20 06/22] cxl: Move pci generic code Message-ID: <20251112154103.000025fd@huawei.com> In-Reply-To: <20251110153657.2706192-7-alejandro.lucero-palau@amd.com> References: <20251110153657.2706192-1-alejandro.lucero-palau@amd.com> <20251110153657.2706192-7-alejandro.lucero-palau@amd.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml500010.china.huawei.com (7.191.174.240) To dubpeml100005.china.huawei.com (7.214.146.113) On Mon, 10 Nov 2025 15:36:41 +0000 alejandro.lucero-palau@amd.com wrote: > From: Alejandro Lucero > > Inside cxl/core/pci.c there are helpers for CXL PCIe initialization > meanwhile cxl/pci.c implements the functionality for a Type3 device > initialization. > > Move helper functions from cxl/pci.c to cxl/core/pci.c in order to be > exported and shared with CXL Type2 device initialization. > > Fix cxl mock tests affected by the code move, deleting a function which > indeed was not being used since commit 733b57f262b0("cxl/pci: Early > setup RCH dport component registers from RCRB"). As I replied late to v19, I'd like to understand more about this comment. If it was not being used, why can't we remove it before this patch? > > Signed-off-by: Alejandro Lucero > Reviewed-by: Dave Jiang > Reviewed-by: Ben Cheatham > Reviewed-by: Fan Ni > Reviewed-by: Jonathan Cameron > Reviewed-by: Alison Schofield > Reviewed-by: Dan Williams