From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D121727D782 for ; Wed, 12 Nov 2025 21:37:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762983464; cv=none; b=UCvRtRlRJe4Kt435gO71yeSIvC08YkcA8QyK3W60sKai2Q48xrz961cK+qhfRZP7qmL1dZP90jf+sXEj7gxpTci/wvdrwvpjIhgHfiDPZhruZK/Ghgdr9X6MKtDwBo+E18W6lMe4Qnt2c0wLS9nsnXBoP4ZiI5LrNy7CxbOxc1c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762983464; c=relaxed/simple; bh=HUjRpcgFxZlsaHDR5Oqy1tRZ/gEUVjG9KwG6dKCpQwc=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=mjomXKCt+lbFdLzI/8Yf8QXXmFvIGMmAkf5eWBdV5nx6j88/BvNSPv2eNLQvWba0PUnny4pg3KXtAYhAwm6jB9UTKrx5KFtrdKkyWeZb+J/b+QW13Xr3oEY3I5GGZWevgr0exHC0vbLaHLWXPJXBv98euRLFGvgawNDy9k5NlJc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iYrwUZUP; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iYrwUZUP" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-475ca9237c2so833325e9.3 for ; Wed, 12 Nov 2025 13:37:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1762983461; x=1763588261; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=AMNC/ZxkQfI0c8vktPmv03MO9ljLn0+pOW6ecFqMx5g=; b=iYrwUZUPJ7mnhRrogjjl/7mIb8tshRGbgPCsEAy3HhYGRECWVAy9QIc2nMe0Lb3U8j joNPnKjx9fEeyvkwg28Sob9n2pbBM6cK/+mLKpjO3xPqFAUOrnZRuQknUeB6zh1FxcEC /lRF5ZmkbxyRNSI2wnfzLbrDqGgGBCHs0BHJn7E4BcdIaDQ2qqeoiRA+V1DYVIuY174I JAE5d+fEN6MkiFE0qAy6BPBckM9m5lrHTM3GO4n2i6xkTsQgk/CsGKALmFXKCr9Hgqnl h3lYTu2/j9hedq3zipRfroXmuz9uBGY3sYuvq20HXpd11qHup5Z3czL9CoCZzPMvMsDT jj5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762983461; x=1763588261; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=AMNC/ZxkQfI0c8vktPmv03MO9ljLn0+pOW6ecFqMx5g=; b=TsfzTTtMlQm2QMGm2GBj8M4LXl7u9OT0NolFEXPq1GZ2cuYQwEJeB4JibMRaxa0gNM Au5iqpKZz2KB1JZzR0FczdMow0hbG+F1jRGY13fPnw+QH6QccG3ZRiTsAwCfcwBuTToD WKd8h3g4FcYZrO+laA6Ypp1GrK/Bfrq8msquss4qWytJeUlT1r8mnS0UfM/Kk1uBdJbP wGe+yFXvMMjGbdNc1AAPckHYfFOpcZLZjepXQnBMM3DGtTv+cUg2ay4qyEbPI7sR8v8F srhYxeK9NL1cin4gx0W2YqGdBomb2iQPrnzFFLb+JkXUBED4+pC+MgZ31gSosUvQmUwQ ZNdg== X-Forwarded-Encrypted: i=1; AJvYcCVB1hQ5lM40TdKA10uJsZ73Gs9aHsmAItkH7kbstnT41r5CCSBrAWwRc0AkEMgdittzrs0v6vk=@vger.kernel.org X-Gm-Message-State: AOJu0Yww5hsE4L4463pQc16e7Tpa73Wp0+ZhY4L7ZGKwit/kAKIedwAF J2ArYqQRy5F9v/kUR+ZEAX0P5lhCVSbVAURgBEhWQWRFLG3EJ4PrSNYA X-Gm-Gg: ASbGnctJ/JpGuZFOFrEu160ksHwdFE3d0Cjk8fI9FTwAg4O/M01OH3NbowNDRnBeOxT XP9u4o7Ysfq0qRECEcQ0zVA/1ZnGS+u4bGo4e+VA5h7d5q4VW+3kBz3Uy5lS1VbB88Jev5MoNfO /S8T0i+zJXy1gw183Y6HNBO/AxGA4Mf46vjiLM5BNllh4q8kTt8rQZpZ00TR7v8mvWLRogvjtmK i3VSY8QkMBViSBojBG0xXhzkeZMkv/kY/kkgWE74nomqArqKwRkaR2T0cV1NoOfg099K6pPwmgZ zpxkmfPdUQw3CXQ9Qun8U6YXlzFm+/zsPz6Z/k1H+bbH/xPl9VcIkoBSA/ER5vbUYafC5PiTQra lqGMpdAq83DixuTNGAQBAiGioS0k64YogstT9fd7RndoQa1KWrW1P7hoQmmOagfQ3wuzYWQGNnH QQE/EDT3+Ytb7qeM5WDz6LK4D30C8eJ9cW/paZdWlwsA== X-Google-Smtp-Source: AGHT+IEDSNODJ3nVTpsyc0L/4cxRnEnvAJ/B+BZ/K+v6Nx94yhuMxFrpIqibz96viADsSJoC80InpA== X-Received: by 2002:a05:600c:4594:b0:477:7b16:5f88 with SMTP id 5b1f17b1804b1-477870623f5mr42996915e9.6.1762983461012; Wed, 12 Nov 2025 13:37:41 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4778c8479b7sm12365e9.3.2025.11.12.13.37.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Nov 2025 13:37:40 -0800 (PST) Date: Wed, 12 Nov 2025 21:37:39 +0000 From: David Laight To: "Lecomte, Arnaud" Cc: Brahmajit Das , syzbot+d1b7fa1092def3628bd7@syzkaller.appspotmail.com, andrii@kernel.org, ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, eddyz87@gmail.com, haoluo@google.com, john.fastabend@gmail.com, jolsa@kernel.org, kpsingh@kernel.org, linux-kernel@vger.kernel.org, martin.lau@linux.dev, netdev@vger.kernel.org, sdf@fomichev.me, song@kernel.org, syzkaller-bugs@googlegroups.com, yonghong.song@linux.dev Subject: Re: [PATCH bpf-next v3] bpf: Clamp trace length in __bpf_get_stack to fix OOB write Message-ID: <20251112213739.40123684@pumpkin> In-Reply-To: References: <691231dc.a70a0220.22f260.0101.GAE@google.com> <20251111081254.25532-1-listout@listout.xyz> <20251112133546.4246533f@pumpkin> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 12 Nov 2025 16:11:41 +0000 "Lecomte, Arnaud" wrote: > On 12/11/2025 14:47, Brahmajit Das wrote: > > On 12.11.2025 13:35, David Laight wrote: > >> On Tue, 11 Nov 2025 13:42:54 +0530 > >> Brahmajit Das wrote: > >> > > ...snip... > >> Please can we have no unnecessary min_t(). > >> You wouldn't write: > >> x = (u32)a < (u32)b ? (u32)a : (u32)b; > >> > >> David > >> > >>> copy_len = trace_nr * elem_size; > >>> > >>> ips = trace->ip + skip; > > Hi David, > > > > Sorry, I didn't quite get that. Would prefer something like: > > trace_nr = (trace_nr <= num_elem) ? trace_nr : num_elem; > > min_t is a min with casting which is unnecessary in this case as > trace_nr and num_elem are already u32. Correct David > > > The pre-refactor code. > > >