From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
To: Andrew Lunn <andrew+netdev@lunn.ch>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Russell King <linux@armlinux.org.uk>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Andrei Botila <andrei.botila@oss.nxp.com>,
Richard Cochran <richardcochran@gmail.com>,
Andrew Lunn <andrew@lunn.ch>
Cc: Simon Horman <horms@kernel.org>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Jacob Keller <jacob.e.keller@intel.com>,
Kory Maincent <kory.maincent@bootlin.com>,
bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org,
Vadim Fedorenko <vadim.fedorenko@linux.dev>
Subject: [PATCH net-next v2 2/9] phy: add hwtstamp_get callback to phy drivers
Date: Thu, 13 Nov 2025 11:32:00 +0000 [thread overview]
Message-ID: <20251113113207.3928966-3-vadim.fedorenko@linux.dev> (raw)
In-Reply-To: <20251113113207.3928966-1-vadim.fedorenko@linux.dev>
PHY devices had lack of hwtstamp_get callback even though most of them
are tracking configuration info. Introduce new call back to
mii_timestamper.
Signed-off-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
---
drivers/net/phy/phy.c | 20 +++++++++++++++++++-
include/linux/mii_timestamper.h | 5 +++++
2 files changed, 24 insertions(+), 1 deletion(-)
diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index 350bc23c1fdb..6cb87e3608e5 100644
--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -310,7 +310,7 @@ EXPORT_SYMBOL(phy_ethtool_ksettings_get);
int phy_mii_ioctl(struct phy_device *phydev, struct ifreq *ifr, int cmd)
{
struct mii_ioctl_data *mii_data = if_mii(ifr);
- struct kernel_hwtstamp_config kernel_cfg;
+ struct kernel_hwtstamp_config kernel_cfg = {};
struct netlink_ext_ack extack = {};
u16 val = mii_data->val_in;
bool change_autoneg = false;
@@ -404,6 +404,21 @@ int phy_mii_ioctl(struct phy_device *phydev, struct ifreq *ifr, int cmd)
return 0;
+ case SIOCGHWTSTAMP:
+ if (phydev->mii_ts && phydev->mii_ts->hwtstamp_get) {
+ ret = phydev->mii_ts->hwtstamp_get(phydev->mii_ts,
+ &kernel_cfg);
+ if (ret)
+ return ret;
+
+ hwtstamp_config_from_kernel(&cfg, &kernel_cfg);
+ if (copy_to_user(ifr->ifr_data, &cfg, sizeof(cfg)))
+ return -EFAULT;
+
+ return 0;
+ }
+ return -EOPNOTSUPP;
+
case SIOCSHWTSTAMP:
if (phydev->mii_ts && phydev->mii_ts->hwtstamp_set) {
if (copy_from_user(&cfg, ifr->ifr_data, sizeof(cfg)))
@@ -478,6 +493,9 @@ int __phy_hwtstamp_get(struct phy_device *phydev,
if (!phydev)
return -ENODEV;
+ if (phydev->mii_ts && phydev->mii_ts->hwtstamp_get)
+ return phydev->mii_ts->hwtstamp_get(phydev->mii_ts, config);
+
return -EOPNOTSUPP;
}
diff --git a/include/linux/mii_timestamper.h b/include/linux/mii_timestamper.h
index 08863c0e9ea3..3102c425c8e0 100644
--- a/include/linux/mii_timestamper.h
+++ b/include/linux/mii_timestamper.h
@@ -29,6 +29,8 @@ struct phy_device;
*
* @hwtstamp_set: Handles SIOCSHWTSTAMP ioctl for hardware time stamping.
*
+ * @hwtstamp_get: Handles SIOCGHWTSTAMP ioctl for hardware time stamping.
+ *
* @link_state: Allows the device to respond to changes in the link
* state. The caller invokes this function while holding
* the phy_device mutex.
@@ -55,6 +57,9 @@ struct mii_timestamper {
struct kernel_hwtstamp_config *kernel_config,
struct netlink_ext_ack *extack);
+ int (*hwtstamp_get)(struct mii_timestamper *mii_ts,
+ struct kernel_hwtstamp_config *kernel_config);
+
void (*link_state)(struct mii_timestamper *mii_ts,
struct phy_device *phydev);
--
2.47.3
next prev parent reply other threads:[~2025-11-13 11:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-13 11:31 [PATCH net-next v2 0/9] add hwtstamp_get callback to phy drivers Vadim Fedorenko
2025-11-13 11:31 ` [PATCH net-next v2 1/9] phy: rename hwtstamp callback to hwtstamp_set Vadim Fedorenko
2025-11-13 13:31 ` Andrew Lunn
2025-11-13 11:32 ` Vadim Fedorenko [this message]
2025-11-13 12:02 ` [PATCH net-next v2 2/9] phy: add hwtstamp_get callback to phy drivers Russell King (Oracle)
2025-11-13 12:12 ` Vadim Fedorenko
2025-11-13 12:24 ` Russell King (Oracle)
2025-11-17 17:39 ` Vadim Fedorenko
2025-11-17 17:56 ` Russell King (Oracle)
2025-11-13 13:36 ` Andrew Lunn
2025-11-13 16:48 ` Vadim Fedorenko
2025-11-13 16:57 ` Russell King (Oracle)
2025-11-13 17:05 ` Vadim Fedorenko
2025-11-13 17:15 ` Russell King (Oracle)
2025-11-13 18:03 ` Vadim Fedorenko
2025-11-13 11:32 ` [PATCH net-next v2 3/9] net: phy: broadcom: add HW timestamp configuration reporting Vadim Fedorenko
2025-11-13 11:32 ` [PATCH net-next v2 4/9] net: phy: dp83640: " Vadim Fedorenko
2025-11-13 11:32 ` [PATCH net-next v2 5/9] net: phy: micrel: " Vadim Fedorenko
2025-11-13 11:32 ` [PATCH net-next v2 6/9] net: phy: microchip_rds_ptp: " Vadim Fedorenko
2025-11-13 11:32 ` [PATCH net-next v2 7/9] phy: mscc: " Vadim Fedorenko
2025-11-13 11:32 ` [PATCH net-next v2 8/9] net: phy: nxp-c45-tja11xx: " Vadim Fedorenko
2025-11-13 11:32 ` [PATCH net-next v2 9/9] ptp: ptp_ines: " Vadim Fedorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251113113207.3928966-3-vadim.fedorenko@linux.dev \
--to=vadim.fedorenko@linux.dev \
--cc=andrei.botila@oss.nxp.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).