netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] sctp: Remove unused declaration sctp_auth_init_hmacs()
@ 2025-11-13 11:45 Yue Haibing
  2025-11-13 17:19 ` Eric Biggers
  2025-11-15  2:20 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Yue Haibing @ 2025-11-13 11:45 UTC (permalink / raw)
  To: marcelo.leitner, lucien.xin, davem, edumazet, kuba, pabeni, horms,
	ebiggers
  Cc: linux-sctp, netdev, linux-kernel, yuehaibing

Commit bf40785fa437 ("sctp: Use HMAC-SHA1 and HMAC-SHA256 library for chunk
authentication") removed the implementation but leave declaration.

Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
 include/net/sctp/auth.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/include/net/sctp/auth.h b/include/net/sctp/auth.h
index 3d5879e08e78..6f2cd562b1de 100644
--- a/include/net/sctp/auth.h
+++ b/include/net/sctp/auth.h
@@ -72,7 +72,6 @@ struct sctp_shared_key *sctp_auth_get_shkey(
 int sctp_auth_asoc_copy_shkeys(const struct sctp_endpoint *ep,
 				struct sctp_association *asoc,
 				gfp_t gfp);
-int sctp_auth_init_hmacs(struct sctp_endpoint *ep, gfp_t gfp);
 const struct sctp_hmac *sctp_auth_get_hmac(__u16 hmac_id);
 const struct sctp_hmac *
 sctp_auth_asoc_get_hmac(const struct sctp_association *asoc);
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] sctp: Remove unused declaration sctp_auth_init_hmacs()
  2025-11-13 11:45 [PATCH net-next] sctp: Remove unused declaration sctp_auth_init_hmacs() Yue Haibing
@ 2025-11-13 17:19 ` Eric Biggers
  2025-11-15  2:20 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Eric Biggers @ 2025-11-13 17:19 UTC (permalink / raw)
  To: Yue Haibing
  Cc: marcelo.leitner, lucien.xin, davem, edumazet, kuba, pabeni, horms,
	linux-sctp, netdev, linux-kernel

On Thu, Nov 13, 2025 at 07:45:01PM +0800, Yue Haibing wrote:
> Commit bf40785fa437 ("sctp: Use HMAC-SHA1 and HMAC-SHA256 library for chunk
> authentication") removed the implementation but leave declaration.
> 
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> ---
>  include/net/sctp/auth.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/net/sctp/auth.h b/include/net/sctp/auth.h
> index 3d5879e08e78..6f2cd562b1de 100644
> --- a/include/net/sctp/auth.h
> +++ b/include/net/sctp/auth.h
> @@ -72,7 +72,6 @@ struct sctp_shared_key *sctp_auth_get_shkey(
>  int sctp_auth_asoc_copy_shkeys(const struct sctp_endpoint *ep,
>  				struct sctp_association *asoc,
>  				gfp_t gfp);
> -int sctp_auth_init_hmacs(struct sctp_endpoint *ep, gfp_t gfp);
>  const struct sctp_hmac *sctp_auth_get_hmac(__u16 hmac_id);
>  const struct sctp_hmac *
>  sctp_auth_asoc_get_hmac(const struct sctp_association *asoc);

Reviewed-by: Eric Biggers <ebiggers@kernel.org>

- Eric

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] sctp: Remove unused declaration sctp_auth_init_hmacs()
  2025-11-13 11:45 [PATCH net-next] sctp: Remove unused declaration sctp_auth_init_hmacs() Yue Haibing
  2025-11-13 17:19 ` Eric Biggers
@ 2025-11-15  2:20 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-11-15  2:20 UTC (permalink / raw)
  To: Yue Haibing
  Cc: marcelo.leitner, lucien.xin, davem, edumazet, kuba, pabeni, horms,
	ebiggers, linux-sctp, netdev, linux-kernel

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 13 Nov 2025 19:45:01 +0800 you wrote:
> Commit bf40785fa437 ("sctp: Use HMAC-SHA1 and HMAC-SHA256 library for chunk
> authentication") removed the implementation but leave declaration.
> 
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> ---
>  include/net/sctp/auth.h | 1 -
>  1 file changed, 1 deletion(-)

Here is the summary with links:
  - [net-next] sctp: Remove unused declaration sctp_auth_init_hmacs()
    https://git.kernel.org/netdev/net-next/c/06ac47065819

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-11-15  2:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-13 11:45 [PATCH net-next] sctp: Remove unused declaration sctp_auth_init_hmacs() Yue Haibing
2025-11-13 17:19 ` Eric Biggers
2025-11-15  2:20 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).