From: Jakub Kicinski <kuba@kernel.org>
To: "Ваторопин Андрей" <a.vatoropin@crpt.ru>
Cc: Ajit Khaparde <ajit.khaparde@broadcom.com>,
Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Venkata Duvvuru <VenkatKumar.Duvvuru@Emulex.Com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lvc-project@linuxtesting.org" <lvc-project@linuxtesting.org>
Subject: Re: [PATCH net] be2net: check wrb_params for NULL value
Date: Thu, 13 Nov 2025 17:38:07 -0800 [thread overview]
Message-ID: <20251113173807.32a2ba2f@kernel.org> (raw)
In-Reply-To: <20251112092051.851163-1-a.vatoropin@crpt.ru>
On Wed, 12 Nov 2025 09:21:04 +0000 Ваторопин Андрей wrote:
> Another way would be to pass a valid wrb_params from be_xmit(), but that
> seems to be redundant as the corresponding bit in wrb_params should have
> been already set there in advance with a call to be_xmit_workarounds().
I don't think so, or at least I don't see that for all cases..
Since there's just one caller and it has the struct handy I think
it's better to just pass it and avoid the NULL.
BTW there are hard spaces in your commit msg, please try to fix
that for v2.
--
pw-bot: cr
prev parent reply other threads:[~2025-11-14 1:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-12 9:21 [PATCH net] be2net: check wrb_params for NULL value Ваторопин Андрей
2025-11-14 1:38 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251113173807.32a2ba2f@kernel.org \
--to=kuba@kernel.org \
--cc=VenkatKumar.Duvvuru@Emulex.Com \
--cc=a.vatoropin@crpt.ru \
--cc=ajit.khaparde@broadcom.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=somnath.kotur@broadcom.com \
--cc=sriharsha.basavapatna@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).