netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH v6 3/4] crypto: ti - Add support for AES-GCM in DTHEv2 driver
       [not found] <20251111112137.976121-4-t-pratham@ti.com>
@ 2025-11-14  6:47 ` kernel test robot
  2025-11-14  9:04   ` T Pratham
  2025-11-14  7:52 ` kernel test robot
  2025-11-14  9:36 ` kernel test robot
  2 siblings, 1 reply; 4+ messages in thread
From: kernel test robot @ 2025-11-14  6:47 UTC (permalink / raw)
  To: T Pratham, Herbert Xu, David S. Miller
  Cc: llvm, oe-kbuild-all, netdev, Manorit Chawdhry, Kamlesh Gurudasani,
	Shiva Tripathi, Kavitha Malarvizhi, Vishal Mahaveer, linux-crypto,
	linux-kernel

Hi Pratham,

kernel test robot noticed the following build errors:

[auto build test ERROR on herbert-crypto-2.6/master]
[also build test ERROR on linus/master v6.18-rc5]
[cannot apply to herbert-cryptodev-2.6/master next-20251113]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/T-Pratham/crypto-ti-Add-support-for-AES-XTS-in-DTHEv2-driver/20251111-192827
base:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git master
patch link:    https://lore.kernel.org/r/20251111112137.976121-4-t-pratham%40ti.com
patch subject: [PATCH v6 3/4] crypto: ti - Add support for AES-GCM in DTHEv2 driver
config: arm-randconfig-003-20251114 (https://download.01.org/0day-ci/archive/20251114/202511141245.zQcC9EcY-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 0bba1e76581bad04e7d7f09f5115ae5e2989e0d9)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251114/202511141245.zQcC9EcY-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202511141245.zQcC9EcY-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/crypto/ti/dthev2-aes.c:573:17: error: call to undeclared function 'crypto_alloc_sync_aead'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     573 |         ctx->aead_fb = crypto_alloc_sync_aead(alg_name, 0,
         |                        ^
   drivers/crypto/ti/dthev2-aes.c:573:17: note: did you mean 'crypto_alloc_aead'?
   include/crypto/aead.h:181:21: note: 'crypto_alloc_aead' declared here
     181 | struct crypto_aead *crypto_alloc_aead(const char *alg_name, u32 type, u32 mask);
         |                     ^
>> drivers/crypto/ti/dthev2-aes.c:573:15: error: incompatible integer to pointer conversion assigning to 'struct crypto_sync_aead *' from 'int' [-Wint-conversion]
     573 |         ctx->aead_fb = crypto_alloc_sync_aead(alg_name, 0,
         |                      ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     574 |                                               CRYPTO_ALG_NEED_FALLBACK);
         |                                               ~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/crypto/ti/dthev2-aes.c:588:2: error: call to undeclared function 'crypto_free_sync_aead'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     588 |         crypto_free_sync_aead(ctx->aead_fb);
         |         ^
   drivers/crypto/ti/dthev2-aes.c:588:2: note: did you mean 'crypto_free_aead'?
   include/crypto/aead.h:194:20: note: 'crypto_free_aead' declared here
     194 | static inline void crypto_free_aead(struct crypto_aead *tfm)
         |                    ^
>> drivers/crypto/ti/dthev2-aes.c:831:2: error: call to undeclared function 'crypto_sync_aead_clear_flags'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     831 |         crypto_sync_aead_clear_flags(ctx->aead_fb, CRYPTO_TFM_REQ_MASK);
         |         ^
   drivers/crypto/ti/dthev2-aes.c:831:2: note: did you mean 'crypto_aead_clear_flags'?
   include/crypto/aead.h:298:20: note: 'crypto_aead_clear_flags' declared here
     298 | static inline void crypto_aead_clear_flags(struct crypto_aead *tfm, u32 flags)
         |                    ^
>> drivers/crypto/ti/dthev2-aes.c:832:2: error: call to undeclared function 'crypto_sync_aead_set_flags'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     832 |         crypto_sync_aead_set_flags(ctx->aead_fb,
         |         ^
>> drivers/crypto/ti/dthev2-aes.c:836:9: error: call to undeclared function 'crypto_sync_aead_setkey'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     836 |         return crypto_sync_aead_setkey(ctx->aead_fb, key, keylen);
         |                ^
   drivers/crypto/ti/dthev2-aes.c:836:9: note: did you mean 'crypto_aead_setkey'?
   include/crypto/aead.h:319:5: note: 'crypto_aead_setkey' declared here
     319 | int crypto_aead_setkey(struct crypto_aead *tfm,
         |     ^
>> drivers/crypto/ti/dthev2-aes.c:846:9: error: call to undeclared function 'crypto_sync_aead_setauthsize'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     846 |         return crypto_sync_aead_setauthsize(ctx->aead_fb, authsize);
         |                ^
   drivers/crypto/ti/dthev2-aes.c:846:9: note: did you mean 'crypto_aead_setauthsize'?
   include/crypto/aead.h:332:5: note: 'crypto_aead_setauthsize' declared here
     332 | int crypto_aead_setauthsize(struct crypto_aead *tfm, unsigned int authsize);
         |     ^
>> drivers/crypto/ti/dthev2-aes.c:854:2: error: call to undeclared function 'SYNC_AEAD_REQUEST_ON_STACK'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     854 |         SYNC_AEAD_REQUEST_ON_STACK(subreq, ctx->aead_fb);
         |         ^
>> drivers/crypto/ti/dthev2-aes.c:854:29: error: use of undeclared identifier 'subreq'
     854 |         SYNC_AEAD_REQUEST_ON_STACK(subreq, ctx->aead_fb);
         |                                    ^~~~~~
   drivers/crypto/ti/dthev2-aes.c:856:28: error: use of undeclared identifier 'subreq'
     856 |         aead_request_set_callback(subreq, req->base.flags,
         |                                   ^~~~~~
   drivers/crypto/ti/dthev2-aes.c:858:25: error: use of undeclared identifier 'subreq'
     858 |         aead_request_set_crypt(subreq, req->src, req->dst, req->cryptlen, req->iv);
         |                                ^~~~~~
   drivers/crypto/ti/dthev2-aes.c:859:22: error: use of undeclared identifier 'subreq'
     859 |         aead_request_set_ad(subreq, req->assoclen);
         |                             ^~~~~~
   drivers/crypto/ti/dthev2-aes.c:861:41: error: use of undeclared identifier 'subreq'
     861 |         return rctx->enc ? crypto_aead_encrypt(subreq) :
         |                                                ^~~~~~
   drivers/crypto/ti/dthev2-aes.c:862:23: error: use of undeclared identifier 'subreq'
     862 |                 crypto_aead_decrypt(subreq);
         |                                     ^~~~~~
   14 errors generated.


vim +/crypto_alloc_sync_aead +573 drivers/crypto/ti/dthev2-aes.c

   563	
   564	static int dthe_aead_init_tfm(struct crypto_aead *tfm)
   565	{
   566		struct dthe_tfm_ctx *ctx = crypto_aead_ctx(tfm);
   567		struct dthe_data *dev_data = dthe_get_dev(ctx);
   568	
   569		ctx->dev_data = dev_data;
   570	
   571		const char *alg_name = crypto_tfm_alg_name(crypto_aead_tfm(tfm));
   572	
 > 573		ctx->aead_fb = crypto_alloc_sync_aead(alg_name, 0,
   574						      CRYPTO_ALG_NEED_FALLBACK);
   575		if (IS_ERR(ctx->aead_fb)) {
   576			dev_err(dev_data->dev, "fallback driver %s couldn't be loaded\n",
   577				alg_name);
   578			return PTR_ERR(ctx->aead_fb);
   579		}
   580	
   581		return 0;
   582	}
   583	
   584	static void dthe_aead_exit_tfm(struct crypto_aead *tfm)
   585	{
   586		struct dthe_tfm_ctx *ctx = crypto_aead_ctx(tfm);
   587	
 > 588		crypto_free_sync_aead(ctx->aead_fb);
   589	}
   590	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v6 3/4] crypto: ti - Add support for AES-GCM in DTHEv2 driver
       [not found] <20251111112137.976121-4-t-pratham@ti.com>
  2025-11-14  6:47 ` [PATCH v6 3/4] crypto: ti - Add support for AES-GCM in DTHEv2 driver kernel test robot
@ 2025-11-14  7:52 ` kernel test robot
  2025-11-14  9:36 ` kernel test robot
  2 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2025-11-14  7:52 UTC (permalink / raw)
  To: T Pratham, Herbert Xu, David S. Miller
  Cc: oe-kbuild-all, netdev, Manorit Chawdhry, Kamlesh Gurudasani,
	Shiva Tripathi, Kavitha Malarvizhi, Vishal Mahaveer, linux-crypto,
	linux-kernel

Hi Pratham,

kernel test robot noticed the following build warnings:

[auto build test WARNING on herbert-crypto-2.6/master]
[also build test WARNING on linus/master v6.18-rc5]
[cannot apply to herbert-cryptodev-2.6/master next-20251113]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/T-Pratham/crypto-ti-Add-support-for-AES-XTS-in-DTHEv2-driver/20251111-192827
base:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git master
patch link:    https://lore.kernel.org/r/20251111112137.976121-4-t-pratham%40ti.com
patch subject: [PATCH v6 3/4] crypto: ti - Add support for AES-GCM in DTHEv2 driver
config: s390-randconfig-002-20251114 (https://download.01.org/0day-ci/archive/20251114/202511141528.zox1IMuF-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 11.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251114/202511141528.zox1IMuF-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202511141528.zox1IMuF-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/crypto/ti/dthev2-aes.c: In function 'dthe_aead_init_tfm':
   drivers/crypto/ti/dthev2-aes.c:573:24: error: implicit declaration of function 'crypto_alloc_sync_aead'; did you mean 'crypto_alloc_aead'? [-Werror=implicit-function-declaration]
     573 |         ctx->aead_fb = crypto_alloc_sync_aead(alg_name, 0,
         |                        ^~~~~~~~~~~~~~~~~~~~~~
         |                        crypto_alloc_aead
>> drivers/crypto/ti/dthev2-aes.c:573:22: warning: assignment to 'struct crypto_sync_aead *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
     573 |         ctx->aead_fb = crypto_alloc_sync_aead(alg_name, 0,
         |                      ^
   drivers/crypto/ti/dthev2-aes.c: In function 'dthe_aead_exit_tfm':
   drivers/crypto/ti/dthev2-aes.c:588:9: error: implicit declaration of function 'crypto_free_sync_aead'; did you mean 'crypto_free_aead'? [-Werror=implicit-function-declaration]
     588 |         crypto_free_sync_aead(ctx->aead_fb);
         |         ^~~~~~~~~~~~~~~~~~~~~
         |         crypto_free_aead
   drivers/crypto/ti/dthev2-aes.c: In function 'dthe_aead_setkey':
   drivers/crypto/ti/dthev2-aes.c:831:9: error: implicit declaration of function 'crypto_sync_aead_clear_flags'; did you mean 'crypto_aead_clear_flags'? [-Werror=implicit-function-declaration]
     831 |         crypto_sync_aead_clear_flags(ctx->aead_fb, CRYPTO_TFM_REQ_MASK);
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
         |         crypto_aead_clear_flags
   drivers/crypto/ti/dthev2-aes.c:832:9: error: implicit declaration of function 'crypto_sync_aead_set_flags'; did you mean 'crypto_aead_set_flags'? [-Werror=implicit-function-declaration]
     832 |         crypto_sync_aead_set_flags(ctx->aead_fb,
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~
         |         crypto_aead_set_flags
   drivers/crypto/ti/dthev2-aes.c:836:16: error: implicit declaration of function 'crypto_sync_aead_setkey'; did you mean 'crypto_aead_setkey'? [-Werror=implicit-function-declaration]
     836 |         return crypto_sync_aead_setkey(ctx->aead_fb, key, keylen);
         |                ^~~~~~~~~~~~~~~~~~~~~~~
         |                crypto_aead_setkey
   drivers/crypto/ti/dthev2-aes.c: In function 'dthe_aead_setauthsize':
   drivers/crypto/ti/dthev2-aes.c:846:16: error: implicit declaration of function 'crypto_sync_aead_setauthsize'; did you mean 'crypto_aead_setauthsize'? [-Werror=implicit-function-declaration]
     846 |         return crypto_sync_aead_setauthsize(ctx->aead_fb, authsize);
         |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
         |                crypto_aead_setauthsize
   drivers/crypto/ti/dthev2-aes.c: In function 'dthe_aead_do_fallback':
   drivers/crypto/ti/dthev2-aes.c:854:9: error: implicit declaration of function 'SYNC_AEAD_REQUEST_ON_STACK'; did you mean 'SYNC_SKCIPHER_REQUEST_ON_STACK'? [-Werror=implicit-function-declaration]
     854 |         SYNC_AEAD_REQUEST_ON_STACK(subreq, ctx->aead_fb);
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~
         |         SYNC_SKCIPHER_REQUEST_ON_STACK
   drivers/crypto/ti/dthev2-aes.c:854:36: error: 'subreq' undeclared (first use in this function)
     854 |         SYNC_AEAD_REQUEST_ON_STACK(subreq, ctx->aead_fb);
         |                                    ^~~~~~
   drivers/crypto/ti/dthev2-aes.c:854:36: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/crypto/ti/dthev2-aes.c:863:1: warning: control reaches end of non-void function [-Wreturn-type]
     863 | }
         | ^
   cc1: some warnings being treated as errors


vim +573 drivers/crypto/ti/dthev2-aes.c

   563	
   564	static int dthe_aead_init_tfm(struct crypto_aead *tfm)
   565	{
   566		struct dthe_tfm_ctx *ctx = crypto_aead_ctx(tfm);
   567		struct dthe_data *dev_data = dthe_get_dev(ctx);
   568	
   569		ctx->dev_data = dev_data;
   570	
   571		const char *alg_name = crypto_tfm_alg_name(crypto_aead_tfm(tfm));
   572	
 > 573		ctx->aead_fb = crypto_alloc_sync_aead(alg_name, 0,
   574						      CRYPTO_ALG_NEED_FALLBACK);
   575		if (IS_ERR(ctx->aead_fb)) {
   576			dev_err(dev_data->dev, "fallback driver %s couldn't be loaded\n",
   577				alg_name);
   578			return PTR_ERR(ctx->aead_fb);
   579		}
   580	
   581		return 0;
   582	}
   583	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v6 3/4] crypto: ti - Add support for AES-GCM in DTHEv2 driver
  2025-11-14  6:47 ` [PATCH v6 3/4] crypto: ti - Add support for AES-GCM in DTHEv2 driver kernel test robot
@ 2025-11-14  9:04   ` T Pratham
  0 siblings, 0 replies; 4+ messages in thread
From: T Pratham @ 2025-11-14  9:04 UTC (permalink / raw)
  To: kernel test robot, Herbert Xu, David S. Miller
  Cc: llvm, oe-kbuild-all, netdev, Manorit Chawdhry, Kamlesh Gurudasani,
	Shiva Tripathi, Kavitha Malarvizhi, Vishal Mahaveer, linux-crypto,
	linux-kernel

On 14/11/25 12:17, kernel test robot wrote:
> Hi Pratham,
> 
> kernel test robot noticed the following build errors:
> 
> [auto build test ERROR on herbert-crypto-2.6/master]
> [also build test ERROR on linus/master v6.18-rc5]

Applied to incorrect tree. The patch depends on [1] which has been
merged in cryptodev-2.6/master

> [cannot apply to herbert-cryptodev-2.6/master next-20251113]

This is maybe due to the first patch in the series, which was already
present in the tree?

> 
> All errors (new ones prefixed by >>):
> 
>>> drivers/crypto/ti/dthev2-aes.c:573:17: error: call to undeclared function 'crypto_alloc_sync_aead'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
>      573 |         ctx->aead_fb = crypto_alloc_sync_aead(alg_name, 0,
>          |                        ^
>    drivers/crypto/ti/dthev2-aes.c:573:17: note: did you mean 'crypto_alloc_aead'?
>    include/crypto/aead.h:181:21: note: 'crypto_alloc_aead' declared here
>      181 | struct crypto_aead *crypto_alloc_aead(const char *alg_name, u32 type, u32 mask);
>          |                     ^
>>> drivers/crypto/ti/dthev2-aes.c:573:15: error: incompatible integer to pointer conversion assigning to 'struct crypto_sync_aead *' from 'int' [-Wint-conversion]
>      573 |         ctx->aead_fb = crypto_alloc_sync_aead(alg_name, 0,
>          |                      ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>      574 |                                               CRYPTO_ALG_NEED_FALLBACK);
>          |                                               ~~~~~~~~~~~~~~~~~~~~~~~~~
>>> drivers/crypto/ti/dthev2-aes.c:588:2: error: call to undeclared function 'crypto_free_sync_aead'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
>      588 |         crypto_free_sync_aead(ctx->aead_fb);
>          |         ^
>    drivers/crypto/ti/dthev2-aes.c:588:2: note: did you mean 'crypto_free_aead'?
>    include/crypto/aead.h:194:20: note: 'crypto_free_aead' declared here
>      194 | static inline void crypto_free_aead(struct crypto_aead *tfm)
>          |                    ^
>>> drivers/crypto/ti/dthev2-aes.c:831:2: error: call to undeclared function 'crypto_sync_aead_clear_flags'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
>      831 |         crypto_sync_aead_clear_flags(ctx->aead_fb, CRYPTO_TFM_REQ_MASK);
>          |         ^
>    drivers/crypto/ti/dthev2-aes.c:831:2: note: did you mean 'crypto_aead_clear_flags'?
>    include/crypto/aead.h:298:20: note: 'crypto_aead_clear_flags' declared here
>      298 | static inline void crypto_aead_clear_flags(struct crypto_aead *tfm, u32 flags)
>          |                    ^
>>> drivers/crypto/ti/dthev2-aes.c:832:2: error: call to undeclared function 'crypto_sync_aead_set_flags'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
>      832 |         crypto_sync_aead_set_flags(ctx->aead_fb,
>          |         ^
>>> drivers/crypto/ti/dthev2-aes.c:836:9: error: call to undeclared function 'crypto_sync_aead_setkey'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
>      836 |         return crypto_sync_aead_setkey(ctx->aead_fb, key, keylen);
>          |                ^
>    drivers/crypto/ti/dthev2-aes.c:836:9: note: did you mean 'crypto_aead_setkey'?
>    include/crypto/aead.h:319:5: note: 'crypto_aead_setkey' declared here
>      319 | int crypto_aead_setkey(struct crypto_aead *tfm,
>          |     ^
>>> drivers/crypto/ti/dthev2-aes.c:846:9: error: call to undeclared function 'crypto_sync_aead_setauthsize'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
>      846 |         return crypto_sync_aead_setauthsize(ctx->aead_fb, authsize);
>          |                ^
>    drivers/crypto/ti/dthev2-aes.c:846:9: note: did you mean 'crypto_aead_setauthsize'?
>    include/crypto/aead.h:332:5: note: 'crypto_aead_setauthsize' declared here
>      332 | int crypto_aead_setauthsize(struct crypto_aead *tfm, unsigned int authsize);
>          |     ^
>>> drivers/crypto/ti/dthev2-aes.c:854:2: error: call to undeclared function 'SYNC_AEAD_REQUEST_ON_STACK'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
>      854 |         SYNC_AEAD_REQUEST_ON_STACK(subreq, ctx->aead_fb);
>          |         ^
>>> drivers/crypto/ti/dthev2-aes.c:854:29: error: use of undeclared identifier 'subreq'
>      854 |         SYNC_AEAD_REQUEST_ON_STACK(subreq, ctx->aead_fb);
>          |                                    ^~~~~~
>    drivers/crypto/ti/dthev2-aes.c:856:28: error: use of undeclared identifier 'subreq'
>      856 |         aead_request_set_callback(subreq, req->base.flags,
>          |                                   ^~~~~~
>    drivers/crypto/ti/dthev2-aes.c:858:25: error: use of undeclared identifier 'subreq'
>      858 |         aead_request_set_crypt(subreq, req->src, req->dst, req->cryptlen, req->iv);
>          |                                ^~~~~~
>    drivers/crypto/ti/dthev2-aes.c:859:22: error: use of undeclared identifier 'subreq'
>      859 |         aead_request_set_ad(subreq, req->assoclen);
>          |                             ^~~~~~
>    drivers/crypto/ti/dthev2-aes.c:861:41: error: use of undeclared identifier 'subreq'
>      861 |         return rctx->enc ? crypto_aead_encrypt(subreq) :
>          |                                                ^~~~~~
>    drivers/crypto/ti/dthev2-aes.c:862:23: error: use of undeclared identifier 'subreq'
>      862 |                 crypto_aead_decrypt(subreq);
>          |                                     ^~~~~~
>    14 errors generated.
> 
All the errors are due to the patch [1] not being present in the applied
tree. It should be fine when applied to cryptodev-2.6/master.

[1]:
https://lore.kernel.org/linux-crypto/20251022171902.724369-2-t-pratham@ti.com/
-- 
Regards
T Pratham <t-pratham@ti.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v6 3/4] crypto: ti - Add support for AES-GCM in DTHEv2 driver
       [not found] <20251111112137.976121-4-t-pratham@ti.com>
  2025-11-14  6:47 ` [PATCH v6 3/4] crypto: ti - Add support for AES-GCM in DTHEv2 driver kernel test robot
  2025-11-14  7:52 ` kernel test robot
@ 2025-11-14  9:36 ` kernel test robot
  2 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2025-11-14  9:36 UTC (permalink / raw)
  To: T Pratham, Herbert Xu, David S. Miller
  Cc: oe-kbuild-all, netdev, Manorit Chawdhry, Kamlesh Gurudasani,
	Shiva Tripathi, Kavitha Malarvizhi, Vishal Mahaveer, linux-crypto,
	linux-kernel

Hi Pratham,

kernel test robot noticed the following build errors:

[auto build test ERROR on herbert-crypto-2.6/master]
[also build test ERROR on linus/master v6.18-rc5]
[cannot apply to herbert-cryptodev-2.6/master next-20251114]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/T-Pratham/crypto-ti-Add-support-for-AES-XTS-in-DTHEv2-driver/20251111-192827
base:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git master
patch link:    https://lore.kernel.org/r/20251111112137.976121-4-t-pratham%40ti.com
patch subject: [PATCH v6 3/4] crypto: ti - Add support for AES-GCM in DTHEv2 driver
config: s390-randconfig-002-20251114 (https://download.01.org/0day-ci/archive/20251114/202511141721.73B0pu4H-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 11.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251114/202511141721.73B0pu4H-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202511141721.73B0pu4H-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/crypto/ti/dthev2-aes.c: In function 'dthe_aead_init_tfm':
>> drivers/crypto/ti/dthev2-aes.c:573:24: error: implicit declaration of function 'crypto_alloc_sync_aead'; did you mean 'crypto_alloc_aead'? [-Werror=implicit-function-declaration]
     573 |         ctx->aead_fb = crypto_alloc_sync_aead(alg_name, 0,
         |                        ^~~~~~~~~~~~~~~~~~~~~~
         |                        crypto_alloc_aead
   drivers/crypto/ti/dthev2-aes.c:573:22: warning: assignment to 'struct crypto_sync_aead *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
     573 |         ctx->aead_fb = crypto_alloc_sync_aead(alg_name, 0,
         |                      ^
   drivers/crypto/ti/dthev2-aes.c: In function 'dthe_aead_exit_tfm':
>> drivers/crypto/ti/dthev2-aes.c:588:9: error: implicit declaration of function 'crypto_free_sync_aead'; did you mean 'crypto_free_aead'? [-Werror=implicit-function-declaration]
     588 |         crypto_free_sync_aead(ctx->aead_fb);
         |         ^~~~~~~~~~~~~~~~~~~~~
         |         crypto_free_aead
   drivers/crypto/ti/dthev2-aes.c: In function 'dthe_aead_setkey':
>> drivers/crypto/ti/dthev2-aes.c:831:9: error: implicit declaration of function 'crypto_sync_aead_clear_flags'; did you mean 'crypto_aead_clear_flags'? [-Werror=implicit-function-declaration]
     831 |         crypto_sync_aead_clear_flags(ctx->aead_fb, CRYPTO_TFM_REQ_MASK);
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
         |         crypto_aead_clear_flags
>> drivers/crypto/ti/dthev2-aes.c:832:9: error: implicit declaration of function 'crypto_sync_aead_set_flags'; did you mean 'crypto_aead_set_flags'? [-Werror=implicit-function-declaration]
     832 |         crypto_sync_aead_set_flags(ctx->aead_fb,
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~
         |         crypto_aead_set_flags
>> drivers/crypto/ti/dthev2-aes.c:836:16: error: implicit declaration of function 'crypto_sync_aead_setkey'; did you mean 'crypto_aead_setkey'? [-Werror=implicit-function-declaration]
     836 |         return crypto_sync_aead_setkey(ctx->aead_fb, key, keylen);
         |                ^~~~~~~~~~~~~~~~~~~~~~~
         |                crypto_aead_setkey
   drivers/crypto/ti/dthev2-aes.c: In function 'dthe_aead_setauthsize':
>> drivers/crypto/ti/dthev2-aes.c:846:16: error: implicit declaration of function 'crypto_sync_aead_setauthsize'; did you mean 'crypto_aead_setauthsize'? [-Werror=implicit-function-declaration]
     846 |         return crypto_sync_aead_setauthsize(ctx->aead_fb, authsize);
         |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
         |                crypto_aead_setauthsize
   drivers/crypto/ti/dthev2-aes.c: In function 'dthe_aead_do_fallback':
>> drivers/crypto/ti/dthev2-aes.c:854:9: error: implicit declaration of function 'SYNC_AEAD_REQUEST_ON_STACK'; did you mean 'SYNC_SKCIPHER_REQUEST_ON_STACK'? [-Werror=implicit-function-declaration]
     854 |         SYNC_AEAD_REQUEST_ON_STACK(subreq, ctx->aead_fb);
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~
         |         SYNC_SKCIPHER_REQUEST_ON_STACK
>> drivers/crypto/ti/dthev2-aes.c:854:36: error: 'subreq' undeclared (first use in this function)
     854 |         SYNC_AEAD_REQUEST_ON_STACK(subreq, ctx->aead_fb);
         |                                    ^~~~~~
   drivers/crypto/ti/dthev2-aes.c:854:36: note: each undeclared identifier is reported only once for each function it appears in
   drivers/crypto/ti/dthev2-aes.c:863:1: warning: control reaches end of non-void function [-Wreturn-type]
     863 | }
         | ^
   cc1: some warnings being treated as errors


vim +573 drivers/crypto/ti/dthev2-aes.c

   563	
   564	static int dthe_aead_init_tfm(struct crypto_aead *tfm)
   565	{
   566		struct dthe_tfm_ctx *ctx = crypto_aead_ctx(tfm);
   567		struct dthe_data *dev_data = dthe_get_dev(ctx);
   568	
   569		ctx->dev_data = dev_data;
   570	
   571		const char *alg_name = crypto_tfm_alg_name(crypto_aead_tfm(tfm));
   572	
 > 573		ctx->aead_fb = crypto_alloc_sync_aead(alg_name, 0,
   574						      CRYPTO_ALG_NEED_FALLBACK);
   575		if (IS_ERR(ctx->aead_fb)) {
   576			dev_err(dev_data->dev, "fallback driver %s couldn't be loaded\n",
   577				alg_name);
   578			return PTR_ERR(ctx->aead_fb);
   579		}
   580	
   581		return 0;
   582	}
   583	
   584	static void dthe_aead_exit_tfm(struct crypto_aead *tfm)
   585	{
   586		struct dthe_tfm_ctx *ctx = crypto_aead_ctx(tfm);
   587	
 > 588		crypto_free_sync_aead(ctx->aead_fb);
   589	}
   590	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-11-14  9:37 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20251111112137.976121-4-t-pratham@ti.com>
2025-11-14  6:47 ` [PATCH v6 3/4] crypto: ti - Add support for AES-GCM in DTHEv2 driver kernel test robot
2025-11-14  9:04   ` T Pratham
2025-11-14  7:52 ` kernel test robot
2025-11-14  9:36 ` kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).