* [PATCH] fix 3com/3c515 build error
@ 2025-11-14 16:55 René Rebe
2025-11-18 0:28 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: René Rebe @ 2025-11-14 16:55 UTC (permalink / raw)
To: netdev
3c515 stopped building for me some months ago, fix:
drivers/net/ethernet/3com/3c515.o: error: objtool: cleanup_module(): Magic init_module() function name is deprecated, use module_init(fn) instead
make[6]: *** [scripts/Makefile.build:203: drivers/net/ethernet/3com/3c515.o] Error 255
Signed-off-by: René Rebe <rene@exactco.de>
--- a/drivers/net/ethernet/3com/3c515.c 2025-05-26 19:16:50.055582886 +0200
+++ b/drivers/net/ethernet/3com/3c515.c 2025-05-26 19:27:45.400746652 +0200
@@ -1549,7 +1549,7 @@
#ifdef MODULE
-void cleanup_module(void)
+static void corkscrew_cleanup_module(void)
{
while (!list_empty(&root_corkscrew_dev)) {
struct net_device *dev;
@@ -1563,4 +1563,5 @@
free_netdev(dev);
}
}
+module_exit(corkscrew_cleanup_module);
#endif /* MODULE */
--
René Rebe, ExactCODE GmbH, Lietzenburger Str. 42, DE-10789 Berlin
https://exactco.de | https://t2linux.com | https://rene.rebe.de
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] fix 3com/3c515 build error
2025-11-14 16:55 [PATCH] fix 3com/3c515 build error René Rebe
@ 2025-11-18 0:28 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2025-11-18 0:28 UTC (permalink / raw)
To: René Rebe; +Cc: netdev
On Fri, 14 Nov 2025 17:55:43 +0100 (CET) René Rebe wrote:
> 3c515 stopped building for me some months ago, fix:
>
> drivers/net/ethernet/3com/3c515.o: error: objtool: cleanup_module(): Magic init_module() function name is deprecated, use module_init(fn) instead
> make[6]: *** [scripts/Makefile.build:203: drivers/net/ethernet/3com/3c515.o] Error 255
This patch is missing the usual markings, could you please re-format
it with git format-patch? Or resend it using b4?
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-11-18 0:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-14 16:55 [PATCH] fix 3com/3c515 build error René Rebe
2025-11-18 0:28 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).