From: Jakub Kicinski <kuba@kernel.org>
To: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Wen Gu <guwen@linux.alibaba.com>,
Philo Lu <lulie@linux.alibaba.com>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Vadim Fedorenko <vadim.fedorenko@linux.dev>,
Dong Yibo <dong100@mucse.com>,
Lukas Bulwahn <lukas.bulwahn@redhat.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Vivian Wang <wangruikang@iscas.ac.cn>,
MD Danish Anwar <danishanwar@ti.com>,
Dust Li <dust.li@linux.alibaba.com>
Subject: Re: [PATCH net-next v14 4/5] eea: create/destroy rx,tx queues for netdevice open and stop
Date: Mon, 17 Nov 2025 20:18:20 -0800 [thread overview]
Message-ID: <20251117201820.0acd0c5a@kernel.org> (raw)
In-Reply-To: <20251114061506.45978-5-xuanzhuo@linux.alibaba.com>
On Fri, 14 Nov 2025 14:15:05 +0800 Xuan Zhuo wrote:
> +static int eea_netdev_open(struct net_device *netdev)
> +{
> + struct eea_net *enet = netdev_priv(netdev);
> + struct eea_net_init_ctx ctx;
> + int err;
> +
> + if (enet->link_err) {
> + netdev_err(netdev, "netdev open err, because link error: %d\n",
> + enet->link_err);
> + return -EBUSY;
> + }
> +
> + enet_init_ctx(enet, &ctx);
> +
> + err = eea_alloc_rxtx_q_mem(&ctx);
> + if (err)
> + return err;
> +
> + enet_bind_new_q_and_cfg(enet, &ctx);
> +
> + err = eea_active_ring_and_irq(enet);
> + if (err)
> + return err;
> +
> + return eea_start_rxtx(netdev);
Looks like this is missing teardown in case eea_start_rxtx() failed
--
pw-bot: cr
next prev parent reply other threads:[~2025-11-18 4:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-14 6:15 [PATCH net-next v14 0/5] eea: Add basic driver framework for Alibaba Elastic Ethernet Adaptor Xuan Zhuo
2025-11-14 6:15 ` [PATCH net-next v14 1/5] eea: introduce PCI framework Xuan Zhuo
2025-11-18 4:18 ` Jakub Kicinski
2025-11-14 6:15 ` [PATCH net-next v14 2/5] eea: introduce ring and descriptor structures Xuan Zhuo
2025-11-14 6:15 ` [PATCH net-next v14 3/5] eea: probe the netdevice and create adminq Xuan Zhuo
2025-11-14 6:15 ` [PATCH net-next v14 4/5] eea: create/destroy rx,tx queues for netdevice open and stop Xuan Zhuo
2025-11-18 4:18 ` Jakub Kicinski [this message]
2025-11-14 6:15 ` [PATCH net-next v14 5/5] eea: introduce ethtool support Xuan Zhuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251117201820.0acd0c5a@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=dong100@mucse.com \
--cc=dust.li@linux.alibaba.com \
--cc=edumazet@google.com \
--cc=geert+renesas@glider.be \
--cc=guwen@linux.alibaba.com \
--cc=lorenzo@kernel.org \
--cc=lukas.bulwahn@redhat.com \
--cc=lulie@linux.alibaba.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vadim.fedorenko@linux.dev \
--cc=wangruikang@iscas.ac.cn \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).