From: Stephen Hemminger <stephen@networkplumber.org>
To: Daniel Zahka <daniel.zahka@gmail.com>
Cc: Jiri Pirko <jiri@resnulli.us>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Donald Hunter <donald.hunter@gmail.com>,
David Ahern <dsahern@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH iproute2-next 1/2] devlink: Pull the value printing logic out of pr_out_param_value()
Date: Tue, 18 Nov 2025 08:02:39 -0800 [thread overview]
Message-ID: <20251118080239.405507d6@phoenix.local> (raw)
In-Reply-To: <20251117-param-defaults-v1-1-c99604175d09@gmail.com>
On Mon, 17 Nov 2025 16:40:02 -0800
Daniel Zahka <daniel.zahka@gmail.com> wrote:
> - print_uint(PRINT_ANY, "value", " value %u",
> + snprintf(format_str, sizeof(format_str), " %s %%u", label);
> + print_uint(PRINT_ANY, label, format_str,
The problem with generating format strings is that it makes it difficult to
impossible to use any of the compiler format validation flags.
next prev parent reply other threads:[~2025-11-18 16:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-18 0:40 [PATCH iproute2-next 0/2] devlink: support default flag attr for param-get and param-set commands Daniel Zahka
2025-11-18 0:40 ` [PATCH iproute2-next 1/2] devlink: Pull the value printing logic out of pr_out_param_value() Daniel Zahka
2025-11-18 16:02 ` Stephen Hemminger [this message]
2025-11-18 0:40 ` [PATCH iproute2-next 2/2] devlink: support displaying and resetting to default params Daniel Zahka
2025-11-18 0:46 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251118080239.405507d6@phoenix.local \
--to=stephen@networkplumber.org \
--cc=daniel.zahka@gmail.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=dsahern@kernel.org \
--cc=horms@kernel.org \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).