From: Daniel Jurgens <danielj@nvidia.com>
To: <netdev@vger.kernel.org>, <mst@redhat.com>, <jasowang@redhat.com>,
<pabeni@redhat.com>
Cc: <virtualization@lists.linux.dev>, <parav@nvidia.com>,
<shshitrit@nvidia.com>, <yohadt@nvidia.com>,
<xuanzhuo@linux.alibaba.com>, <eperezma@redhat.com>,
<jgg@ziepe.ca>, <kevin.tian@intel.com>, <kuba@kernel.org>,
<andrew+netdev@lunn.ch>, <edumazet@google.com>,
"Daniel Jurgens" <danielj@nvidia.com>
Subject: [PATCH net-next v11 01/12] virtio_pci: Remove supported_cap size build assert
Date: Tue, 18 Nov 2025 08:38:51 -0600 [thread overview]
Message-ID: <20251118143903.958844-2-danielj@nvidia.com> (raw)
In-Reply-To: <20251118143903.958844-1-danielj@nvidia.com>
The cap ID list can be more than 64 bits. Remove the build assert. Also
remove caching of the supported caps, it wasn't used.
Signed-off-by: Daniel Jurgens <danielj@nvidia.com>
Reviewed-by: Parav Pandit <parav@nvidia.com>
Reviewed-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
---
v4: New patch for V4
v5:
- support_caps -> supported_caps (Alok Tiwari)
- removed unused variable (test robot)
---
drivers/virtio/virtio_pci_common.h | 1 -
drivers/virtio/virtio_pci_modern.c | 8 +-------
2 files changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/virtio/virtio_pci_common.h b/drivers/virtio/virtio_pci_common.h
index 8cd01de27baf..fc26e035e7a6 100644
--- a/drivers/virtio/virtio_pci_common.h
+++ b/drivers/virtio/virtio_pci_common.h
@@ -48,7 +48,6 @@ struct virtio_pci_admin_vq {
/* Protects virtqueue access. */
spinlock_t lock;
u64 supported_cmds;
- u64 supported_caps;
u8 max_dev_parts_objects;
struct ida dev_parts_ida;
/* Name of the admin queue: avq.$vq_index. */
diff --git a/drivers/virtio/virtio_pci_modern.c b/drivers/virtio/virtio_pci_modern.c
index dd0e65f71d41..ff11de5b3d69 100644
--- a/drivers/virtio/virtio_pci_modern.c
+++ b/drivers/virtio/virtio_pci_modern.c
@@ -304,7 +304,6 @@ virtio_pci_admin_cmd_dev_parts_objects_enable(struct virtio_device *virtio_dev)
static void virtio_pci_admin_cmd_cap_init(struct virtio_device *virtio_dev)
{
- struct virtio_pci_device *vp_dev = to_vp_device(virtio_dev);
struct virtio_admin_cmd_query_cap_id_result *data;
struct virtio_admin_cmd cmd = {};
struct scatterlist result_sg;
@@ -323,12 +322,7 @@ static void virtio_pci_admin_cmd_cap_init(struct virtio_device *virtio_dev)
if (ret)
goto end;
- /* Max number of caps fits into a single u64 */
- BUILD_BUG_ON(sizeof(data->supported_caps) > sizeof(u64));
-
- vp_dev->admin_vq.supported_caps = le64_to_cpu(data->supported_caps[0]);
-
- if (!(vp_dev->admin_vq.supported_caps & (1 << VIRTIO_DEV_PARTS_CAP)))
+ if (!(le64_to_cpu(data->supported_caps[0]) & (1 << VIRTIO_DEV_PARTS_CAP)))
goto end;
virtio_pci_admin_cmd_dev_parts_objects_enable(virtio_dev);
--
2.50.1
next prev parent reply other threads:[~2025-11-18 14:39 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-18 14:38 [PATCH net-next v11 00/12] virtio_net: Add ethtool flow rules support Daniel Jurgens
2025-11-18 14:38 ` Daniel Jurgens [this message]
2025-11-19 7:38 ` [PATCH net-next v11 01/12] virtio_pci: Remove supported_cap size build assert Michael S. Tsirkin
2025-11-19 14:23 ` Dan Jurgens
2025-11-18 14:38 ` [PATCH net-next v11 02/12] virtio: Add config_op for admin commands Daniel Jurgens
2025-11-19 7:36 ` Michael S. Tsirkin
2025-11-18 14:38 ` [PATCH net-next v11 03/12] virtio: Expose generic device capability operations Daniel Jurgens
2025-11-18 21:42 ` Michael S. Tsirkin
2025-11-19 3:27 ` Dan Jurgens
2025-11-18 14:38 ` [PATCH net-next v11 04/12] virtio: Expose object create and destroy API Daniel Jurgens
2025-11-18 22:14 ` Michael S. Tsirkin
2025-11-19 3:29 ` Dan Jurgens
2025-11-19 6:39 ` Michael S. Tsirkin
2025-11-19 7:21 ` Dan Jurgens
2025-11-18 14:38 ` [PATCH net-next v11 05/12] virtio_net: Query and set flow filter caps Daniel Jurgens
2025-11-18 22:06 ` Michael S. Tsirkin
2025-11-19 5:57 ` Dan Jurgens
2025-11-18 23:03 ` Michael S. Tsirkin
2025-11-19 4:27 ` Dan Jurgens
2025-11-19 7:53 ` Michael S. Tsirkin
2025-11-19 14:47 ` Dan Jurgens
2025-11-19 7:55 ` Michael S. Tsirkin
2025-11-18 14:38 ` [PATCH net-next v11 06/12] virtio_net: Create a FF group for ethtool steering Daniel Jurgens
2025-11-19 9:36 ` Michael S. Tsirkin
2025-11-19 17:14 ` Dan Jurgens
2025-11-18 14:38 ` [PATCH net-next v11 07/12] virtio_net: Implement layer 2 ethtool flow rules Daniel Jurgens
2025-11-18 19:01 ` Michael S. Tsirkin
2025-11-19 6:07 ` Dan Jurgens
2025-11-19 9:20 ` Michael S. Tsirkin
2025-11-19 9:26 ` Michael S. Tsirkin
2025-11-19 16:51 ` Dan Jurgens
2025-11-18 14:38 ` [PATCH net-next v11 08/12] virtio_net: Use existing classifier if possible Daniel Jurgens
2025-11-18 21:55 ` Michael S. Tsirkin
2025-11-19 6:26 ` Dan Jurgens
2025-11-19 6:35 ` Michael S. Tsirkin
2025-11-19 7:18 ` Dan Jurgens
2025-11-19 7:23 ` Michael S. Tsirkin
2025-11-19 7:33 ` Dan Jurgens
2025-11-19 7:41 ` Michael S. Tsirkin
2025-11-19 15:45 ` Dan Jurgens
2025-11-19 15:58 ` Michael S. Tsirkin
2025-11-19 7:42 ` Michael S. Tsirkin
2025-11-19 9:01 ` Michael S. Tsirkin
2025-11-18 14:38 ` [PATCH net-next v11 09/12] virtio_net: Implement IPv4 ethtool flow rules Daniel Jurgens
2025-11-18 21:31 ` Michael S. Tsirkin
2025-11-19 7:03 ` Dan Jurgens
2025-11-19 7:06 ` Michael S. Tsirkin
2025-11-19 7:17 ` Dan Jurgens
2025-11-19 7:20 ` Michael S. Tsirkin
2025-11-19 9:18 ` Michael S. Tsirkin
2025-11-19 16:33 ` Dan Jurgens
2025-11-19 16:51 ` Michael S. Tsirkin
2025-11-19 16:59 ` Dan Jurgens
2025-11-18 14:39 ` [PATCH net-next v11 10/12] virtio_net: Add support for IPv6 ethtool steering Daniel Jurgens
2025-11-18 21:45 ` Michael S. Tsirkin
2025-11-19 7:35 ` Dan Jurgens
2025-11-19 7:44 ` Michael S. Tsirkin
2025-11-18 21:48 ` Michael S. Tsirkin
2025-11-19 16:04 ` Dan Jurgens
2025-11-18 14:39 ` [PATCH net-next v11 11/12] virtio_net: Add support for TCP and UDP ethtool rules Daniel Jurgens
2025-11-19 9:14 ` Michael S. Tsirkin
2025-11-19 16:07 ` Dan Jurgens
2025-11-18 14:39 ` [PATCH net-next v11 12/12] virtio_net: Add get ethtool flow rules ops Daniel Jurgens
2025-11-18 18:49 ` Michael S. Tsirkin
2025-11-19 16:24 ` Dan Jurgens
2025-11-18 22:39 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251118143903.958844-2-danielj@nvidia.com \
--to=danielj@nvidia.com \
--cc=andrew+netdev@lunn.ch \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=jgg@ziepe.ca \
--cc=kevin.tian@intel.com \
--cc=kuba@kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=parav@nvidia.com \
--cc=shshitrit@nvidia.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
--cc=yohadt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).