* [PATCH V2] net: 3com/3c515 fix build error
@ 2025-11-18 11:15 René Rebe
2025-11-19 2:05 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: René Rebe @ 2025-11-18 11:15 UTC (permalink / raw)
To: netdev; +Cc: Jakub Kicinski
3c515 stopped building for me some time ago, fix:
drivers/net/ethernet/3com/3c515.o: error: objtool: cleanup_module(): Magic init_module() function name is deprecated, use module_init(fn) instead
make[6]: *** [scripts/Makefile.build:203: drivers/net/ethernet/3com/3c515.o] Error 255
Signed-off-by: René Rebe <rene@exactco.de>
---
v2: git-format-patch
---
drivers/net/ethernet/3com/3c515.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/3com/3c515.c b/drivers/net/ethernet/3com/3c515.c
index ecdea58e6a21..1cb94423db72 100644
--- a/drivers/net/ethernet/3com/3c515.c
+++ b/drivers/net/ethernet/3com/3c515.c
@@ -1549,7 +1549,7 @@ static const struct ethtool_ops netdev_ethtool_ops = {
#ifdef MODULE
-void cleanup_module(void)
+static void corkscrew_cleanup_module(void)
{
while (!list_empty(&root_corkscrew_dev)) {
struct net_device *dev;
@@ -1563,4 +1563,5 @@ void cleanup_module(void)
free_netdev(dev);
}
}
+module_exit(corkscrew_cleanup_module);
#endif /* MODULE */
--
2.46.0
--
René Rebe, ExactCODE GmbH, Lietzenburger Str. 42, DE-10789 Berlin
https://exactco.de | https://t2linux.com | https://patreon.com/renerebe
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH V2] net: 3com/3c515 fix build error
2025-11-18 11:15 [PATCH V2] net: 3com/3c515 fix build error René Rebe
@ 2025-11-19 2:05 ` Jakub Kicinski
2025-11-19 8:49 ` René Rebe
0 siblings, 1 reply; 3+ messages in thread
From: Jakub Kicinski @ 2025-11-19 2:05 UTC (permalink / raw)
To: René Rebe; +Cc: netdev
On Tue, 18 Nov 2025 12:15:56 +0100 (CET) René Rebe wrote:
> 3c515 stopped building for me some time ago, fix:
>
> drivers/net/ethernet/3com/3c515.o: error: objtool: cleanup_module(): Magic init_module() function name is deprecated, use module_init(fn) instead
> make[6]: *** [scripts/Makefile.build:203: drivers/net/ethernet/3com/3c515.o] Error 255
Looks like this has already been fixed by 1471a274b76d1469a
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH V2] net: 3com/3c515 fix build error
2025-11-19 2:05 ` Jakub Kicinski
@ 2025-11-19 8:49 ` René Rebe
0 siblings, 0 replies; 3+ messages in thread
From: René Rebe @ 2025-11-19 8:49 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: netdev
> On 19. Nov 2025, at 03:05, Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Tue, 18 Nov 2025 12:15:56 +0100 (CET) René Rebe wrote:
>> 3c515 stopped building for me some time ago, fix:
>>
>> drivers/net/ethernet/3com/3c515.o: error: objtool: cleanup_module(): Magic init_module() function name is deprecated, use module_init(fn) instead
>> make[6]: *** [scripts/Makefile.build:203: drivers/net/ethernet/3com/3c515.o] Error 255
>
> Looks like this has already been fixed by 1471a274b76d1469a
Great, I’m usually basing on Linus’ tree.
Thanks!
René
--
https://exactco.de - https://t2linux.com - https://patreon.com/renerebe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-11-19 8:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-18 11:15 [PATCH V2] net: 3com/3c515 fix build error René Rebe
2025-11-19 2:05 ` Jakub Kicinski
2025-11-19 8:49 ` René Rebe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).