From: "Richard W.M. Jones" <rjones@redhat.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Eric Dumazet <edumazet@google.com>,
Josef Bacik <josef@toxicpanda.com>, Jens Axboe <axboe@kernel.dk>,
linux-kernel <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org, Eric Dumazet <eric.dumazet@gmail.com>,
syzbot+e1cd6bd8493060bd701d@syzkaller.appspotmail.com,
Mike Christie <mchristi@redhat.com>,
Yu Kuai <yukuai1@huaweicloud.com>,
linux-block@vger.kernel.org, nbd@other.debian.org
Subject: Re: [PATCH] nbd: restrict sockets to TCP and UDP
Date: Tue, 18 Nov 2025 18:16:23 +0000 [thread overview]
Message-ID: <20251118181623.GK1427@redhat.com> (raw)
In-Reply-To: <aRyzUc/WndKJBAz0@duo.ucw.cz>
On Tue, Nov 18, 2025 at 06:56:33PM +0100, Pavel Machek wrote:
> Hi!
>
> > Recently, syzbot started to abuse NBD with all kinds of sockets.
> >
> > Commit cf1b2326b734 ("nbd: verify socket is supported during setup")
> > made sure the socket supported a shutdown() method.
> >
> > Explicitely accept TCP and UNIX stream sockets.
>
> Note that running nbd server and client on same machine is not safe in
> read-write mode. It may deadlock under low memory conditions.
>
> Thus I'm not sure if we should accept UNIX sockets.
Both nbd-client and nbdkit have modes where they can mlock themselves
into RAM.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW
next prev parent reply other threads:[~2025-11-18 18:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-09 13:22 [PATCH] nbd: restrict sockets to TCP and UDP Eric Dumazet
2025-09-09 13:29 ` Jens Axboe
2025-09-09 13:32 ` Richard W.M. Jones
2025-09-09 14:04 ` Eric Dumazet
2025-09-09 14:35 ` Eric Dumazet
2025-09-09 14:37 ` Jens Axboe
2025-09-09 14:47 ` Eric Dumazet
2025-09-09 15:09 ` Jens Axboe
2025-09-09 15:18 ` Richard W.M. Jones
2025-09-09 15:33 ` Eric Dumazet
2025-09-10 15:55 ` Stefano Garzarella
2025-09-12 9:23 ` Simon Horman
2025-09-09 17:16 ` Richard W.M. Jones
2025-11-18 17:56 ` Pavel Machek
2025-11-18 18:16 ` Richard W.M. Jones [this message]
2025-11-19 9:10 ` Userland used in writeback path was " Pavel Machek
2025-11-24 11:04 ` Richard W.M. Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251118181623.GK1427@redhat.com \
--to=rjones@redhat.com \
--cc=axboe@kernel.dk \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchristi@redhat.com \
--cc=nbd@other.debian.org \
--cc=netdev@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=syzbot+e1cd6bd8493060bd701d@syzkaller.appspotmail.com \
--cc=yukuai1@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).