From: Jakub Kicinski <kuba@kernel.org>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: "Matthieu Baerts" <matttbe@kernel.org>,
netdev@vger.kernel.org, "Donald Hunter" <donald.hunter@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Simon Horman" <horms@kernel.org>,
"Jan Stancek" <jstancek@redhat.com>,
"Asbjørn Sloth Tønnesen" <ast@fiberby.net>,
"Stanislav Fomichev" <sdf@fomichev.me>,
"Ido Schimmel" <idosch@nvidia.com>,
"Guillaume Nault" <gnault@redhat.com>,
"Sabrina Dubroca" <sd@queasysnail.net>,
"Petr Machata" <petrm@nvidia.com>
Subject: Re: [PATCHv5 net-next 3/3] tools: ynl: add YNL test framework
Date: Tue, 18 Nov 2025 18:45:58 -0800 [thread overview]
Message-ID: <20251118184558.4d28aae2@kernel.org> (raw)
In-Reply-To: <aRvdb65MyVc39nm6@fedora>
On Tue, 18 Nov 2025 02:43:59 +0000 Hangbin Liu wrote:
> > How did you execute shellcheck?
> >
> > If I'm not mistaken, you are supposed to execute it from the same directory, and with -x:
> >
> > cd "$(dirname "${script}")"
> > shellcheck -x "$(basename "${script}")"
>
> Ah, I forgot to add the "-x" option... I will fix the comment in future test
> case update.
I applied the first two patches of the series, please respin this one.
TBH I'd like to check if this all works in NIPA but probably won't have
time to set up a new worker until the weekend. I suspect I'll need
to touch up the vng wrappers since this is not true ksft TARGET.
next prev parent reply other threads:[~2025-11-19 2:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 2:44 [PATCHv5 net-next 0/3] Add YNL test framework and library improvements Hangbin Liu
2025-11-17 2:44 ` [PATCHv5 net-next 1/3] tools: ynl: Add MAC address parsing support Hangbin Liu
2025-11-17 2:44 ` [PATCHv5 net-next 2/3] netlink: specs: support ipv4-or-v6 for dual-stack fields Hangbin Liu
2025-11-17 2:44 ` [PATCHv5 net-next 3/3] tools: ynl: add YNL test framework Hangbin Liu
2025-11-17 10:59 ` Matthieu Baerts
2025-11-18 1:14 ` Hangbin Liu
2025-11-18 2:21 ` Matthieu Baerts
2025-11-18 2:43 ` Hangbin Liu
2025-11-19 2:45 ` Jakub Kicinski [this message]
2025-11-17 14:45 ` Donald Hunter
2025-11-19 2:50 ` [PATCHv5 net-next 0/3] Add YNL test framework and library improvements patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251118184558.4d28aae2@kernel.org \
--to=kuba@kernel.org \
--cc=ast@fiberby.net \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=gnault@redhat.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=jstancek@redhat.com \
--cc=liuhangbin@gmail.com \
--cc=matttbe@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=sd@queasysnail.net \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).