netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
	andrew+netdev@lunn.ch, horms@kernel.org,
	willemdebruijn.kernel@gmail.com, shuah@kernel.org,
	sdf@fomichev.me, krakauer@google.com,
	linux-kselftest@vger.kernel.org, petrm@nvidia.com,
	matttbe@kernel.org, Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH net-next v2 11/12] netdevsim: add loopback support
Date: Tue, 18 Nov 2025 13:51:25 -0800	[thread overview]
Message-ID: <20251118215126.2225826-12-kuba@kernel.org> (raw)
In-Reply-To: <20251118215126.2225826-1-kuba@kernel.org>

Support device loopback. Apparently this mode has been historically
supported by the toeplitz test and I don't have any HW which lets
me test the conversion..

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
 drivers/net/netdevsim/netdev.c | 17 ++++++++++++-----
 1 file changed, 12 insertions(+), 5 deletions(-)

diff --git a/drivers/net/netdevsim/netdev.c b/drivers/net/netdevsim/netdev.c
index 2b713db16cd0..6927c1962277 100644
--- a/drivers/net/netdevsim/netdev.c
+++ b/drivers/net/netdevsim/netdev.c
@@ -133,15 +133,21 @@ static netdev_tx_t nsim_start_xmit(struct sk_buff *skb, struct net_device *dev)
 	if (!nsim_ipsec_tx(ns, skb))
 		goto out_drop_any;
 
-	peer_ns = rcu_dereference(ns->peer);
-	if (!peer_ns)
-		goto out_drop_any;
+	/* Check if loopback mode is enabled */
+	if (dev->features & NETIF_F_LOOPBACK) {
+		peer_ns = ns;
+		peer_dev = dev;
+	} else {
+		peer_ns = rcu_dereference(ns->peer);
+		if (!peer_ns)
+			goto out_drop_any;
+		peer_dev = peer_ns->netdev;
+	}
 
 	dr = nsim_do_psp(skb, ns, peer_ns, &psp_ext);
 	if (dr)
 		goto out_drop_free;
 
-	peer_dev = peer_ns->netdev;
 	rxq = skb_get_queue_mapping(skb);
 	if (rxq >= peer_dev->num_rx_queues)
 		rxq = rxq % peer_dev->num_rx_queues;
@@ -976,7 +982,8 @@ static void nsim_setup(struct net_device *dev)
 			    NETIF_F_FRAGLIST |
 			    NETIF_F_HW_CSUM |
 			    NETIF_F_LRO |
-			    NETIF_F_TSO;
+			    NETIF_F_TSO |
+			    NETIF_F_LOOPBACK;
 	dev->pcpu_stat_type = NETDEV_PCPU_STAT_DSTATS;
 	dev->max_mtu = ETH_MAX_MTU;
 	dev->xdp_features = NETDEV_XDP_ACT_BASIC | NETDEV_XDP_ACT_HW_OFFLOAD;
-- 
2.51.1


  parent reply	other threads:[~2025-11-18 21:52 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-18 21:51 [PATCH net-next v2 00/12] selftests: drv-net: convert GRO and Toeplitz tests to work for drivers in NIPA Jakub Kicinski
2025-11-18 21:51 ` [PATCH net-next v2 01/12] selftests: net: py: coding style improvements Jakub Kicinski
2025-11-19 13:40   ` Petr Machata
2025-11-19 14:32     ` Jakub Kicinski
2025-11-19 16:06       ` Petr Machata
2025-11-18 21:51 ` [PATCH net-next v2 02/12] selftests: net: py: extract the case generation logic Jakub Kicinski
2025-11-19 14:11   ` Petr Machata
2025-11-18 21:51 ` [PATCH net-next v2 03/12] selftests: net: py: add test variants Jakub Kicinski
2025-11-19 14:42   ` Petr Machata
2025-11-18 21:51 ` [PATCH net-next v2 04/12] selftests: drv-net: xdp: use variants for qstat tests Jakub Kicinski
2025-11-19 14:57   ` Petr Machata
2025-11-18 21:51 ` [PATCH net-next v2 05/12] selftests: net: relocate gro and toeplitz tests to drivers/net Jakub Kicinski
2025-11-19 15:09   ` Petr Machata
2025-11-18 21:51 ` [PATCH net-next v2 06/12] selftests: net: py: support ksft ready without wait Jakub Kicinski
2025-11-19 16:31   ` Petr Machata
2025-11-18 21:51 ` [PATCH net-next v2 07/12] selftests: net: py: read ip link info about remote dev Jakub Kicinski
2025-11-19 15:33   ` Petr Machata
2025-11-18 21:51 ` [PATCH net-next v2 08/12] netdevsim: pass packets thru GRO on Rx Jakub Kicinski
2025-11-19 15:43   ` Petr Machata
2025-11-18 21:51 ` [PATCH net-next v2 09/12] selftests: drv-net: add a Python version of the GRO test Jakub Kicinski
2025-11-19 15:54   ` Petr Machata
2025-11-18 21:51 ` [PATCH net-next v2 10/12] selftests: drv-net: hw: convert the Toeplitz test to Python Jakub Kicinski
2025-11-19 16:39   ` Petr Machata
2025-11-18 21:51 ` Jakub Kicinski [this message]
2025-11-19 17:01   ` [PATCH net-next v2 11/12] netdevsim: add loopback support Petr Machata
2025-11-18 21:51 ` [PATCH net-next v2 12/12] selftests: net: remove old setup_* scripts Jakub Kicinski
2025-11-19 17:04   ` Petr Machata
2025-11-18 22:31 ` [PATCH net-next v2 00/12] selftests: drv-net: convert GRO and Toeplitz tests to work for drivers in NIPA Willem de Bruijn
2025-11-19  0:25   ` Jakub Kicinski
2025-11-19  0:32     ` Willem de Bruijn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251118215126.2225826-12-kuba@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=krakauer@google.com \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=matttbe@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=petrm@nvidia.com \
    --cc=sdf@fomichev.me \
    --cc=shuah@kernel.org \
    --cc=willemdebruijn.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).