From: Jakub Kicinski <kuba@kernel.org>
To: Gal Pressman <gal@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
netdev@vger.kernel.org, Donald Hunter <donald.hunter@gmail.com>,
Simon Horman <horms@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Stanislav Fomichev <sdf@fomichev.me>,
bpf@vger.kernel.org, Nimrod Oren <noren@nvidia.com>
Subject: Re: [PATCH net-next 1/3] tools: ynl: cli: Add --list-attrs option to show operation attributes
Date: Wed, 19 Nov 2025 06:20:03 -0800 [thread overview]
Message-ID: <20251119062003.6ccf45f1@kernel.org> (raw)
In-Reply-To: <acf74a59-f399-4952-81d7-f99e13785fb2@nvidia.com>
On Wed, 19 Nov 2025 13:36:09 +0200 Gal Pressman wrote:
> On 18/11/2025 19:13, Jakub Kicinski wrote:
> > On Tue, 18 Nov 2025 11:38:04 +0200 Gal Pressman wrote:
> >> We need to take care of both cases where the whole operation is
> >> identical (e.g., ethtool debug-get), and cases where only the replies
> >> are identical (e.g., netdev dev-get). This kind of complicates the code.
> >
> > I was thinking just the reply. This is mostly for GET type operations.
> > Request doesn't exist for DUMP, but for DO it carries ID.
>
> Some dumps have requests, like ethtool's debug-get or strset-get.
> I have a patch that detects identical replies, but it's quite ugly TBH.
> I'd prefer to keep the code as is, but up to you.
It's alright. I'll poke at it after merging, but if we can't find
a clean way it's fine.
next prev parent reply other threads:[~2025-11-19 14:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-16 19:28 [PATCH net-next 0/3] YNL CLI --list-attrs argument Gal Pressman
2025-11-16 19:28 ` [PATCH net-next 1/3] tools: ynl: cli: Add --list-attrs option to show operation attributes Gal Pressman
2025-11-17 15:56 ` Donald Hunter
2025-11-18 9:38 ` Gal Pressman
2025-11-18 1:35 ` Jakub Kicinski
2025-11-18 9:20 ` Donald Hunter
2025-11-18 9:38 ` Gal Pressman
2025-11-18 17:13 ` Jakub Kicinski
2025-11-19 11:36 ` Gal Pressman
2025-11-19 14:20 ` Jakub Kicinski [this message]
2025-11-18 1:38 ` Jakub Kicinski
2025-11-18 9:36 ` Gal Pressman
2025-11-16 19:28 ` [PATCH net-next 2/3] tools: ynl: cli: Parse nested attributes in --list-attrs output Gal Pressman
2025-11-17 15:57 ` Donald Hunter
2025-11-16 19:28 ` [PATCH net-next 3/3] tools: ynl: cli: Display enum values " Gal Pressman
2025-11-17 16:05 ` Donald Hunter
2025-11-18 9:35 ` Gal Pressman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251119062003.6ccf45f1@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=noren@nvidia.com \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).