netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Daniel Jurgens <danielj@nvidia.com>
Cc: <netdev@vger.kernel.org>, <mst@redhat.com>, <jasowang@redhat.com>,
	<pabeni@redhat.com>, <virtualization@lists.linux.dev>,
	<parav@nvidia.com>, <shshitrit@nvidia.com>, <yohadt@nvidia.com>,
	<xuanzhuo@linux.alibaba.com>, <eperezma@redhat.com>,
	<jgg@ziepe.ca>, <kevin.tian@intel.com>, <andrew+netdev@lunn.ch>,
	<edumazet@google.com>
Subject: Re: [PATCH net-next v12 05/12] virtio_net: Query and set flow filter caps
Date: Wed, 19 Nov 2025 17:51:49 -0800	[thread overview]
Message-ID: <20251119175149.6bc8f7b2@kernel.org> (raw)
In-Reply-To: <20251119191524.4572-6-danielj@nvidia.com>

On Wed, 19 Nov 2025 13:15:16 -0600 Daniel Jurgens wrote:
> +/**
> + * struct virtio_net_ff_cap_data - Flow filter resource capability limits
> + * @groups_limit: maximum number of flow filter groups supported by the device
> + * @classifiers_limit: maximum number of classifiers supported by the device
> + * @rules_limit: maximum number of rules supported device-wide across all groups
> + * @rules_per_group_limit: maximum number of rules allowed in a single group
> + * @last_rule_priority: priority value associated with the lowest-priority rule
> + * @selectors_per_classifier_limit: maximum selectors allowed in one classifier
> + */
> +struct virtio_net_ff_cap_data {
> +	__le32 groups_limit;
> +	__le32 classifiers_limit;
> +	__le32 rules_limit;
> +	__le32 rules_per_group_limit;
> +	__u8 last_rule_priority;
> +	__u8 selectors_per_classifier_limit;

pop in a :

	/* private: */

comment here, otherwise kdoc will complain that @reserved is
undocumented.

> +	__u8 reserved[2];
> +};

That said, if you don't mind pls wait for Michael's review with 
the repost. Unless someone else provides review comments first.

  reply	other threads:[~2025-11-20  1:51 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-19 19:15 [PATCH net-next v12 00/12] virtio_net: Add ethtool flow rules support Daniel Jurgens
2025-11-19 19:15 ` [PATCH net-next v12 01/12] virtio_pci: Remove supported_cap size build assert Daniel Jurgens
2025-11-19 19:15 ` [PATCH net-next v12 02/12] virtio: Add config_op for admin commands Daniel Jurgens
2025-11-19 19:15 ` [PATCH net-next v12 03/12] virtio: Expose generic device capability operations Daniel Jurgens
2025-11-24 20:30   ` Michael S. Tsirkin
2025-11-24 22:24     ` Dan Jurgens
2025-11-24 22:27       ` Michael S. Tsirkin
2025-11-19 19:15 ` [PATCH net-next v12 04/12] virtio: Expose object create and destroy API Daniel Jurgens
2025-11-19 19:15 ` [PATCH net-next v12 05/12] virtio_net: Query and set flow filter caps Daniel Jurgens
2025-11-20  1:51   ` Jakub Kicinski [this message]
2025-11-20 15:39     ` Dan Jurgens
2025-11-24 21:01   ` Michael S. Tsirkin
2025-11-25  0:05     ` Dan Jurgens
2025-11-24 22:54   ` Michael S. Tsirkin
2025-11-26  6:11     ` Dan Jurgens
2025-11-19 19:15 ` [PATCH net-next v12 06/12] virtio_net: Create a FF group for ethtool steering Daniel Jurgens
2025-11-19 19:15 ` [PATCH net-next v12 07/12] virtio_net: Implement layer 2 ethtool flow rules Daniel Jurgens
2025-11-24 21:05   ` Michael S. Tsirkin
2025-11-26 16:25     ` Dan Jurgens
2025-11-26 18:00       ` Michael S. Tsirkin
2025-11-25 14:25   ` Michael S. Tsirkin
2025-11-25 15:39     ` Dan Jurgens
2025-11-19 19:15 ` [PATCH net-next v12 08/12] virtio_net: Use existing classifier if possible Daniel Jurgens
2025-11-24 22:04   ` Michael S. Tsirkin
2025-11-24 22:31     ` Dan Jurgens
2025-11-24 22:38       ` Michael S. Tsirkin
2025-11-19 19:15 ` [PATCH net-next v12 09/12] virtio_net: Implement IPv4 ethtool flow rules Daniel Jurgens
2025-11-24 21:51   ` Michael S. Tsirkin
2025-11-24 22:41     ` Dan Jurgens
2025-11-26  5:48     ` Dan Jurgens
2025-11-19 19:15 ` [PATCH net-next v12 10/12] virtio_net: Add support for IPv6 ethtool steering Daniel Jurgens
2025-11-24 21:59   ` Michael S. Tsirkin
2025-11-24 23:04     ` Dan Jurgens
2025-11-24 23:12       ` Michael S. Tsirkin
2025-11-25  0:10         ` Dan Jurgens
2025-11-19 19:15 ` [PATCH net-next v12 11/12] virtio_net: Add support for TCP and UDP ethtool rules Daniel Jurgens
2025-11-24 22:02   ` Michael S. Tsirkin
2025-11-24 22:47     ` Dan Jurgens
2025-11-19 19:15 ` [PATCH net-next v12 12/12] virtio_net: Add get ethtool flow rules ops Daniel Jurgens
2025-11-19 20:22 ` [PATCH net-next v12 00/12] virtio_net: Add ethtool flow rules support Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251119175149.6bc8f7b2@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=danielj@nvidia.com \
    --cc=edumazet@google.com \
    --cc=eperezma@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=jgg@ziepe.ca \
    --cc=kevin.tian@intel.com \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=parav@nvidia.com \
    --cc=shshitrit@nvidia.com \
    --cc=virtualization@lists.linux.dev \
    --cc=xuanzhuo@linux.alibaba.com \
    --cc=yohadt@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).