netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Parav Pandit <parav@nvidia.com>, Jiri Pirko <jiri@nvidia.com>
Cc: <netdev@vger.kernel.org>, <davem@davemloft.net>,
	<edumazet@google.com>, <pabeni@redhat.com>, <horms@kernel.org>
Subject: Re: [PATCH net-next v1] devlink: Notify eswitch mode changes to devlink monitor
Date: Wed, 19 Nov 2025 17:56:28 -0800	[thread overview]
Message-ID: <20251119175628.4fe6cd4d@kernel.org> (raw)
In-Reply-To: <20251119165936.9061-1-parav@nvidia.com>

On Wed, 19 Nov 2025 18:59:36 +0200 Parav Pandit wrote:
> When eswitch mode changes, notify such change to the
> devlink monitoring process.
> 
> After this notification, a devlink monitoring process
> can see following output:
> 
> $ devlink mon
> [eswitch,get] pci/0000:06:00.0: mode switchdev inline-mode none encap-mode basic
> [eswitch,get] pci/0000:06:00.0: mode legacy inline-mode none encap-mode basic
> 
> Reviewed-by: Jiri Pirko <jiri@nvidia.com>

Jiri, did you have a chance to re-review this or the tag is stale?
I have a slight preference for a new command ID here but if you
think GET is fine then so be it.

Is it possible to add this to the Netlink YAML spec? off the top of 
my head I think it's a "notification":

    -
      name: $name
      doc: $doc
      notify: eswitch-get

  reply	other threads:[~2025-11-20  1:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-19 16:59 [PATCH net-next v1] devlink: Notify eswitch mode changes to devlink monitor Parav Pandit
2025-11-20  1:56 ` Jakub Kicinski [this message]
2025-11-20 12:09   ` Jiri Pirko
2025-11-20 14:52     ` Jakub Kicinski
2025-11-20 14:56       ` Parav Pandit
2025-11-21  8:35       ` Jiri Pirko
2025-11-21  8:51         ` Parav Pandit
2025-11-21 14:48         ` Jakub Kicinski
2025-11-22  9:14           ` Jiri Pirko
2025-11-25  4:27             ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251119175628.4fe6cd4d@kernel.org \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=jiri@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=parav@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).