* [PATCH v3 1/2] bus: mhi: host: pci_generic: Add Foxconn T99W760 modem
2025-11-19 10:56 [PATCH v3 0/2] *** Add support for Foxconn T99W760 *** Slark Xiao
@ 2025-11-19 10:56 ` Slark Xiao
2025-11-19 10:56 ` [PATCH v3 2/2] net: wwan: mhi: Add network support for Foxconn T99W760 Slark Xiao
` (2 subsequent siblings)
3 siblings, 0 replies; 18+ messages in thread
From: Slark Xiao @ 2025-11-19 10:56 UTC (permalink / raw)
To: mani, loic.poulain, ryazanov.s.a, johannes, andrew+netdev, davem,
edumazet, kuba, pabeni
Cc: mhi, linux-arm-msm, netdev, linux-kernel, Slark Xiao
T99W760 modem is based on Qualcomm SDX35 chipset.
It use the same channel settings with Foxconn SDX61.
edl file has been committed to linux-firmware.
Signed-off-by: Slark Xiao <slark_xiao@163.com>
---
drivers/bus/mhi/host/pci_generic.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
index 3d8c9729fcfc..e3bc737313a2 100644
--- a/drivers/bus/mhi/host/pci_generic.c
+++ b/drivers/bus/mhi/host/pci_generic.c
@@ -663,6 +663,17 @@ static const struct mhi_pci_dev_info mhi_foxconn_t99w696_info = {
.sideband_wake = false,
};
+static const struct mhi_pci_dev_info mhi_foxconn_t99w760_info = {
+ .name = "foxconn-t99w760",
+ .edl = "qcom/sdx35/foxconn/xbl_s_devprg_ns.melf",
+ .edl_trigger = true,
+ .config = &modem_foxconn_sdx61_config,
+ .bar_num = MHI_PCI_DEFAULT_BAR_NUM,
+ .dma_data_width = 32,
+ .mru_default = 32768,
+ .sideband_wake = false,
+};
+
static const struct mhi_channel_config mhi_mv3x_channels[] = {
MHI_CHANNEL_CONFIG_UL(0, "LOOPBACK", 64, 0),
MHI_CHANNEL_CONFIG_DL(1, "LOOPBACK", 64, 0),
@@ -1010,6 +1021,8 @@ static const struct pci_device_id mhi_pci_id_table[] = {
/* DW5934e(sdx72), Non-eSIM */
{ PCI_DEVICE(PCI_VENDOR_ID_FOXCONN, 0xe11e),
.driver_data = (kernel_ulong_t) &mhi_foxconn_dw5934e_info },
+ { PCI_DEVICE(PCI_VENDOR_ID_FOXCONN, 0xe123),
+ .driver_data = (kernel_ulong_t) &mhi_foxconn_t99w760_info },
/* MV31-W (Cinterion) */
{ PCI_DEVICE(PCI_VENDOR_ID_THALES, 0x00b3),
.driver_data = (kernel_ulong_t) &mhi_mv31_info },
--
2.25.1
^ permalink raw reply related [flat|nested] 18+ messages in thread* [PATCH v3 2/2] net: wwan: mhi: Add network support for Foxconn T99W760
2025-11-19 10:56 [PATCH v3 0/2] *** Add support for Foxconn T99W760 *** Slark Xiao
2025-11-19 10:56 ` [PATCH v3 1/2] bus: mhi: host: pci_generic: Add Foxconn T99W760 modem Slark Xiao
@ 2025-11-19 10:56 ` Slark Xiao
2025-11-19 11:27 ` Dmitry Baryshkov
2025-11-21 12:46 ` Loic Poulain
2025-11-20 2:07 ` [PATCH v3 0/2] *** Add support for Foxconn T99W760 *** Jakub Kicinski
2025-11-20 5:45 ` (subset) " Manivannan Sadhasivam
3 siblings, 2 replies; 18+ messages in thread
From: Slark Xiao @ 2025-11-19 10:56 UTC (permalink / raw)
To: mani, loic.poulain, ryazanov.s.a, johannes, andrew+netdev, davem,
edumazet, kuba, pabeni
Cc: mhi, linux-arm-msm, netdev, linux-kernel, Slark Xiao
T99W760 is designed based on Qualcomm SDX35 chip. It use similar
architechture with SDX72/SDX75 chip. So we need to assign initial
link id for this device to make sure network available.
Signed-off-by: Slark Xiao <slark_xiao@163.com>
---
drivers/net/wwan/mhi_wwan_mbim.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wwan/mhi_wwan_mbim.c b/drivers/net/wwan/mhi_wwan_mbim.c
index c814fbd756a1..a142af59a91f 100644
--- a/drivers/net/wwan/mhi_wwan_mbim.c
+++ b/drivers/net/wwan/mhi_wwan_mbim.c
@@ -98,7 +98,8 @@ static struct mhi_mbim_link *mhi_mbim_get_link_rcu(struct mhi_mbim_context *mbim
static int mhi_mbim_get_link_mux_id(struct mhi_controller *cntrl)
{
if (strcmp(cntrl->name, "foxconn-dw5934e") == 0 ||
- strcmp(cntrl->name, "foxconn-t99w515") == 0)
+ strcmp(cntrl->name, "foxconn-t99w515") == 0 ||
+ strcmp(cntrl->name, "foxconn-t99w760") == 0)
return WDS_BIND_MUX_DATA_PORT_MUX_ID;
return 0;
--
2.25.1
^ permalink raw reply related [flat|nested] 18+ messages in thread* Re: [PATCH v3 2/2] net: wwan: mhi: Add network support for Foxconn T99W760
2025-11-19 10:56 ` [PATCH v3 2/2] net: wwan: mhi: Add network support for Foxconn T99W760 Slark Xiao
@ 2025-11-19 11:27 ` Dmitry Baryshkov
2025-11-19 13:08 ` Loic Poulain
2025-11-21 12:46 ` Loic Poulain
1 sibling, 1 reply; 18+ messages in thread
From: Dmitry Baryshkov @ 2025-11-19 11:27 UTC (permalink / raw)
To: Slark Xiao
Cc: mani, loic.poulain, ryazanov.s.a, johannes, andrew+netdev, davem,
edumazet, kuba, pabeni, mhi, linux-arm-msm, netdev, linux-kernel
On Wed, Nov 19, 2025 at 06:56:15PM +0800, Slark Xiao wrote:
> T99W760 is designed based on Qualcomm SDX35 chip. It use similar
> architechture with SDX72/SDX75 chip. So we need to assign initial
> link id for this device to make sure network available.
>
> Signed-off-by: Slark Xiao <slark_xiao@163.com>
> ---
> drivers/net/wwan/mhi_wwan_mbim.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/wwan/mhi_wwan_mbim.c b/drivers/net/wwan/mhi_wwan_mbim.c
> index c814fbd756a1..a142af59a91f 100644
> --- a/drivers/net/wwan/mhi_wwan_mbim.c
> +++ b/drivers/net/wwan/mhi_wwan_mbim.c
> @@ -98,7 +98,8 @@ static struct mhi_mbim_link *mhi_mbim_get_link_rcu(struct mhi_mbim_context *mbim
> static int mhi_mbim_get_link_mux_id(struct mhi_controller *cntrl)
> {
> if (strcmp(cntrl->name, "foxconn-dw5934e") == 0 ||
> - strcmp(cntrl->name, "foxconn-t99w515") == 0)
> + strcmp(cntrl->name, "foxconn-t99w515") == 0 ||
> + strcmp(cntrl->name, "foxconn-t99w760") == 0)
Can we replace this list of strinc comparisons with some kind of device
data, being set in the mhi-pci-generic driver?
> return WDS_BIND_MUX_DATA_PORT_MUX_ID;
>
> return 0;
> --
> 2.25.1
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [PATCH v3 2/2] net: wwan: mhi: Add network support for Foxconn T99W760
2025-11-19 11:27 ` Dmitry Baryshkov
@ 2025-11-19 13:08 ` Loic Poulain
2025-11-19 13:47 ` Dmitry Baryshkov
2025-11-20 5:40 ` Manivannan Sadhasivam
0 siblings, 2 replies; 18+ messages in thread
From: Loic Poulain @ 2025-11-19 13:08 UTC (permalink / raw)
To: Dmitry Baryshkov, Slark Xiao
Cc: mani, ryazanov.s.a, johannes, andrew+netdev, davem, edumazet,
kuba, pabeni, mhi, linux-arm-msm, netdev, linux-kernel
On Wed, Nov 19, 2025 at 12:27 PM Dmitry Baryshkov
<dmitry.baryshkov@oss.qualcomm.com> wrote:
>
> On Wed, Nov 19, 2025 at 06:56:15PM +0800, Slark Xiao wrote:
> > T99W760 is designed based on Qualcomm SDX35 chip. It use similar
> > architechture with SDX72/SDX75 chip. So we need to assign initial
> > link id for this device to make sure network available.
> >
> > Signed-off-by: Slark Xiao <slark_xiao@163.com>
> > ---
> > drivers/net/wwan/mhi_wwan_mbim.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/wwan/mhi_wwan_mbim.c b/drivers/net/wwan/mhi_wwan_mbim.c
> > index c814fbd756a1..a142af59a91f 100644
> > --- a/drivers/net/wwan/mhi_wwan_mbim.c
> > +++ b/drivers/net/wwan/mhi_wwan_mbim.c
> > @@ -98,7 +98,8 @@ static struct mhi_mbim_link *mhi_mbim_get_link_rcu(struct mhi_mbim_context *mbim
> > static int mhi_mbim_get_link_mux_id(struct mhi_controller *cntrl)
> > {
> > if (strcmp(cntrl->name, "foxconn-dw5934e") == 0 ||
> > - strcmp(cntrl->name, "foxconn-t99w515") == 0)
> > + strcmp(cntrl->name, "foxconn-t99w515") == 0 ||
> > + strcmp(cntrl->name, "foxconn-t99w760") == 0)
>
> Can we replace this list of strinc comparisons with some kind of device
> data, being set in the mhi-pci-generic driver?
If we move this MBIM-specific information into mhi-pci-generic, we
should consider using a software node (e.g. via
device_add_software_node) so that these properties can be accessed
through the generic device-property API.
Regards,
Loic
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [PATCH v3 2/2] net: wwan: mhi: Add network support for Foxconn T99W760
2025-11-19 13:08 ` Loic Poulain
@ 2025-11-19 13:47 ` Dmitry Baryshkov
2025-11-20 3:04 ` Slark Xiao
2025-11-20 5:40 ` Manivannan Sadhasivam
1 sibling, 1 reply; 18+ messages in thread
From: Dmitry Baryshkov @ 2025-11-19 13:47 UTC (permalink / raw)
To: Loic Poulain
Cc: Slark Xiao, mani, ryazanov.s.a, johannes, andrew+netdev, davem,
edumazet, kuba, pabeni, mhi, linux-arm-msm, netdev, linux-kernel
On Wed, Nov 19, 2025 at 02:08:33PM +0100, Loic Poulain wrote:
> On Wed, Nov 19, 2025 at 12:27 PM Dmitry Baryshkov
> <dmitry.baryshkov@oss.qualcomm.com> wrote:
> >
> > On Wed, Nov 19, 2025 at 06:56:15PM +0800, Slark Xiao wrote:
> > > T99W760 is designed based on Qualcomm SDX35 chip. It use similar
> > > architechture with SDX72/SDX75 chip. So we need to assign initial
> > > link id for this device to make sure network available.
> > >
> > > Signed-off-by: Slark Xiao <slark_xiao@163.com>
> > > ---
> > > drivers/net/wwan/mhi_wwan_mbim.c | 3 ++-
> > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/net/wwan/mhi_wwan_mbim.c b/drivers/net/wwan/mhi_wwan_mbim.c
> > > index c814fbd756a1..a142af59a91f 100644
> > > --- a/drivers/net/wwan/mhi_wwan_mbim.c
> > > +++ b/drivers/net/wwan/mhi_wwan_mbim.c
> > > @@ -98,7 +98,8 @@ static struct mhi_mbim_link *mhi_mbim_get_link_rcu(struct mhi_mbim_context *mbim
> > > static int mhi_mbim_get_link_mux_id(struct mhi_controller *cntrl)
> > > {
> > > if (strcmp(cntrl->name, "foxconn-dw5934e") == 0 ||
> > > - strcmp(cntrl->name, "foxconn-t99w515") == 0)
> > > + strcmp(cntrl->name, "foxconn-t99w515") == 0 ||
> > > + strcmp(cntrl->name, "foxconn-t99w760") == 0)
> >
> > Can we replace this list of strinc comparisons with some kind of device
> > data, being set in the mhi-pci-generic driver?
>
> If we move this MBIM-specific information into mhi-pci-generic, we
> should consider using a software node (e.g. via
> device_add_software_node) so that these properties can be accessed
> through the generic device-property API.
Works for me too.
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 18+ messages in thread* Re:Re: [PATCH v3 2/2] net: wwan: mhi: Add network support for Foxconn T99W760
2025-11-19 13:47 ` Dmitry Baryshkov
@ 2025-11-20 3:04 ` Slark Xiao
0 siblings, 0 replies; 18+ messages in thread
From: Slark Xiao @ 2025-11-20 3:04 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Loic Poulain, mani, ryazanov.s.a, johannes, andrew+netdev, davem,
edumazet, kuba, pabeni, mhi, linux-arm-msm, netdev, linux-kernel
At 2025-11-19 21:47:33, "Dmitry Baryshkov" <dmitry.baryshkov@oss.qualcomm.com> wrote:
>On Wed, Nov 19, 2025 at 02:08:33PM +0100, Loic Poulain wrote:
>> On Wed, Nov 19, 2025 at 12:27 PM Dmitry Baryshkov
>> <dmitry.baryshkov@oss.qualcomm.com> wrote:
>> >
>> > On Wed, Nov 19, 2025 at 06:56:15PM +0800, Slark Xiao wrote:
>> > > T99W760 is designed based on Qualcomm SDX35 chip. It use similar
>> > > architechture with SDX72/SDX75 chip. So we need to assign initial
>> > > link id for this device to make sure network available.
>> > >
>> > > Signed-off-by: Slark Xiao <slark_xiao@163.com>
>> > > ---
>> > > drivers/net/wwan/mhi_wwan_mbim.c | 3 ++-
>> > > 1 file changed, 2 insertions(+), 1 deletion(-)
>> > >
>> > > diff --git a/drivers/net/wwan/mhi_wwan_mbim.c b/drivers/net/wwan/mhi_wwan_mbim.c
>> > > index c814fbd756a1..a142af59a91f 100644
>> > > --- a/drivers/net/wwan/mhi_wwan_mbim.c
>> > > +++ b/drivers/net/wwan/mhi_wwan_mbim.c
>> > > @@ -98,7 +98,8 @@ static struct mhi_mbim_link *mhi_mbim_get_link_rcu(struct mhi_mbim_context *mbim
>> > > static int mhi_mbim_get_link_mux_id(struct mhi_controller *cntrl)
>> > > {
>> > > if (strcmp(cntrl->name, "foxconn-dw5934e") == 0 ||
>> > > - strcmp(cntrl->name, "foxconn-t99w515") == 0)
>> > > + strcmp(cntrl->name, "foxconn-t99w515") == 0 ||
>> > > + strcmp(cntrl->name, "foxconn-t99w760") == 0)
>> >
>> > Can we replace this list of strinc comparisons with some kind of device
>> > data, being set in the mhi-pci-generic driver?
>>
>> If we move this MBIM-specific information into mhi-pci-generic, we
>> should consider using a software node (e.g. via
>> device_add_software_node) so that these properties can be accessed
>> through the generic device-property API.
>
Hi Loic,
The original solution is we defined this mux_id in mhi-pci-generic side and
transfer it to MBIM side. But it is rejected in last year.
Why we move it back again?
>Works for me too.
>
>--
>With best wishes
>Dmitry
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v3 2/2] net: wwan: mhi: Add network support for Foxconn T99W760
2025-11-19 13:08 ` Loic Poulain
2025-11-19 13:47 ` Dmitry Baryshkov
@ 2025-11-20 5:40 ` Manivannan Sadhasivam
2025-11-20 7:44 ` Loic Poulain
1 sibling, 1 reply; 18+ messages in thread
From: Manivannan Sadhasivam @ 2025-11-20 5:40 UTC (permalink / raw)
To: Loic Poulain
Cc: Dmitry Baryshkov, Slark Xiao, ryazanov.s.a, johannes,
andrew+netdev, davem, edumazet, kuba, pabeni, mhi, linux-arm-msm,
netdev, linux-kernel
On Wed, Nov 19, 2025 at 02:08:33PM +0100, Loic Poulain wrote:
> On Wed, Nov 19, 2025 at 12:27 PM Dmitry Baryshkov
> <dmitry.baryshkov@oss.qualcomm.com> wrote:
> >
> > On Wed, Nov 19, 2025 at 06:56:15PM +0800, Slark Xiao wrote:
> > > T99W760 is designed based on Qualcomm SDX35 chip. It use similar
> > > architechture with SDX72/SDX75 chip. So we need to assign initial
> > > link id for this device to make sure network available.
> > >
> > > Signed-off-by: Slark Xiao <slark_xiao@163.com>
> > > ---
> > > drivers/net/wwan/mhi_wwan_mbim.c | 3 ++-
> > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/net/wwan/mhi_wwan_mbim.c b/drivers/net/wwan/mhi_wwan_mbim.c
> > > index c814fbd756a1..a142af59a91f 100644
> > > --- a/drivers/net/wwan/mhi_wwan_mbim.c
> > > +++ b/drivers/net/wwan/mhi_wwan_mbim.c
> > > @@ -98,7 +98,8 @@ static struct mhi_mbim_link *mhi_mbim_get_link_rcu(struct mhi_mbim_context *mbim
> > > static int mhi_mbim_get_link_mux_id(struct mhi_controller *cntrl)
> > > {
> > > if (strcmp(cntrl->name, "foxconn-dw5934e") == 0 ||
> > > - strcmp(cntrl->name, "foxconn-t99w515") == 0)
> > > + strcmp(cntrl->name, "foxconn-t99w515") == 0 ||
> > > + strcmp(cntrl->name, "foxconn-t99w760") == 0)
> >
> > Can we replace this list of strinc comparisons with some kind of device
> > data, being set in the mhi-pci-generic driver?
>
> If we move this MBIM-specific information into mhi-pci-generic, we
> should consider using a software node (e.g. via
> device_add_software_node) so that these properties can be accessed
> through the generic device-property API.
>
MHI has to business in dealing with MBIM specific information as we already
concluded. So it should be handled within the WWAN subsystem.
- Mani
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [PATCH v3 2/2] net: wwan: mhi: Add network support for Foxconn T99W760
2025-11-20 5:40 ` Manivannan Sadhasivam
@ 2025-11-20 7:44 ` Loic Poulain
2025-11-20 8:22 ` Slark Xiao
0 siblings, 1 reply; 18+ messages in thread
From: Loic Poulain @ 2025-11-20 7:44 UTC (permalink / raw)
To: Slark Xiao, Manivannan Sadhasivam
Cc: Dmitry Baryshkov, ryazanov.s.a, johannes, andrew+netdev, davem,
edumazet, kuba, pabeni, mhi, linux-arm-msm, netdev, linux-kernel
On Thu, Nov 20, 2025 at 6:41 AM Manivannan Sadhasivam <mani@kernel.org> wrote:
>
> On Wed, Nov 19, 2025 at 02:08:33PM +0100, Loic Poulain wrote:
> > On Wed, Nov 19, 2025 at 12:27 PM Dmitry Baryshkov
> > <dmitry.baryshkov@oss.qualcomm.com> wrote:
> > >
> > > On Wed, Nov 19, 2025 at 06:56:15PM +0800, Slark Xiao wrote:
> > > > T99W760 is designed based on Qualcomm SDX35 chip. It use similar
> > > > architechture with SDX72/SDX75 chip. So we need to assign initial
> > > > link id for this device to make sure network available.
> > > >
> > > > Signed-off-by: Slark Xiao <slark_xiao@163.com>
> > > > ---
> > > > drivers/net/wwan/mhi_wwan_mbim.c | 3 ++-
> > > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/net/wwan/mhi_wwan_mbim.c b/drivers/net/wwan/mhi_wwan_mbim.c
> > > > index c814fbd756a1..a142af59a91f 100644
> > > > --- a/drivers/net/wwan/mhi_wwan_mbim.c
> > > > +++ b/drivers/net/wwan/mhi_wwan_mbim.c
> > > > @@ -98,7 +98,8 @@ static struct mhi_mbim_link *mhi_mbim_get_link_rcu(struct mhi_mbim_context *mbim
> > > > static int mhi_mbim_get_link_mux_id(struct mhi_controller *cntrl)
> > > > {
> > > > if (strcmp(cntrl->name, "foxconn-dw5934e") == 0 ||
> > > > - strcmp(cntrl->name, "foxconn-t99w515") == 0)
> > > > + strcmp(cntrl->name, "foxconn-t99w515") == 0 ||
> > > > + strcmp(cntrl->name, "foxconn-t99w760") == 0)
> > >
> > > Can we replace this list of strinc comparisons with some kind of device
> > > data, being set in the mhi-pci-generic driver?
> >
> > If we move this MBIM-specific information into mhi-pci-generic, we
> > should consider using a software node (e.g. via
> > device_add_software_node) so that these properties can be accessed
> > through the generic device-property API.
> >
>
> MHI has to business in dealing with MBIM specific information as we already
> concluded. So it should be handled within the WWAN subsystem.
it doesn’t make sense to include MBIM-specific fields in a generic MHI
structure. However, attaching fwnode properties could be reasonable
since the MHI PCI driver is responsible for device enumeration, and
that would keep device model specific handling fully covered in that
driver.
It’s fine to keep device-specific handling within WWAN/MBIM. However,
next time, please introduce a dedicated device data structure for the
mux-id instead of adding another strcmp.
Regards,
Loic
^ permalink raw reply [flat|nested] 18+ messages in thread* Re:Re: [PATCH v3 2/2] net: wwan: mhi: Add network support for Foxconn T99W760
2025-11-20 7:44 ` Loic Poulain
@ 2025-11-20 8:22 ` Slark Xiao
0 siblings, 0 replies; 18+ messages in thread
From: Slark Xiao @ 2025-11-20 8:22 UTC (permalink / raw)
To: Loic Poulain
Cc: Manivannan Sadhasivam, Dmitry Baryshkov, ryazanov.s.a, johannes,
andrew+netdev, davem, edumazet, kuba, pabeni, mhi, linux-arm-msm,
netdev, linux-kernel
At 2025-11-20 15:44:14, "Loic Poulain" <loic.poulain@oss.qualcomm.com> wrote:
>On Thu, Nov 20, 2025 at 6:41 AM Manivannan Sadhasivam <mani@kernel.org> wrote:
>>
>> On Wed, Nov 19, 2025 at 02:08:33PM +0100, Loic Poulain wrote:
>> > On Wed, Nov 19, 2025 at 12:27 PM Dmitry Baryshkov
>> > <dmitry.baryshkov@oss.qualcomm.com> wrote:
>> > >
>> > > On Wed, Nov 19, 2025 at 06:56:15PM +0800, Slark Xiao wrote:
>> > > > T99W760 is designed based on Qualcomm SDX35 chip. It use similar
>> > > > architechture with SDX72/SDX75 chip. So we need to assign initial
>> > > > link id for this device to make sure network available.
>> > > >
>> > > > Signed-off-by: Slark Xiao <slark_xiao@163.com>
>> > > > ---
>> > > > drivers/net/wwan/mhi_wwan_mbim.c | 3 ++-
>> > > > 1 file changed, 2 insertions(+), 1 deletion(-)
>> > > >
>> > > > diff --git a/drivers/net/wwan/mhi_wwan_mbim.c b/drivers/net/wwan/mhi_wwan_mbim.c
>> > > > index c814fbd756a1..a142af59a91f 100644
>> > > > --- a/drivers/net/wwan/mhi_wwan_mbim.c
>> > > > +++ b/drivers/net/wwan/mhi_wwan_mbim.c
>> > > > @@ -98,7 +98,8 @@ static struct mhi_mbim_link *mhi_mbim_get_link_rcu(struct mhi_mbim_context *mbim
>> > > > static int mhi_mbim_get_link_mux_id(struct mhi_controller *cntrl)
>> > > > {
>> > > > if (strcmp(cntrl->name, "foxconn-dw5934e") == 0 ||
>> > > > - strcmp(cntrl->name, "foxconn-t99w515") == 0)
>> > > > + strcmp(cntrl->name, "foxconn-t99w515") == 0 ||
>> > > > + strcmp(cntrl->name, "foxconn-t99w760") == 0)
>> > >
>> > > Can we replace this list of strinc comparisons with some kind of device
>> > > data, being set in the mhi-pci-generic driver?
>> >
>> > If we move this MBIM-specific information into mhi-pci-generic, we
>> > should consider using a software node (e.g. via
>> > device_add_software_node) so that these properties can be accessed
>> > through the generic device-property API.
>> >
>>
>> MHI has to business in dealing with MBIM specific information as we already
>> concluded. So it should be handled within the WWAN subsystem.
>
>it doesn’t make sense to include MBIM-specific fields in a generic MHI
>structure. However, attaching fwnode properties could be reasonable
>since the MHI PCI driver is responsible for device enumeration, and
>that would keep device model specific handling fully covered in that
>driver.
>
>It’s fine to keep device-specific handling within WWAN/MBIM. However,
>next time, please introduce a dedicated device data structure for the
>mux-id instead of adding another strcmp.
>
Hi Loic,
So you answer is yes for this time. I appreciate it very much.
And I will commit another patch for fixing the name "t99w515" to
"t99w640". I have updated it in mhi side in 2025/6.But I forgot to
sync in MBIM side. Please refer to:
https://lore.kernel.org/all/20250606095019.383992-1-slark_xiao@163.com/
Hope that commit won't break your decision.
To avoid such mismatch issue, I agree to use a new mechanism to
make it more convenient.
Currently, it seems only SDX75/SDX35 MBIM solution have this issue.
For whole MHI support products, only Foxconn fell into this trap.
So I hope community could help this for the new design.
Thanks
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v3 2/2] net: wwan: mhi: Add network support for Foxconn T99W760
2025-11-19 10:56 ` [PATCH v3 2/2] net: wwan: mhi: Add network support for Foxconn T99W760 Slark Xiao
2025-11-19 11:27 ` Dmitry Baryshkov
@ 2025-11-21 12:46 ` Loic Poulain
2025-12-18 8:00 ` Slark Xiao
1 sibling, 1 reply; 18+ messages in thread
From: Loic Poulain @ 2025-11-21 12:46 UTC (permalink / raw)
To: Slark Xiao
Cc: mani, ryazanov.s.a, johannes, andrew+netdev, davem, edumazet,
kuba, pabeni, mhi, linux-arm-msm, netdev, linux-kernel
On Wed, Nov 19, 2025 at 11:57 AM Slark Xiao <slark_xiao@163.com> wrote:
>
> T99W760 is designed based on Qualcomm SDX35 chip. It use similar
> architechture with SDX72/SDX75 chip. So we need to assign initial
> link id for this device to make sure network available.
>
> Signed-off-by: Slark Xiao <slark_xiao@163.com>
Reviewed-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
> ---
> drivers/net/wwan/mhi_wwan_mbim.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/wwan/mhi_wwan_mbim.c b/drivers/net/wwan/mhi_wwan_mbim.c
> index c814fbd756a1..a142af59a91f 100644
> --- a/drivers/net/wwan/mhi_wwan_mbim.c
> +++ b/drivers/net/wwan/mhi_wwan_mbim.c
> @@ -98,7 +98,8 @@ static struct mhi_mbim_link *mhi_mbim_get_link_rcu(struct mhi_mbim_context *mbim
> static int mhi_mbim_get_link_mux_id(struct mhi_controller *cntrl)
> {
> if (strcmp(cntrl->name, "foxconn-dw5934e") == 0 ||
> - strcmp(cntrl->name, "foxconn-t99w515") == 0)
> + strcmp(cntrl->name, "foxconn-t99w515") == 0 ||
> + strcmp(cntrl->name, "foxconn-t99w760") == 0)
> return WDS_BIND_MUX_DATA_PORT_MUX_ID;
>
> return 0;
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 18+ messages in thread* Re:Re: [PATCH v3 2/2] net: wwan: mhi: Add network support for Foxconn T99W760
2025-11-21 12:46 ` Loic Poulain
@ 2025-12-18 8:00 ` Slark Xiao
2025-12-30 9:50 ` Loic Poulain
0 siblings, 1 reply; 18+ messages in thread
From: Slark Xiao @ 2025-12-18 8:00 UTC (permalink / raw)
To: Loic Poulain
Cc: mani, ryazanov.s.a, johannes, andrew+netdev, davem, edumazet,
kuba, pabeni, mhi, linux-arm-msm, netdev, linux-kernel
At 2025-11-21 20:46:54, "Loic Poulain" <loic.poulain@oss.qualcomm.com> wrote:
>On Wed, Nov 19, 2025 at 11:57 AM Slark Xiao <slark_xiao@163.com> wrote:
>>
>> T99W760 is designed based on Qualcomm SDX35 chip. It use similar
>> architechture with SDX72/SDX75 chip. So we need to assign initial
>> link id for this device to make sure network available.
>>
>> Signed-off-by: Slark Xiao <slark_xiao@163.com>
>
>Reviewed-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
>
Hi Loic,
May I know when this patch would be applied into net or linux-next?
I saw the changes in MHI side has been applied.
T99W760 device would have a network problem if missing this changes in wwan
side. Please help do a checking.
Thanks
>> ---
>> drivers/net/wwan/mhi_wwan_mbim.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/wwan/mhi_wwan_mbim.c b/drivers/net/wwan/mhi_wwan_mbim.c
>> index c814fbd756a1..a142af59a91f 100644
>> --- a/drivers/net/wwan/mhi_wwan_mbim.c
>> +++ b/drivers/net/wwan/mhi_wwan_mbim.c
>> @@ -98,7 +98,8 @@ static struct mhi_mbim_link *mhi_mbim_get_link_rcu(struct mhi_mbim_context *mbim
>> static int mhi_mbim_get_link_mux_id(struct mhi_controller *cntrl)
>> {
>> if (strcmp(cntrl->name, "foxconn-dw5934e") == 0 ||
>> - strcmp(cntrl->name, "foxconn-t99w515") == 0)
>> + strcmp(cntrl->name, "foxconn-t99w515") == 0 ||
>> + strcmp(cntrl->name, "foxconn-t99w760") == 0)
>> return WDS_BIND_MUX_DATA_PORT_MUX_ID;
>>
>> return 0;
>> --
>> 2.25.1
>>
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: Re: [PATCH v3 2/2] net: wwan: mhi: Add network support for Foxconn T99W760
2025-12-18 8:00 ` Slark Xiao
@ 2025-12-30 9:50 ` Loic Poulain
2025-12-30 10:08 ` Slark Xiao
0 siblings, 1 reply; 18+ messages in thread
From: Loic Poulain @ 2025-12-30 9:50 UTC (permalink / raw)
To: Slark Xiao
Cc: mani, ryazanov.s.a, johannes, andrew+netdev, davem, edumazet,
kuba, pabeni, mhi, linux-arm-msm, netdev, linux-kernel
Hi Slark,
On Thu, Dec 18, 2025 at 9:01 AM Slark Xiao <slark_xiao@163.com> wrote:
>
>
> At 2025-11-21 20:46:54, "Loic Poulain" <loic.poulain@oss.qualcomm.com> wrote:
> >On Wed, Nov 19, 2025 at 11:57 AM Slark Xiao <slark_xiao@163.com> wrote:
> >>
> >> T99W760 is designed based on Qualcomm SDX35 chip. It use similar
> >> architechture with SDX72/SDX75 chip. So we need to assign initial
> >> link id for this device to make sure network available.
> >>
> >> Signed-off-by: Slark Xiao <slark_xiao@163.com>
> >
> >Reviewed-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
> >
> Hi Loic,
> May I know when this patch would be applied into net or linux-next?
> I saw the changes in MHI side has been applied.
> T99W760 device would have a network problem if missing this changes in wwan
> side. Please help do a checking.
You can see status here: https://patchwork.kernel.org/project/netdevbpf/list/
If the changes have not been picked together, please resend this one,
including tags.
Regards,
Loic
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re:Re: Re: [PATCH v3 2/2] net: wwan: mhi: Add network support for Foxconn T99W760
2025-12-30 9:50 ` Loic Poulain
@ 2025-12-30 10:08 ` Slark Xiao
2025-12-30 11:19 ` Paolo Abeni
0 siblings, 1 reply; 18+ messages in thread
From: Slark Xiao @ 2025-12-30 10:08 UTC (permalink / raw)
To: Loic Poulain
Cc: mani, ryazanov.s.a, johannes, andrew+netdev, davem, edumazet,
kuba, pabeni, mhi, linux-arm-msm, netdev, linux-kernel
At 2025-12-30 17:50:39, "Loic Poulain" <loic.poulain@oss.qualcomm.com> wrote:
>Hi Slark,
>
>On Thu, Dec 18, 2025 at 9:01 AM Slark Xiao <slark_xiao@163.com> wrote:
>>
>>
>> At 2025-11-21 20:46:54, "Loic Poulain" <loic.poulain@oss.qualcomm.com> wrote:
>> >On Wed, Nov 19, 2025 at 11:57 AM Slark Xiao <slark_xiao@163.com> wrote:
>> >>
>> >> T99W760 is designed based on Qualcomm SDX35 chip. It use similar
>> >> architechture with SDX72/SDX75 chip. So we need to assign initial
>> >> link id for this device to make sure network available.
>> >>
>> >> Signed-off-by: Slark Xiao <slark_xiao@163.com>
>> >
>> >Reviewed-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
>> >
>> Hi Loic,
>> May I know when this patch would be applied into net or linux-next?
>> I saw the changes in MHI side has been applied.
>> T99W760 device would have a network problem if missing this changes in wwan
>> side. Please help do a checking.
>
>You can see status here: https://patchwork.kernel.org/project/netdevbpf/list/
>
>If the changes have not been picked together, please resend this one,
>including tags.
>
>Regards,
>Loic
Hi Loic,
I checked above link and didn't find my changes.
This is strange since the changes in MHI side of this serial has been applied, but this
has been ignored.
BTW, this changes may not be applicable because another change
https://patchwork.kernel.org/project/netdevbpf/patch/20251120114115.344284-1-slark_xiao@163.com/
has been applied.
So do you want me to resend the new changes based on the latest net baseline ?
Any serials shall be assigned? V4 shall be used?
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v3 2/2] net: wwan: mhi: Add network support for Foxconn T99W760
2025-12-30 10:08 ` Slark Xiao
@ 2025-12-30 11:19 ` Paolo Abeni
0 siblings, 0 replies; 18+ messages in thread
From: Paolo Abeni @ 2025-12-30 11:19 UTC (permalink / raw)
To: Slark Xiao, Loic Poulain
Cc: mani, ryazanov.s.a, johannes, andrew+netdev, davem, edumazet,
kuba, mhi, linux-arm-msm, netdev, linux-kernel
On 12/30/25 11:08 AM, Slark Xiao wrote:
> At 2025-12-30 17:50:39, "Loic Poulain" <loic.poulain@oss.qualcomm.com> wrote:
>> Hi Slark,
>>
>> On Thu, Dec 18, 2025 at 9:01 AM Slark Xiao <slark_xiao@163.com> wrote:
>>>
>>>
>>> At 2025-11-21 20:46:54, "Loic Poulain" <loic.poulain@oss.qualcomm.com> wrote:
>>>> On Wed, Nov 19, 2025 at 11:57 AM Slark Xiao <slark_xiao@163.com> wrote:
>>>>>
>>>>> T99W760 is designed based on Qualcomm SDX35 chip. It use similar
>>>>> architechture with SDX72/SDX75 chip. So we need to assign initial
>>>>> link id for this device to make sure network available.
>>>>>
>>>>> Signed-off-by: Slark Xiao <slark_xiao@163.com>
>>>>
>>>> Reviewed-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
>>>>
>>> Hi Loic,
>>> May I know when this patch would be applied into net or linux-next?
>>> I saw the changes in MHI side has been applied.
>>> T99W760 device would have a network problem if missing this changes in wwan
>>> side. Please help do a checking.
>>
>> You can see status here: https://patchwork.kernel.org/project/netdevbpf/list/
>>
>> If the changes have not been picked together, please resend this one,
>> including tags.
>>
>> Regards,
>> Loic
> Hi Loic,
> I checked above link and didn't find my changes.
> This is strange since the changes in MHI side of this serial has been applied, but this
> has been ignored.
> BTW, this changes may not be applicable because another change
> https://patchwork.kernel.org/project/netdevbpf/patch/20251120114115.344284-1-slark_xiao@163.com/
> has been applied.
>
> So do you want me to resend the new changes based on the latest net baseline ?
> Any serials shall be assigned? V4 shall be used?
You must re-submit this patch, targeting the net-next tree (the subj
prefix must include 'net-next'), but please note:
## Form letter - net-next-closed
The net-next tree is closed for new drivers, features, code refactoring
and optimizations due to the merge window and the winter break. We are
currently accepting bug fixes only.
Please repost when net-next reopens after Jan 2nd.
RFC patches sent for review only are obviously welcome at any time.
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v3 0/2] *** Add support for Foxconn T99W760 ***
2025-11-19 10:56 [PATCH v3 0/2] *** Add support for Foxconn T99W760 *** Slark Xiao
2025-11-19 10:56 ` [PATCH v3 1/2] bus: mhi: host: pci_generic: Add Foxconn T99W760 modem Slark Xiao
2025-11-19 10:56 ` [PATCH v3 2/2] net: wwan: mhi: Add network support for Foxconn T99W760 Slark Xiao
@ 2025-11-20 2:07 ` Jakub Kicinski
2025-11-20 2:47 ` Slark Xiao
2025-11-20 5:45 ` (subset) " Manivannan Sadhasivam
3 siblings, 1 reply; 18+ messages in thread
From: Jakub Kicinski @ 2025-11-20 2:07 UTC (permalink / raw)
To: Slark Xiao
Cc: mani, loic.poulain, ryazanov.s.a, johannes, andrew+netdev, davem,
edumazet, pabeni, mhi, linux-arm-msm, netdev, linux-kernel
On Wed, 19 Nov 2025 18:56:13 +0800 Slark Xiao wrote:
> Subject: [PATCH v3 0/2] *** Add support for Foxconn T99W760 ***
> *** This series add support for Foxconn 5G modem T99W760 ***
Please don't with the ***.
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re:Re: [PATCH v3 0/2] *** Add support for Foxconn T99W760 ***
2025-11-20 2:07 ` [PATCH v3 0/2] *** Add support for Foxconn T99W760 *** Jakub Kicinski
@ 2025-11-20 2:47 ` Slark Xiao
0 siblings, 0 replies; 18+ messages in thread
From: Slark Xiao @ 2025-11-20 2:47 UTC (permalink / raw)
To: Jakub Kicinski
Cc: mani, loic.poulain, ryazanov.s.a, johannes, andrew+netdev, davem,
edumazet, pabeni, mhi, linux-arm-msm, netdev, linux-kernel
At 2025-11-20 10:07:35, "Jakub Kicinski" <kuba@kernel.org> wrote:
>On Wed, 19 Nov 2025 18:56:13 +0800 Slark Xiao wrote:
>> Subject: [PATCH v3 0/2] *** Add support for Foxconn T99W760 ***
>
>> *** This series add support for Foxconn 5G modem T99W760 ***
>
>Please don't with the ***.
My bad. It's my first time to use the cover letter.
And I replace the contents and subject according to the guide but
missing those ***. Will remove it if next version is required.
Thanks
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: (subset) [PATCH v3 0/2] *** Add support for Foxconn T99W760 ***
2025-11-19 10:56 [PATCH v3 0/2] *** Add support for Foxconn T99W760 *** Slark Xiao
` (2 preceding siblings ...)
2025-11-20 2:07 ` [PATCH v3 0/2] *** Add support for Foxconn T99W760 *** Jakub Kicinski
@ 2025-11-20 5:45 ` Manivannan Sadhasivam
3 siblings, 0 replies; 18+ messages in thread
From: Manivannan Sadhasivam @ 2025-11-20 5:45 UTC (permalink / raw)
To: mani, loic.poulain, ryazanov.s.a, johannes, andrew+netdev, davem,
edumazet, kuba, pabeni, Slark Xiao
Cc: mhi, linux-arm-msm, netdev, linux-kernel
On Wed, 19 Nov 2025 18:56:13 +0800, Slark Xiao wrote:
> *** This series add support for Foxconn 5G modem T99W760 ***
>
> Updates:
> v3: Fix the 2 patches not in one thread issue
> v2: Add net and MHI mantainer together
>
> Slark Xiao (2):
> bus: mhi: host: pci_generic: Add Foxconn T99W760 modem
> net: wwan: mhi: Add network support for Foxconn T99W760
>
> [...]
Applied, thanks!
[1/2] bus: mhi: host: pci_generic: Add Foxconn T99W760 modem
commit: d44619821f46e724bca2a001fa7daa35d4e5602d
Best regards,
--
Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 18+ messages in thread